[Release] Market Observer

[spara]

New version 3.7/1.0 is available in the manager. The oxp has been split into two for maximal enjoyment and customizability now that I actually figured out how to make those custom column headers work somewhat properly with all those different custom fonts out there without the help of a custom hud.

* Market Observer 3.7 has the market stat and trader's rating functionality. Trader's rating can be viewed in the ship's manifest.
* Market Ads 1.0 adds, well, the ads to the market screen with the help of a custom hud as before. Now the trader's rating can be seen in the market screen also.

You can install either or both or neither, whatever is your preference

[vaxon]

It's just the way I need. Awesome! Thanks man!

[vaxon]

Hi Spara!
Just FYI, it's not a big deal but I've just noticed that the F8 screen gets a bit messed up in the witch-space when a misjump occurs.
Other than that the market observer seem to work perfectly fine.

[Reval]

Hi Spara,

Been using Market Observer (installed from the OXZ manager in v.1.90) for a few days now, and have noticed an anomaly - or is it a bug?

Despite making consistent and continuous profits on various 'milk runs' since starting out, Market Observer continues to insist that my commander(s) should be rated Beginner, with increasing negative scores, ie. losses. These messages on docking with main stations are starting to irritate, tempting me to remove the OXZ, which otherwise works fine and is a useful aid to trading in the Ooniverse.

Here is the relevant part of the market_observer.js script:

if (profitLoss > 0) {
worldScripts["mo-traders_rating3"].$reportProfit(-1 * profitLoss);
player.consoleMessage(formatCredits(profitLoss/10, true, true )+" worth of cargo is lost.");


I'd tweak it myself if I could figure out the variables, but the logic seems a little complicated... So I was hoping you might be able to help.

[Cholmondely]

Been using Market Observer (installed from the OXZ manager in v.1.90) for a few days now, and have noticed an anomaly - or is it a bug?

Despite making consistent and continuous profits on various 'milk runs' since starting out, Market Observer continues to insist that my commander(s) should be rated Beginner, with increasing negative scores, ie. losses. These messages on docking with main stations are starting to irritate, tempting me to remove the OXZ, which otherwise works fine and is a useful aid to trading in the Ooniverse.

I, too, found exactly the same. I found Market Observer too useful to ditch - and the bug too easy to ignore.

But just yesterday, I started wondering - maybe MO includes my constant forays buying goodies for my Despondent Denizen of Digebiti in the shipyard in its overall profit and loss account for each planet? Do all Benedict's buoyant bouncing bobbleheads depress the DDD's profits?

[Reval]

I, too, found exactly the same. I found Market Observer to useful to ditch - and the bug too easy to ignore.

Indeed. With that in mind and being loath to nuke it, I assigned an empty string to the offending variable traderRank in both the docking message and the Manifest screen, commenting out the egregious lines:

Code: Select all

//Trader rank for market hud
this.$setInstruction = function() { //set trader rank text to manifest
	var traderRank = ""; // Reval blanked this out until loss-bug is fixed
	//var traderRank = "Trader's Rating: " + this.$traderRank() + " (" + formatCredits(this.$profit/10, true, true ) + ")";
	player.ship.setCustomHUDDial("marketObserverProfit", traderRank);
	mission.setInstructions(traderRank+".", this.name);

(that's lines 37-43 in mo_traders_rating.js)

and here in market_observer.js, lines 221-225:

Code: Select all

	if (profitLoss > 0) {
		worldScripts["mo-traders_rating3"].$reportProfit(-1 * profitLoss);
		// Is this is a bug? (Reval)
		// player.consoleMessage(formatCredits(profitLoss/10, true, true )+" worth of cargo is lost.");
	}

Save, and restart Oolite with the <shift> key held down, and no more irritation

Would still appreciate help from Spara in nailing the causes though...

[spara]

Hang on people and please keep on posting , I'll take a good look at these problems the moment I have some extra time to spend.

[spara]

I did a bit of buying and selling between two systems with basically just MO installed and did not see any anomalies . Also bought some equipment and jettisoned some cargo. So, if there's any more information you could give me, I would be most pleased. Like a chain of events that lead to the bug. Also, do you happen to have any other oxps that might fiddle with markets and ship manifest? For example hyper cargo is one known one that.

[Reval]

No unusual activities leading to the anomaly - just milk runs, most recently between Xexedi and Laenin short-haul. The "cargo lost" docking message occurs in both the Adder and the Cobra I and III. Not always, mind - usually at just one of the stops (Xexedi, I think).

MO is the only trading OXP I have installed.

Other OXPs include:

Code: Select all

    Additional Planets SR pack Demux Earthlike 1.1 1.1
    Additional Planets SR pack Demux Ocean 1.1
    Additional Planets SR pack Others Gas Giants 1.1
    Additional Planets SR pack Redux 1.1
    Autodock_Core 1.1.0
    Automatic ECM System 0.3.2 - for Oolite 1.75 and later
    AutoRefuel 1.0
    BarrelRoll 1.0
    BGS 2.5.1
    commandersLog 1.01
    Docked_HUDs 1.1
    Explorers Club 1.4.4
    extra_tanks_script.js 1.8
    FastTargetSelector 1.5
    FlightLog 1.11
    Fuel Collector 0.07
    FuelInjectionCruiseControl 0.7
    FuelTweaks_FuelEconomy 1.14.4
    FuelTweaks_Quirium 1.14.4
    FuelTweaks_StationSetup 1.14.4
    GlareClarifier 1.0
    HomeSystem 0.12
    ils 1.13
    Lib_2DCollision 1.7.1
    Lib_Animator 1.7.1
    Lib_BinSearch 1.7.1
    Lib_Config 1.7.1
    Lib_Crypt 1.7.1
    Lib_Cubecode 1.7.1
    Lib_EntityStrength 1.7.1
    Lib_GUI 1.7.1
    Lib_Main 1.7.1
    Lib_MissionCoord 1.7.1
    Lib_Music 1.7.1
    Lib_PAD 1.7.1
    Lib_PAD_Events 1.7.1
    Lib_Starmap 1.7.1
    market_ads 1.0
    market_ads_service 1.0
    market_observer3 3.7
    masslock_compensator 1.4
    mil_injectors.js 1.03
    mo-traders_rating3 3.7
    NS_Mining_Scanner_Upgrade 1.1.3
    Oolite Equipment Control 1.90
    Oolite Ship Library 1.90
    oolite-cloaking-device 1.90
    oolite-constrictor-hunt 1.90
    oolite-contracts-cargo 1.90
    oolite-contracts-helpers 1.90
    oolite-contracts-parcels 1.90
    oolite-contracts-passengers 1.90
    oolite-libPriorityAI 1.90
    oolite-nova 1.90
    oolite-populator 1.90
    oolite-primable-equipment-register 1.90
    oolite-registership 1.90
    oolite-thargoid-plans 1.90
    oolite-trumbles 1.90
    oolite-tutorial 1.90
    oreProcessor 2.2.2
    power_to_engines 1.2
    randomshipnames 1.6
    sell_equipment 1.5
    sellall 1.29
    shiplib 1.0
    sniperlock 1.0
    star-fuel 1.0
    Stars 0.5.1
    System Redux 0.8
    targetAutolock 1.11
    telescope 1.15
    Tionisla Chronicle Array OXP 1.04
    torustosun 1.7
    Untrumbled 1.1
    variablemasslock 1.1

And, as I said, I'm running v.1.90 on PC x86.

Weird, eh?

[Reval]

Oh hang on a minute - I _do_ have one other trading-related: It's called SellAll, and allows you to sell all your cargo from the F4 screen (or find an alternative buyer). Doing that ends up on the F8 trading screen. I tend to use that method most of the time. Can't really see how it could conflict, though. But maybe it does. I'll try removing it and report back.

[spara]

Oh hang on a minute - I _do_ have one other trading-related: It's called SellAll, and allows you to sell all your cargo from the F4 screen (or find an alternative buyer). Doing that ends up on the F8 trading screen. I tend to use that method most of the time. Can't really see how it could conflict, though. But maybe it does. I'll try removing it and report back.

Thanks, that's probably it. Seems like there's a compatibility hack in the SellAll script that checks for the script called "market_observer" and fails there since the current one is "market_observer3". You could test hacking the SellAll and changing all references from "market_observer" to "market_observer3" and see if that makes a difference. If needed, I can of course change the current script name to "market_observer", but I have no idea if that would break something else Better try to keep this contained.

[Reval]

You could test hacking the SellAll and changing all references from "market_observer" to "market_observer3" and see if that makes a difference.

Cheers. I'll go with that suggestion first, and let you know...

[Reval]

Nope. Did a search/replace on "market_observer"-->"market_observer3" in SellAll's script, restarted with <shift>, and the MO "cargo lost" negative scores are still in place

That was with an existing commander. Maybe I should start a new commander and see? (I presume MO is adding an entry to the savegame?).

[Reval]

Yay! Starting from scratch with a new commander cleared the "bug" in MO

(That's with the SellAll script substitutions you kindly suggested.)

My Jameson's first sale resulted in an MO rating of Amateur, not Beginner as previously.

So I can now keep both OXPs.

Many thanks for your guidance.

[Josef]

Does anybody know on what TechLevel I can get that equipment and how wuch it costs?