libpng in GNUmakefile

[dybal]

Greetings!

I cloned the Master branch, initiated and checked-out the submodules, build with release-deployment target, created a package with pkg-posix target and installed the 1.89 version.

When I tried to run it crashed:

Code: Select all

./oolite.app/oolite: /home/dybal/GNUstep/Applications/Oolite/oolite-deps/lib/libz.so.1: version `ZLIB_1.2.9' not found (required by /usr/lib/x86_64-linux-gnu/libpng16.so.16)

Erk. It looks like Oolite died with an error. When making an error
report, please copy + paste the log above into the report.

(Press Ctrl-C to continue)

Now, oolite-deps has libpng14.so.14, so I think the libpng16 from my distro (LinuxMint 19.3) was linked to the oolite binary.

Looking at GNUmakefile, around line 72:

Code: Select all

    ADDITIONAL_OBJC_LIBS         = $(OOLITE_SHARED_LIBS) -lGLU -lGL -lX11 -lSDL -lgnustep-base -L$(LIBJS_DIR) -l$(LIBJS) -lopenal -lz -lvorbisfile -lpng `nspr-config --libs` -lstdc++

I changed it to:

Code: Select all

    ADDITIONAL_OBJC_LIBS         = $(OOLITE_SHARED_LIBS) -lGLU -lGL -lX11 -lSDL -lgnustep-base -L$(LIBJS_DIR) -l$(LIBJS) -lopenal -lz -lvorbisfile -lpng14 `nspr-config --libs` -lstdc++

rebuild, reinstalled and now it works...

[hiran]

This is interesting.

I reconstructed the linux builds so they run automatically on GitHub. However only lately I really tried the 1.91 prerelease on a freshly installed Ubuntu 22 LTS. Oolite 1.91 fails with a similar error message.

Code: Select all

demo@OoliteDemo:~/GNUstep/Applications/Oolite-trunk/oolite.app$ ./oolite
./oolite: error while loading shared libraries: libSDL-1.2.so.0: cannot open shared object file: No such file or directory
demo@OoliteDemo:~/GNUstep/Applications/Oolite-trunk/oolite.app$ 

Code: Select all

demo@OoliteDemo:~/GNUstep/Applications/Oolite-trunk$ ./oolite-trunk
./oolite.app/oolite: error while loading shared libraries: libgnustep-base.so.1.28: cannot open shared object file: No such file or directory

Erk. It looks like Oolite-trunk died with an error. When making an error
report, please copy + paste the log above into the report.

demo@OoliteDemo:~/GNUstep/Applications/Oolite-trunk$ 

So there is something not right. I will try to tweak/apply your fix.