Fuel Station OXP

[gsagostinho]

Hi all, I spoke with Thargoid and it seems he was not the person who uploaded the previous version of this OXP to the extension manager in the game, so would anyone know who was the uploader? And if not, is there an easy way of figuring that out? The list here only shows the author according to the manifest files, but not who uploaded them (and, to my understanding, the only person able to remove them).

If this OXP has had any maintainer since Thargoid, my apologies for uploading version 2.x without any contact, it was really not intentional!

[gsagostinho]

Version 2.2 is now available in the extension manager, it improves the way light reflects on the surfaces of the satellite model.

[nobswolf]

The versions are some how mixed up. With now Fuel Station installed only version 2.2 is offered. I checked the file system: There is now file of this OXP.
When I install Fuel Station then the list says I also have 1.36 installed. I checked with strace: No other version of this OXP is even tried to get read.

See the screen shot

https://bnm.me/Evixyofrag7/Bildschirmfo ... -00-03.png

How do I get rid of this?

[gsagostinho]

@nobswolf This is what I wrote above: while I got the permission from Thargoid to modify this OXP, I just can't find who is the maintainer to remove the older version from the manager (I don't have access to that myself). I tried asking around but it seems nobody knows about it, so we need to live with two versions on the manager. Just go for version 2.2 and you should be good to go.

[Cholmondely]

Looking through the code in the oxp I can't see where the code tells Oolite to place these along Route One in Galaxy One.

Can anybody please show me?

Shipdata.plist

Code: Select all

{
	"fuelStation_station" = 
	{	
		ai_type = "fuelStation_stationAI.plist";
		beacon = "fuelStation_station";
		cargo_type = "CARGO_NOT_CARGO";
		energy_recharge_rate = 2;
		forward_weapon_type = "WEAPON_NONE";
		frangible = no;
		has_ecm = yes;
		has_escape_pod = no;
		has_scoop = no;
		has_npc_traffic = no;
		hasShipyard = no;
		isCarrier = no;
		likely_cargo = 0;
		max_cargo = 0;
		max_defense_ships = 0;
		max_energy = 1000;
		max_flight_pitch = 0.0;
		max_flight_roll = 0.0;
		max_flight_speed = 0.0;
		missiles = 0;
		materials = 
					{ 
						"fuelStation_station.png" = 
						{ 
							diffuse_map = "fuelStation_station.png"; 
							normal_map = "fuelStation_station_normal.png";
							specular_color = ( 0.3, 0.3, 0.3 );
							shininess = 15;
						}; 
					};	
		model = "fuelStation_station.dat";
		name = "Fuel Station";
		roles = "fuelStation_station fuelStation_location";
		rotating = no;
		scanClass = "CLASS_STATION";
		smooth = yes;
		thrust = 500;
		script = "fuelStation_station.js";
		subentities = (
			"*FLASHER* 0 0 0 50 0 0 300",			// central yellow glow
			"*FLASHER* -268.11432 89.37144 0 0 1 0 50",	// red lights on central ring ridge
			"*FLASHER* -268.11432 -89.37144 0 0 1 0 50",
			"*FLASHER* 268.11432 89.37144 0 0 1 0 50",
			"*FLASHER* 268.11432 -89.37144 0 0 1 0 50",
			"*FLASHER* -89.37144 268.11432 0 0 1 1 50",
			"*FLASHER* -89.37144 -268.11432 0 0 1 1 50",
			"*FLASHER* 89.37144 268.11432 0 0 1 1 50",
			"*FLASHER* 89.37144 -268.11432 0 0 1 1 50",
			"*FLASHER* -168.75 -56.25 375 120 1 1 50",	// green lights one end
			"*FLASHER* -168.75 56.25 375 120 1 1 50",
			"*FLASHER* -56.25 168.75 375 120 1 1 50",
			"*FLASHER* 56.25 168.75 375 120 1 1 50",
			"*FLASHER* 168.75 56.25 375 120 1 1 50",
			"*FLASHER* 168.75 -56.25 375 120 1 1 50",
			"*FLASHER* 56.25 -168.75 375 120 1 1 50",
			"*FLASHER* -56.25 -168.75 375 120 1 1 50",
			"*FLASHER* 56.25 -168.75 -375 120 1 1 50",	// green lights at the other end
			"*FLASHER* 168.75 -56.25 -375 120 1 1 50",
			"*FLASHER* 168.75 56.25 -375 120 1 1 50",
			"*FLASHER* 56.25 168.75 -375 120 1 1 50",
			"*FLASHER* -56.25 168.75 -375 120 1 1 50",
			"*FLASHER* -168.75 56.25 -375 120 1 1 50",
			"*FLASHER* -168.75 -56.25 -375 120 1 1 50",
			"*FLASHER* -56.25 -168.75 -375 120 1 1 50"
			);
		track_contacts = yes;
	};

	"fuelStation_satellite" = 
	{	
		ai_type = "fuelStation_satelliteAI.plist";
		beacon = "fuelStation_satellite";
		cargo_type = "CARGO_NOT_CARGO";
		energy_recharge_rate = 2;
		forward_weapon_type = "WEAPON_NONE";
		frangible = no;
		has_ecm = yes;
		has_escape_pod = no;
		has_scoop = no;
		has_npc_traffic = no;
		hasShipyard = no;
		isCarrier = no;
		likely_cargo = 0;
		max_cargo = 0;
		max_defense_ships = 0;
		max_energy = 1000;
		max_flight_pitch = 0.2;
		max_flight_roll = 0.2;
		max_flight_speed = 0.0;
		missiles = 0;
		model = "fuelStation_satellite.dat";
		materials = 
					{ 
						"fuelStation_satellite.png" = 
						{ 
							diffuse_map = "fuelStation_satellite.png"; 
							normal_map = "fuelStation_satellite_normal.png";
							specular_color = ( 0.3, 0.3, 0.3 );
							shininess = 15;
						}; 
					};	
		name = "Fuel Satellite";
		roles = "fuelStation_satellite fuelStation_location";
		rotating = no;
		scanClass = "CLASS_STATION";
		smooth = yes;
		thrust = 500;
		script = "fuelStation_satellite.js";
		subentities = ( 
			"*FLASHER* 0 0 0 50 0.25 0 30", // central yellow
			"*FLASHER* 0 20 20 120 1 0 3", // top row greens
			"*FLASHER* -20 20 0 120 1 0 3",
			"*FLASHER* 0 20 -20 120 1 0 3",
			"*FLASHER* 20 20 0 120 1 0 3",
			"*FLASHER* -20 0 20 120 1 1.5 3", // centre band greens
			"*FLASHER* -20 0 -20 120 1 1.5 3",
			"*FLASHER* 20 0 -20 120 1 1.5 3",
			"*FLASHER* 20 0 20 120 1 1.5 3",
			"*FLASHER* 20 -20 0 120 1 0 3", // lower row greens
			"*FLASHER* 0 -20 20 120 1 0 3",
			"*FLASHER* -20 -20 0 120 1 0 3",
			"*FLASHER* 0 -20 -20 120 1 0 3"
			);
		track_contacts = no;
	};


	"fuelStation_burningFuel" =
	{
		ai_type = "fuelStation_burningFuelAI.plist";
		cargo_type = "CARGO_NOT_CARGO";
		energy_recharge_rate = 0;
		forward_weapon_type = "WEAPON_NONE";
		max_energy = 1;
		max_flight_pitch = 0.5;
		max_flight_roll = 0.5;
		max_flight_speed = 150;
		missiles = 0;
		likely_cargo = 0;
		max_cargo = 0;
		model = "alloy.dat";
		name = "Burning quirium fuel";
		roles = "fuelStation_burningFuel";
		scanClass = "CLASS_CARGO";
		thrust = 0;
		unpiloted = true;
		weapon_energy = 40;
	};
}

fuelStation_stationSetup.js

Code: Select all

this.name					= "FuelStation-Setup";
this.author					= "Thargoid";
this.copyright				= "Creative Commons: attribution, non-commercial, sharealike with clauses - see readme.txt";
this.description			= "Script to add fuel station to certain systems";
this.version				= "2.02";

this.extraA = true;	// for use with turretted ships - set to false to only get fuel satellites
this.extraB = true;	// if set to false, no NPCs will use the stations (if extraA is false, has no effect)
	
this.oxpcSettings = {
	Info: {Name:this.name,Display:this.name,InfoB:"1 - If false only fuel satellites will appear.\n2 - If false NPCs will not use fuel stations (ignored if extraA is false)."},
	Bool0: {Name:"extraA",Def:true,Desc:"Suppress fuel stations."},
	Bool1: {Name:"extraB",Def:false,Desc:"Allow NPCs to use fuel stations."}
};	

this.startUp = function()
	{
	this.positionOverride = false; // set this to true to use alternative station positioning at far side of witchpoint only.
	}

this.shipWillLaunchFromStation = function()
	{
	this.shipExitedWitchspace();
	delete this.shipWillLaunchFromStation;
	}
	
this.shipExitedWitchspace = function()
	{
	if(this.positionOverride === false)
		{ this.originalStationSetup(); }
	else
		{ this.witchpointStationSetup(); }
	}
	
this.witchpointStationSetup = function() // fixed station position on far side of witchpoint area.
	{
	if(system.isInterstellarSpace || system.sun.isGoingNova || system.sun.hasGoneNova || missionVariables.longwayround === "STAGE1" || missionVariables.longwayround === "STAGE2") 
	// stop the script if interstellar space, or system is going Nova(to allow Nova mission unhindered) or indeed if it has gone nova already.
		{ return; }

	if(system.government > 1 && system.techLevel > 3 && system.countShipsWithRole("fuelStation_location") === 0)
		{
		if(this.extraA && system.scrambledPseudoRandomNumber(19.7) > 0.33)
			{ system.legacy_addShipsAt("fuelStation_station", 1, "wpm", [0, 0, -24000]); }
		else
			{ system.legacy_addShipsAt("fuelStation_satellite", 1, "wpm", [0, 0, -24000]); }
		}
	}	
	
this.originalStationSetup = function() // original locations, near witchpoint and on route 1.
	{
	if(system.isInterstellarSpace || system.sun.isGoingNova || system.sun.hasGoneNova) 
		{ // stop the script if interstellar space, or system is going Nova(to allow Nova mission unhindered) or indeed if it has gone nova already.
		return;
		}

	this.halfwayChance = 0.25; // 3 in 4 chance to add a station at the half-way point of route 1.
	this.witchpointChance = 0.33; // 2 in 3 chance to add a station near the witchpoint.

	if(missionVariables.longwayround === "STAGE1" || missionVariables.longwayround === "STAGE2")
		{ // drastically reduce the chances if you're in the middle of Long Way Round mission
		this.halfwayChance = 0.9; // 1 in 10 chance to add a station at the half-way point of route 1.
		this.witchpointChance = 0.95; // 1 in 20 chance to add a station near the witchpoint.
		}

	if(system.government > 1 && system.techLevel > 3 && system.countShipsWithRole("fuelStation_location") === 0)
		{
		if(system.scrambledPseudoRandomNumber(13.7) > this.witchpointChance)
			{
			if(this.extraA && system.scrambledPseudoRandomNumber(17.4) > 0.33)
				{
	 			system.legacy_addShipsAt("fuelStation_station", 1, "pwu", [0.02, 0, 1]);
				}
			else
				{
	 			system.legacy_addShipsAt("fuelStation_satellite", 1, "pwu", [0.02, 0, 1]);
				}
			}

		if(system.scrambledPseudoRandomNumber(25.3) > this.halfwayChance)
			{
			if(this.extraA && system.scrambledPseudoRandomNumber(24.1) > 0.33)
				{
	 			system.legacy_addShipsAt("fuelStation_station", 1, "pwu", [0.02, 0, 0.5]);
				}
			else
				{
	 			system.legacy_addShipsAt("fuelStation_satellite", 1, "pwu", [0.02, 0, 0.5]);
				}
			}

		}
	}

The other scripts seem even less relevant...

[phkb]

I think "Route 1" in the context of what this code is doing is the "Planet - Witchpoint Route". The code that adds the fuel stations is

Code: Select all

if(this.extraA && system.scrambledPseudoRandomNumber(24.1) > 0.33)
				{
	 			system.legacy_addShipsAt("fuelStation_station", 1, "pwu", [0.02, 0, 0.5]);
				}
			else
				{
	 			system.legacy_addShipsAt("fuelStation_satellite", 1, "pwu", [0.02, 0, 0.5]);
				}
			}

The "pwu" refers to the "planet-witchpoint" route.

[Slartibartfast]

hello

i have made some changes in the shipdata.plist to remove the
boring messages in the log about the "subentities".

-- converted to the new "subentity-format"
-- shortened the long real numbers ( i cant see any difference )
-- used "redColor, greenColor, etc -- because i can't do it better

... feel free to use it

Code: Select all

{
	"fuelStation_station" =
	{
		ai_type = "fuelStation_stationAI.plist";
		beacon = "fuelStation_station";
		cargo_type = "CARGO_NOT_CARGO";
		energy_recharge_rate = 2;
		forward_weapon_type = "WEAPON_NONE";
		frangible = no;
		has_ecm = yes;
		has_escape_pod = no;
		has_scoop = no;
		has_npc_traffic = no;
		hasShipyard = no;
		isCarrier = no;
		likely_cargo = 0;
		max_cargo = 0;
		max_defense_ships = 0;
		max_energy = 1000;
		max_flight_pitch = 0.0;
		max_flight_roll = 0.0;
		max_flight_speed = 0.0;
		missiles = 0;
		materials =
					{
						"fuelStation_station.png" =
						{
							diffuse_map = "fuelStation_station.png";
							normal_map = "fuelStation_station_normal.png";
							specular_color = ( 0.3, 0.3, 0.3 );
							shininess = 15;
						};
					};
		model = "fuelStation_station.dat";
		name = "Fuel Station";
		roles = "fuelStation_station fuelStation_location";
		rotating = no;
		scanClass = "CLASS_STATION";
		smooth = yes;
		thrust = 500;
		script = "fuelStation_station.js";
		subentities = (
      { type = "flasher"; size = 300.0; color = "yellowColor"; frequency = 0.0; phase = 0.0; position = "0.0 0.0 0.0"; }, //central yellow glow
			{ type = "flasher"; size = 50.0; color = "redColor";   frequency = 1.0; phase = 0.0; position = "-268.11   89.37 0.0"; }, //red central ring
			{ type = "flasher"; size = 50.0; color = "redColor";   frequency = 1.0; phase = 0.0; position = "-268.11  -89.37 0.0"; },
			{ type = "flasher"; size = 50.0; color = "redColor";   frequency = 1.0; phase = 0.0; position = " 268.11   89.37 0.0"; },
			{ type = "flasher"; size = 50.0; color = "redColor";   frequency = 1.0; phase = 0.0; position = " 268.11  -89.37 0.0"; },
			{ type = "flasher"; size = 50.0; color = "redColor";   frequency = 1.0; phase = 1.0; position = " -89.37  268.11 0.0"; },
			{ type = "flasher"; size = 50.0; color = "redColor";   frequency = 1.0; phase = 1.0; position = " -89.37 -268.11 0.0"; },
			{ type = "flasher"; size = 50.0; color = "redColor";   frequency = 1.0; phase = 1.0; position = "  89.37  268.11 0.0"; },
			{ type = "flasher"; size = 50.0; color = "redColor";   frequency = 1.0; phase = 1.0; position = "  89.37 -268.11 0.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = "-168.75  -56.25 375.0"; }, // green lights A
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = "-168.75   56.25 375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = " -56.25  168.75 375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = "  56.25  168.75 375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = " 168.75   56.25 375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = " 168.75  -56.25 375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = "  56.25 -168.75 375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = " -56.25 -168.75 375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = "  56.25 -168.75 -375.0"; }, // green lights B
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = " 168.75  -56.25 -375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = " 168.75   56.25 -375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = "  56.25  168.75 -375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = " -56.25  168.75 -375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = "-168.75   56.25 -375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = "-168.75  -56.25 -375.0"; },
			{ type = "flasher"; size = 50.0; color = "greenColor"; frequency = 1.0; phase = 1.0; position = " -56.25 -168.75 -375.0"; }
			);
		track_contacts = yes;
	};

	"fuelStation_satellite" =
	{
		ai_type = "fuelStation_satelliteAI.plist";
		beacon = "fuelStation_satellite";
		cargo_type = "CARGO_NOT_CARGO";
		energy_recharge_rate = 2;
		forward_weapon_type = "WEAPON_NONE";
		frangible = no;
		has_ecm = yes;
		has_escape_pod = no;
		has_scoop = no;
		has_npc_traffic = no;
		hasShipyard = no;
		isCarrier = no;
		likely_cargo = 0;
		max_cargo = 0;
		max_defense_ships = 0;
		max_energy = 1000;
		max_flight_pitch = 0.2;
		max_flight_roll = 0.2;
		max_flight_speed = 0.0;
		missiles = 0;
		model = "fuelStation_satellite.dat";
		materials =
					{
						"fuelStation_satellite.png" =
						{
							diffuse_map = "fuelStation_satellite.png";
							normal_map = "fuelStation_satellite_normal.png";
							specular_color = ( 0.3, 0.3, 0.3 );
							shininess = 15;
						};
					};
		name = "Fuel Satellite";
		roles = "fuelStation_satellite fuelStation_location";
		rotating = no;
		scanClass = "CLASS_STATION";
		smooth = yes;
		thrust = 500;
		script = "fuelStation_satellite.js";
		subentities = (
			{ type = "flasher"; size = 30.0; color = "yellowColor"; frequency = 0.25; phase = 0.0; position = "0.0 0.0 0.0"; }, // central yellow
			{ type = "flasher"; size = 3.0; color = "greenColor"; frequency = 1.0; phase = 0.0; position = "  0.0  20.0  20.0"; }, // top row greens
			{ type = "flasher"; size = 3.0; color = "greenColor"; frequency = 1.0; phase = 0.0; position = "-20.0  20.0   0.0"; },
			{ type = "flasher"; size = 3.0; color = "greenColor"; frequency = 1.0; phase = 0.0; position = "  0.0  20.0 -20.0"; },
			{ type = "flasher"; size = 3.0; color = "greenColor"; frequency = 1.0; phase = 0.0; position = " 20.0  20.0   0.0"; },
			{ type = "flasher"; size = 3.0; color = "greenColor"; frequency = 1.0; phase = 1.5; position = "-20.0   0.0  20.0"; }, // centre band greens
			{ type = "flasher"; size = 3.0; color = "greenColor"; frequency = 1.0; phase = 1.5; position = "-20.0   0.0 -20.0"; },
			{ type = "flasher"; size = 3.0; color = "greenColor"; frequency = 1.0; phase = 1.5; position = " 20.0   0.0 -20.0"; },
			{ type = "flasher"; size = 3.0; color = "greenColor"; frequency = 1.0; phase = 1.5; position = " 20.0   0.0  20.0"; },
			{ type = "flasher"; size = 3.0; color = "greenColor"; frequency = 1.0; phase = 0.0; position = " 20.0 -20.0   0.0"; }, // lower row greens
			{ type = "flasher"; size = 3.0; color = "greenColor"; frequency = 1.0; phase = 0.0; position = "  0.0 -20.0  20.0"; },
			{ type = "flasher"; size = 3.0; color = "greenColor"; frequency = 1.0; phase = 0.0; position = "-20.0 -20.0   0.0"; },
			{ type = "flasher"; size = 3.0; color = "greenColor"; frequency = 1.0; phase = 0.0; position = "  0.0 -20.0 -20.0"; }
			);
		track_contacts = no;
	};


	"fuelStation_burningFuel" =
	{
		ai_type = "fuelStation_burningFuelAI.plist";
		cargo_type = "CARGO_NOT_CARGO";
		energy_recharge_rate = 0;
		forward_weapon_type = "WEAPON_NONE";
		max_energy = 1;
		max_flight_pitch = 0.5;
		max_flight_roll = 0.5;
		max_flight_speed = 150;
		missiles = 0;
		likely_cargo = 0;
		max_cargo = 0;
		model = "alloy.dat";
		name = "Burning quirium fuel";
		roles = "fuelStation_burningFuel";
		scanClass = "CLASS_CARGO";
		thrust = 0;
		unpiloted = true;
		weapon_energy = 40;
	};
}

cheers
matthias

[Slartibartfast]

hello

last night i played around with the "red flashers" of the station.
==> now i have a version with "rotating" ones - (only "phase", "frequency" and order adapted )

i think, that it looks nice

btw.
my former "tweak" removes ~15 till 20 lines of error messages in the log.
-- what is the right way, that those little changes goes into "managed addons"?
!!!! if there is an easy way ( without bureaucracy ) - i'll clean up more addons

matthias

[montana05]

-- what is the right way, that those little changes goes into "managed addons"?
!!!! if there is an easy way ( without bureaucracy ) - i'll clean up more addons
matthias

Well, there are basically 2 ways I could think of:

You get yourself a sign-on for the expansion manager and officially take over the maintenance for this OXP so that the rights for this package could be transferred to you.

You can pm phkb and ask for an upload of your version. Except the author, he is currently the only one with access to this oxz. If you decide this variant, please don't forget to update the manifest.plist as well.

[Slartibartfast]

Hello montana05

the first one .. no!
then i will be the "maintainer" of a lot of addons in a short time.

( i think this preserves other people to publish their ideas -
---- is the same as in my former company
--- i have seen a problem - had an idea (theoretical) to solve
------ then i was told to remove the problem ( between my normal work )
=====>> i have never done this later ( i closed my mouth )

the 2nd one
hmmmm ..... i can do
but i don't wanna overload him with such "Kleinscheiss" ( now you have to translate )

matthias

[montana05]

the first one .. no!
then i will be the "maintainer" of a lot of addons in a short time.

Tell me, after most quick fixes, I ended up with the maintenance.

the 2nd one
hmmmm ..... i can do
but i don't wanna overload him with such "Kleinscheiss" ( now you have to translate )

If your update is well-prepared, it will take around 5 min to upload. Btw no need to use a translator, I speak German as well.