[Release] System Features: Rings
Moderators: winston, another_commander
- Cody
- Sharp Shooter Spam Assassin
- Posts: 16081
- Joined: Sat Jul 04, 2009 9:31 pm
- Location: The Lizard's Claw
- Contact:
Re: [Release] System Features: Rings
Don't mind old Coyote - he be a bit of a character! Arrr!
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
And any survivors, their debts I will certainly pay. There's always a way!
- Cody
- Sharp Shooter Spam Assassin
- Posts: 16081
- Joined: Sat Jul 04, 2009 9:31 pm
- Location: The Lizard's Claw
- Contact:
Re: [Release] System Features: Rings
I extracted the
Something to do with saving? After each save, it adds another one. <scratches head> Or is it something I've done?
*At first it was two, then three, but I have no pics.
oxz
from the manager to my AddOns
folder and tweaked the numbers. Happy with that, I removed the oxp
for later, and re-installed 2.7
via the manager. Trawling along my route on F7 to the first system with rings, this happened*. After reloading the save, this happened - then this.Something to do with saving? After each save, it adds another one. <scratches head> Or is it something I've done?
*At first it was two, then three, but I have no pics.
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
And any survivors, their debts I will certainly pay. There's always a way!
- phkb
- Impressively Grand Sub-Admiral
- Posts: 4830
- Joined: Tue Jan 21, 2014 10:37 pm
- Location: Writing more OXPs, because the world needs more OXPs.
Re: [Release] System Features: Rings
No, not something you've done. The instructions I gave gsagostinho on how to add text were not clear enough (my fault). When adding text to planetary descriptions, it only needs to be done once, not with every game load. It shouldn't be how to fix though.
- Cody
- Sharp Shooter Spam Assassin
- Posts: 16081
- Joined: Sat Jul 04, 2009 9:31 pm
- Location: The Lizard's Claw
- Contact:
Re: [Release] System Features: Rings
I wonder if
This planet has a ring system
might be preferable?I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
And any survivors, their debts I will certainly pay. There's always a way!
- gsagostinho
- ---- E L I T E ----
- Posts: 573
- Joined: Sun Jul 19, 2015 1:09 pm
Re: [Release] System Features: Rings
@Cody Thanks for the report, you are good at finding bugs! Excellent
You are very kind, phkb, but the mistake is completely mine. I thought that this.startUpComplete ran only one single time when the game loaded, but I was obviously wrong. Would you have some suggestion on a better way of tackling this? Is there some other function that only runs when the game starts?phkb wrote:No, not something you've done. The instructions I gave gsagostinho on how to add text were not clear enough (my fault). When adding text to planetary descriptions, it only needs to be done once, not with every game load. It shouldn't be how to fix though.
"This planet has rings" would be better than "This system has rings", agreed, but I wouldn't use the term "ring system", it would sound confusing since we speak of star systems already.Cody wrote:I wonder ifThis planet has a ring system
might be preferable?
Re: [Release] System Features: Rings
"This planet is engaged"
- Norby
- ---- E L I T E ----
- Posts: 2577
- Joined: Mon May 20, 2013 9:53 pm
- Location: Budapest, Hungary (Mainly Agricultural Democracy, TL10)
- Contact:
Re: [Release] System Features: Rings
Try this within the function:gsagostinho wrote: ↑Sat Sep 23, 2017 12:26 pmthis.startUpComplete ran only one single time when the game loaded, but I was obviously wrong.
Code: Select all
delete this.startUpComplete;
- gsagostinho
- ---- E L I T E ----
- Posts: 573
- Joined: Sun Jul 19, 2015 1:09 pm
Re: [Release] System Features: Rings
Version 2.8 is available in the manager:
- changed description text to "This planet has rings."
- fixed a bug in which the description text appears many times (thanks Cody and Norby).
- changed description text to "This planet has rings."
- fixed a bug in which the description text appears many times (thanks Cody and Norby).
- Cody
- Sharp Shooter Spam Assassin
- Posts: 16081
- Joined: Sat Jul 04, 2009 9:31 pm
- Location: The Lizard's Claw
- Contact:
Re: [Release] System Features: Rings
After a quick test, I don't think the fix is working - could someone please check.
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
And any survivors, their debts I will certainly pay. There's always a way!
- gsagostinho
- ---- E L I T E ----
- Posts: 573
- Joined: Sun Jul 19, 2015 1:09 pm
Re: [Release] System Features: Rings
Cody, could you please tell me what steps I need to do in order to reproduce it? I can't see the bug on my side. I tried loading a save file, then loading another one from the F2 screen inside a station, then I tried quitting to the main menu and loading another save file.Cody wrote:After a quick test, I don't think the fix is working - could someone please check.
- Cody
- Sharp Shooter Spam Assassin
- Posts: 16081
- Joined: Sat Jul 04, 2009 9:31 pm
- Location: The Lizard's Claw
- Contact:
Re: [Release] System Features: Rings
Let's see if I can get this right: load game, install Rings 2.8 via manager, load commander, check F7 for next ringed planet on route - only one
This planet has rings
thingy. Go F2, quick save, go F2, reload the same commander, check F7 - now two thingies. Rinse and repeat - now three thingies.I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
And any survivors, their debts I will certainly pay. There's always a way!
- gsagostinho
- ---- E L I T E ----
- Posts: 573
- Joined: Sun Jul 19, 2015 1:09 pm
Re: [Release] System Features: Rings
@Cody You are right, I see now what is happening. Apparently the changes to the description of planets gets saved in the save file...
I think that the only solution would then be to check if the description has the sub-string "This planet has rings." at any position (since another OXP might append something to the end of the description). Or can anyone see a more elegant solution than this?
I think that the only solution would then be to check if the description has the sub-string "This planet has rings." at any position (since another OXP might append something to the end of the description). Or can anyone see a more elegant solution than this?
- Cody
- Sharp Shooter Spam Assassin
- Posts: 16081
- Joined: Sat Jul 04, 2009 9:31 pm
- Location: The Lizard's Claw
- Contact:
Re: [Release] System Features: Rings
Yeah, I thought that might be the case. In a test save-file, I have 514 thingies in thegsagostinho wrote: ↑Sat Sep 23, 2017 7:00 pmApparently the changes to the description of planets gets saved in the save file...
scripted_planetinfo_overrides
section.I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
And any survivors, their debts I will certainly pay. There's always a way!
- gsagostinho
- ---- E L I T E ----
- Posts: 573
- Joined: Sun Jul 19, 2015 1:09 pm
Re: [Release] System Features: Rings
Hmm, I am afraid that your savefile will continue to have those repeated phrases regardless of any possible fix, sorry about that If you are on Linux, there are some very simple one liners you can use on terminal to clean a savefile, but I wouldn't know how to do the same on Windows or OS X.
- Cody
- Sharp Shooter Spam Assassin
- Posts: 16081
- Joined: Sat Jul 04, 2009 9:31 pm
- Location: The Lizard's Claw
- Contact:
Re: [Release] System Features: Rings
<grins> That's why it's a 'test' save-file - disposable! Besides, I can simply rip that section out.
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
And any survivors, their debts I will certainly pay. There's always a way!