Pods OXP

[Thargoid]

Thanks - uploaded v1.32 with a fix (just a file rename for the model).

[Thargoid]

And onward up to 1.33, to deal with some rogue [%I] references which are causing a bracket-choke. Plus fixing the docs a little, as they were wrong in 1.32.

Download from the links below as normal.

[Thargoid]

And up again to v1.34, to fix a couple of expansions I missed before.

With thanks to Eric for the heads-up on both this and the previous one.

Download from the wiki or box via the links below as normal.

[Plisken]

hello!
i found out that if i scoop a bulk container sometimes it shows this message : "93 kilogramm[pod_content_kilos]". when i look in my cargobay there are no 93 kilos of gems,platinum or gold.
i'm using version 1.34 but this happened already in version1.33 of the pods.oxp.

in the script pods_bigpod_kg i found this line :
"let cargo = expandDescription('[pod_contentKilos]');" i think there is missing a "s"? :pods_contentKilos

[Thargoid]

Yes, there's a missing s there.

I'll update the OXP and fix it.

Thanks - between this and laser booster I'm going to make you my latest official Bugfinder General

Editted to add - v1.35 now uploaded with the fix. Available via wiki and box links below as normal.

[Cody]

... I'm going to make you my latest official Bugfinder General

Take care, Plisken... he'll be offering you cookies soon. Oh... welcome aboard!

[Plisken]

i loove cookies! ♥

.. I'm going to make you my latest official Bugfinder General

haha,okay (but somehow i feel a little bit scared now.. )

thanks for welcoming me aboard

[cag]

Recently installed pods and noticed this:

Code: Select all

Exception: Error: Cannot set property Textiles of instance of Manifest to invalid value NaN.
    Active script: pods_standardPod 1.33
    pods_standardPod.js, line 84:
    		manifest[type] += 1;

This is in ver.1.35.(I just DL'd to be sure) I'm running Oolite development version 1.85.0.6943-170616-7eae3c8
but was able to reproduce in 1.84
From the debug console:

Code: Select all

> :d manifest
{
    Firearms: NaN,
    Alloys: NaN,
    Textiles: NaN,
    list: [{
        unit: "t",
        displayName: "Liquor/Wines",
        commodity: "liquor_wines",
        containers: 1,
        quantity: 1
    }, {
        unit: "t",
        displayName: "Machinery",
        commodity: "machinery",
        containers: 3,
        quantity: 3
    }, {
        unit: "kg",
        displayName: "Gold",
        commodity: "gold",
        containers: 1,
        quantity: 7
    }, {
        unit: "t",
        displayName: "Alien Items",
        commodity: "alien_items",
        containers: 2,
        quantity: 2
    }]
}

I threw in a log stmt to see what was going on and this is happening when manifest[type] is undefined. I've never dealt w/ manifest before but the documentation says this should work, so I tried a fix:

Code: Select all

manifest[type] = ( manifest[type] || 0 ) + 1; 

This got rid of the error in ver.1.84 but caused the dev version to exit to Windows

Also getting

Code: Select all

Exception: Error: Cannot set property gemStones of instance of Manifest to invalid value undefined.
    Active script: vortex_player.js 1.30
    vortex_player.js, line 646:
    	manifest["gemStones"] = this.gems;
...
Exception: Error: Cannot set property gemStones of instance of Manifest to invalid value undefined.
    Active script: vortex_maelstrom.js 1.27
    vortex_maelstrom.js, line 624:
    	manifest["gemStones"] = this.gems;

It's unclear in the wiki if this should be 'gem_stones' or 'gem-stones'. But you use 'Gem-Stones' in pods_bigPod-gems.js, which in another dump seems to be the correct key:

Code: Select all

> :d manifest
{
    gold: 0,
    platinum: 0,
    Radioactives: NaN,
    Computers: NaN,
    list: [{
...
    }, {
        unit: "g",
        displayName: "Gem-Stones",
        commodity: "gem_stones",
        containers: 1,
        quantity: 16
    }, {
 ...
    }]
}

Will both displayName and commodity work? (Did I mention I've never used manifest )

[Rustem]

Hi! Recently installed pods from OXP Manager and find logging errors:

Code: Select all

Error: Cannot set property Alloys of instance of Manifest to invalid value NaN.
/ManagedAddOns/oolite.oxp.Thargoid.Pods.oxz/Scripts/pods_standardPod.js, line 84.
 

This error is appearing after you scooped the cargo canisters from this OXP. It is not added cargo to the player ship manifest (cargo space).

Suggesting upgrade this OXP:

12/09/2017 - Version 1.36 : scripting update for compatability with oolite v1.85.

- Added logging for error cargo type in pods_standardPod.js.
- Edited name of the cargo type in description.plist and script for pods_standardPod.
- Edited the scripts: correct name decsriptions, sometimes increased time for display consoleMessage. (TODO: add time bw msg)
- Edited the shipdata: for pods_emptyBarrel (and pods_UPS_emptyBarrel) decreased value role of the cargopod from 0.1(0.12) to 0.005.
- Edited the shipdata: for pods_missileBarrel decreased value role of the cargopod from 0.05 to 0.005.
- Edited the shipdata: for all standart pods decreased value role of the cargopod from 0.5 to 0.05.

// TODO: Add time interval for display consoleMessage?
// TODO: Add delay for recovery cargo type in the broken RFID of cargo pod?
// TODO: This OXP pods for the player ship only, for NPC-scooping need upgrading all the scripts.

Latest draft version: Pods 1.36

Questions, suggestions, and error reports welcome!

[NewtSoup]

You must include a "people pod" that informs the player that they have been replaced by an exact replica of themselves that points and screams at other ships that have not picked up such a pod.

[Rustem]

I found the some bugs and some ideas for this OXP. I can uploaded a fixed version 1.37 to the OXP manager?
But the license from author`s Thargoid :

this.copyright = "Creative Commons: attribution, non-commercial, sharealike with clauses - see readme.txt";

I should created a new OXP(with unique shipdata.plist entity keys and etc.) or may uploaded a fixed version 1.37 to the OXP manager?

[Rustem]

You must include a "people pod" that informs the player that they have been replaced by an exact replica of themselves that points and screams at other ships that have not picked up such a pod.

I think a pods from this OXP is pods with broken RFID (how a displayed by cargo scanner). Also may be they are hidden pods, smuggler pods, secret pods with some risk(jamming, breach, big cargo, credits). A NPC-ships is not react on the they.

[Rustem]

Latest draft version: Pods 1.38

- Fixed: replaced hasScoopMessages on the has_scoop_message in the shipdata.
- Added no has_scoop_message to: fuelPod, emptyPod, retryPod, jamPod, missilePod, explodingPod, trumblePod (and UPS version also).

[Thargoid]

I found the some bugs and some ideas for this OXP. I can uploaded a fixed version 1.37 to the OXP manager?
But the license from author`s Thargoid :

this.copyright = "Creative Commons: attribution, non-commercial, sharealike with clauses - see readme.txt";

I should created a new OXP(with unique shipdata.plist entity keys and etc.) or may uploaded a fixed version 1.37 to the OXP manager?

All of my OXPs were put into the public domain for anyone to take over ownership and support for when I retired from making and supporting them. So if you want to take over ownership and support for Pods (and no-one else already has done so) then feel free to do so.[/url]

[Rustem]

All of my OXPs were put into the public domain for anyone to take over ownership and support for when I retired from making and supporting them. So if you want to take over ownership and support for Pods (and no-one else already has done so) then feel free to do so.

Thanks, Thargoid!

Updated the page: Pods OXP