[RELEASE] SecComFinder4GalacticNavy

[Runghold]

Hi there,

I would like to present you my first OXP:
The SecComFinder (<- click to download from the wiki) for the  Galactic Navy OXP.
If both, the Galactic Navy OXP and the SecComFinder are installed, systems with  Navy SecCom Stations are marked in the ingame galaxy chart.
After uninstalling Galactic Navy OXP, leave SecComFinder installed to let it remove the makers it made. Load and save your game state once after that and you can uninstall SecComFinder too.

Why did i create this OXP:
Many weeks ago i installed "Galactic Navy OXP". Too bad the only way i knew to find out where the next SecCom Station is were  those maps: Looking in the browser and going back to Oolite made me think "There must be a way to mark the systems where SecCom stations are located. I just got to find out how." So, about one month ago i found out, learning (about) javascript the hard way: Look at other OXP scripts and try similar. With a lots of "try and error". Almost three weeks ago, after 20 to 30 hours, scattered over four to six days, scattered over three weeks i "finished" the oxp. "Finishing" means it works as intended without creating errors in the logfile. The last three weeks i "tested" (more than necessary) the OXP intensely. Today, i finally bestired myself to create the wiki entry and this thread to help you to pull your duty in the Galactiv Navy.

[Runghold]

Some things to discuss for possible future versions:

• In the script, this marker is used:
  markerColor: "cyanColor", markerScale: 1.5, markerShape: "MARKER_DIAMOND"
  what marker could be better and why?
• In manifest.plist, these categories are specified:
  "category" = "Activities";
  "category" = "Misc";
  "category" = "Missions";
  "category" = "Systems";
  The bad thing is:
  If an OXZ has several categories specified, it may be listed in the managed addons list under one or another category - dependant if is installed yet. I discovered this when i installed all on my PC installed managed addons on my notebook.
  Which category is the most appropriate and why?
• In manifest.plist/requires.plist:
  "required_oolite_version" = "1.79";
  The script shouldn't run in a version less than Oolite 1.79, but does it run from 1.79 up?
• How could the code be changed to work more efficiently?

[phkb]

If an OXZ has several categories specified, it may be listed in the managed addons list under one or another category

I think you can only have one category assigned to an OXP, the others should go in "tags".

Which category is the most appropriate and why?

I'd suggest Misc or Ambience.

How could the code be changed to work more efficiently?

You could have a look at how I accomplished something similar with the  Galactic Registry OXP

[Runghold]

You could have a look at how I accomplished something similar with the  Galactic Registry OXP

Quote from that wiki page:

...
This will highlight each system that is home to a GalNavy sector command
...

Well... i guess if i knew about Galactic Registry OXP before i wouldn't have created SecComFinder since its only feature is already included in Galactic Registry.

[phkb]

Sorry! But just because I have a similar feature in GalCop Galactic Registry, doesn't mean your version is obsolete. You're putting the markers up permanently, so they will be visible on every chart screen (including any mission screens that use a chart). For users of the GalNavy OXP this might be preferable. That's different to the Gal Registry, which only shows them while you're on the Gal Registry screen.

It's a big Ooniverse out there - variations of OXP implementations is OK.

[hoqllnq]

I use this OXP. It would be nice to add RRS stations to this. [Edit: RRS, not RSS..]

The list of systems with RRS Galactic Headquarters is  published, but as far as I know, there is no public list/map of Waystations.
So publishing those might be considered a spoiler. But then again, anyone who would think that is free to not install it.. Also, there are way more waystations than SecCom stations, so it might make the map look cluttered.
Anyway, just an idea.



Edit to add:

So no longer just an idea. I looked at your script in your OXP and at the script in the RRS OXP,
and pretty much just replicated what you do, with the help of some functions in the RRS script.
I added the following snippet to your FuncGalaxyCheck() function:

Code: Select all

var rrs = worldScripts["Rescue Stations"];
if (rrs)
{
	for (var s = 0;s < 256;s++)
	{
		if (rrs.systemHasRescueStation(s))
		{
			mission.markSystem(
				{system:  s, name: "RungholdRRS_WS_g" + galaxyNumber + "s" + s, markerColor: "blueColor", markerScale: 1.25, markerShape: "MARKER_DIAMOND"}
							   );
		}
		if (rrs.systemHasRescueHQStation(s))
		{
			mission.markSystem(
				{system:  s, name: "RungholdRRS_HQ_g" + galaxyNumber + "s" + s, markerColor: "blueColor", markerScale: 1.25, markerShape: "MARKER_SQUARE"}
							   );
		}
	}
}

It appears to work as intended, and yes, it does make the map look somewhat cluttered:



The one near the center with the diamond and the square, making an 8 point star, has both a waystation and the galactic HQ.

[Runghold]

I am pleased to read that someone besides me is using my OXP.

At the moment that annoying real life is keeping me from scripting so i will - if at all - just try to optimize the code if i find the time. But i like the idea of including the ability to set markers for other OXPs too. Maybe in the future i will mess with it.


regards

Runghold

[Cholmondely]

Hi there,

Runghold,

If you see this - I'm planning on posting the Galactic Navy to the in-game Expansions Manager.

I'll be adding the various GN-related OXPs and plan on adding yours and renaming it to Galactic Navy Addition: SecCom Finder (to stop it getting lost in the morass of 750+ oxz's) as well as including it as a download with the new Galactic Navy meta-OXP.

This will involved tweaking the manifest.plist. I don't intend to change any of your programming.

Please let me know if you have any issues with any of this!

Cholmondely