Liners OXP

[QCS]

Hi,

I just found the following in my log...

21:49:16.995 [shader.compile.failure]: ***** ERROR: GLSL vertex shader compilation failed for liners_tigershark.vertex:
>>>>> GLSL log:
0:0(9): preprocessor error: Redefinition of macro OO_TANGENT_ATTR



21:49:16.995 [shader.load.failed]: ***** ERROR: Could not build shader liners_tigershark.vertex/liners_tigershark.fragment.

[pagroove]

Hi QCS. Yes this OXP has shader problems in the newest builds. I have not time at the moment to look into the problem at this moment as I'm busy with other projects (on this moment a project in another game to: Trainz).

But I notice too that the Tigershark and also the Aurora show weird textures. Probably that is because of that the liners use some older shader code from pre 1.80 (I think).

[Smivs]

Update release v1.6 14th March 2017

This new version of 'Liners' has several updates to the code to optimise it for current Oolite versions, and eliminate some log errors. One minor ship has been added, one of the escorts has been replaced and several of the textures have been improved. The ships now have ship library definitions.

It is available via the Expansions Manager.
The previous version v1.51 is also still listed as this was previously Thargoid's responsibility. I have PM'd him so hopefully he will de-activate it soon.

cim has removed the old version from the manager now.
Thanks cim.

Changelog:-

shipdata.plist revised to remove log errors regarding old-style sub-entity definitions. Thanks to PHKB for these.

Scripts now all have 'Use strict' and appear to be error-free.

Tigershark vertex shader code fixed. Thanks to A_C for this.

shiplibrary.plist added and descriptions.plist expanded (to allow ships to appear in the start-up library).

The 'Saga Class' liners, and inter-system ferrys have improved normal mapping.

The escorts for the 'Saga Class' liners have been upgraded from Adder to Sidewinder-X.

A new Lifeboat has been added.

[cbr]

Great! one of my all time favourites oxp/oxz.

[phkb]

A small error in liners_tigershark.vertex. First line of the file reads

Code: Select all

 gives correct tangent data to shader.

I think this should be

Code: Select all

// gives correct tangent data to shader.

[Smivs]

Bugger, I thought I'd sorted that.
<Smivs goes off to see what's happened.........>
Ah, my fix for the shader needed fixing! Following advice here I deleted the offending line, but didn't realise that the following line needed commenting out.
All fixed now - v1.6.1 is up on the Manager.
Thanks for the report phkb.

[phkb]

I'm really sorry, but I found another one...

In the "liners_drone.js" file, you need to move the isHostile function to be at the top of the function it sits in. ie

Code: Select all

this.findMastersHostiles = function()
	{
	function isHostile(entity) 
		{ 
		return (entity.isShip && entity.target && (entity.target == this.ship.owner || entity.target == this.ship) && entity.hasHostileTarget);
		}
	if(!this.ship.owner)
	...snip...

Otherwise you get errors like this:

Code: Select all

09:16:04.626 [script.javaScript.load.failed]: ***** Error loading JavaScript script c:\Oolite-Trunk/oolite.app/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.smivs.Liners.oxz/Scripts/liners_drone.js -- compilation failed
09:16:06.907 [script.javaScript.exception.strictFunctionStatement]: ***** JavaScript exception (bigShips_populator 1.0.2): SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function
09:16:06.907 [script.javaScript.exception.strictFunctionStatement]:       c:\Oolite-Trunk/oolite.app/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.smivs.Liners.oxz/Scripts/liners_drone.js, line 17: 		function isHostile(entity) 

[Smivs]

No, don't be sorry - I'm grateful.
I took this on recently from Thargoid and have never really poked around in the parts I haven't had a hand in, so in an attempt to get rid of log errors I set all the scripts to 'Use_strict' as those warnings were spamming the log. I ran the game a few times and the log was clear so I assumed everything was OK. It's possible there may be other problems lurking, so I'll hold off another update for a while just in case.

[pagroove]

Thank you for updating the package Smivs . Do you think the Orisis oxp could be rolled in into Liners as well. Because it is also a ferry? Edited to add. Then we can control the distribution of the liners a bit better.

[Smivs]

Yes, I think we might have discussed this before, a long time ago. It certainly looks a good fit, so I'll try to have a look at this soon. Would you keep the stand-alone OXP available, or have Orisis only available in Liners?
The more ships in the package the better really, because as you suggest it makes the appearance of each type less common, which is a good thing. That is one reason I added the other Ferrys a while back. While going through my files I did find another capital ship sent to us by a long-lapsed member, which got me all excited, but it turns out it was a model lifted from a website and although it was stated as being free to use I could find no licence etc, so it is no use to us.
If anybody else has a Liner or similar and would like it included in Liners, let me know.

[pagroove]

Yes, I think we might have discussed this before, a long time ago. It certainly looks a good fit, so I'll try to have a look at this soon. Would you keep the stand-alone OXP available, or have Orisis only available in Liners?
The more ships in the package the better really, because as you suggest it makes the appearance of each type less common, which is a good thing. That is one reason I added the other Ferrys a while back. While going through my files I did find another capital ship sent to us by a long-lapsed member, which got me all excited, but it turns out it was a model lifted from a website and although it was stated as being free to use I could find no licence etc, so it is no use to us.
If anybody else has a Liner or similar and would like it included in Liners, let me know.

I want to roll the Orisis into Liners and then only support a Legacy Orisis version for people who want the standalone. But the goal is to make one package indeed.

[Diziet Sma]

If anybody else has a Liner or similar and would like it included in Liners, let me know.

As Head Janitor for D.T.T. Shipbuilders, I'd like to request that the D.T.T. Galaxy Liner be included in Liners.

[Smivs]

I'll start work on incorporating the Orisis in a few days time (half-way through another project at the moment) and then release an update with phkb's scripting fix as well. A wait of a week or so will also give any other errors a chance to show up as well.
@ Diz, I'm in two minds about the DTT Galaxy Liner. It is quite small, isn't it? And this is supposed to be about BIG ships. At 145m it is actually smaller than the existing ferries and in fact is hardly bigger than the escort ships used by the Saga Class liners. Also, if it were to become a liner/ferry in this pack then I don't think it should be player-buyable.
It is a lovely design though (and it still reminds me of something I've forgotten!) so I will give this some further thought.

[Diziet Sma]

@ Diz, I'm in two minds about the DTT Galaxy Liner. It is quite small, isn't it? And this is supposed to be about BIG ships. At 145m it is actually smaller than the existing ferries and in fact is hardly bigger than the escort ships used by the Saga Class liners. Also, if it were to become a liner/ferry in this pack then I don't think it should be player-buyable.
It is a lovely design though (and it still reminds me of something I've forgotten!) so I will give this some further thought.

Given that it's the only Liner that can actually dock in a Station, yes, it is on the small side.. but I'd argue there's a market for smaller, highly exclusive Liners as well.. after all, the dynastic, truly obscenely wealthy don't like to rub shoulders with the nouveau riche, or even go to the same holiday locations.. (I could tell you a story about that, as told to me by a friend whose family falls into that 'dynastic wealth' category) let alone be forced to mingle with thousands of them on some over-sized, glittering, ostentatious barge. They don't like drawing attention to themselves.

I don't see being player-buyable necessarily being an obstacle either.. why shouldn't a Commander buy one, pack it full of Passenger Berths, and try to run his own Cruise Line?

However, whatever you decide on is fine.. just didn't want such a lovely ship overlooked.

[Smivs]

As I said, I do like it, so......
A Yacht! One of those mega-buck super-yachts the rich and famous own. You described this without giving it a name so what if it not a (small) ferry or (giant) Liner, but a yacht for those who don't have to use either.
Player-buyable would make sense, as would a price tag of around Cr.24,000,000.