Trunk nightly

[Cody]

Easy Start selected:

Code: Select all

11:33:30.396 [setCommanderDataFromDictionary.warning.cargo]: Cargo testcommodity (0 units) could not be loaded from the saved game, as it is no longer defined
11:33:30.649 [load.warning.cargo]: Station market good testcommodity (8 units) could not be loaded from the saved game, as it is no longer defined
11:33:32.172 [load.warning.cargo]: Station market good testcommodity (0 units) could not be loaded from the saved game, as it is no longer defined

[another_commander]

Me = silly
Fixed for tonight.

[Cody]

<nods> As for feedback: too easy!

[Day]

Hello everybody,

when compiling the current trunk version (last commit being 15eb90fd792fffb4c6edbb3bbea5c1b75da2979b) in debug mode, launching it with installed oxz oolite.oxp.redspear.equipment_by_ship_class.oxz (only one installed) and starting a new game, the game segfaults.

If compiled in release mode instead, it doesn't segfault.

No idea why, but I suppose an oxp shouldn't be able to segfault the main game, even in debug mode.

Linux environment.

What do you think?

Edit: no other oxz makes the game segfault.
Edit2 : it's the first time I installed this oxz, so I don't know if this behaviour is recent.

[another_commander]

This is issue #204 and I can confirm that it is still the case both in debug and release builds.

Latest.log contains these lines:

Code: Select all

22:58:06.596 [exception]: ***** Exception checking controls [pollDemoControls]: NSInvalidArgumentException : GSCInlineString(instance) does not recognize identifier
22:58:06.596 [general.error.inconsistentState]: ***** ERROR: status is STATUS_START_GAME, but dockedStation is nil; treating as not docked. This is an internal error, please report it.

Current backtrace is similar to the one seen in the discussion of issue #204:

Program received signal SIGSEGV, Segmentation fault.
0x678499fe in objc_msg_lookup (receiver=0xa518aa8, op=0x6f24f0)
at sendmsg.c:224
224 result = sarray_get_safe (receiver->class_pointer->dtable,
(gdb) bt
#0 0x678499fe in objc_msg_lookup (receiver=0xa518aa8, op=0x6f24f0)
at sendmsg.c:224
#1 0x004a8da6 in -[ShipEntity hasOneEquipmentItem:includeMissiles:whileLoading:] (self=0x3449990, _cmd=0x6f24d8, itemKey=0x3db0448,
includeMissiles=1 '\001', loading=0 '\000')
at src/Core/Entities/ShipEntity.m:3047
#2 0x004e1f98 in -[ShipEntity hasOneEquipmentItem:includeWeapons:whileLoading:] (self=0x3449990, _cmd=0x6f2500, itemKey=0x3db0448, includeWeapons=1 '\001',
loading=0 '\000') at src/Core/Entities/ShipEntity.m:3009
#3 0x004c5bb4 in -[ShipEntity hasEquipmentItem:includeWeapons:whileLoading:]
(self=self@entry=0x3449990, _cmd=_cmd@entry=0x6f2508,
equipmentKeys=0xa51a828, includeWeapons=includeWeapons@entry=1 '\001',
loading=loading@entry=0 '\000') at src/Core/Entities/ShipEntity.m:3106
#4 0x004ddffc in -[ShipEntity equipmentValidToAdd:whileLoading:inContext:] (
self=0x3449990, _cmd=0x6f25a0, equipmentKey=0x6f352c, loading=0 '\000',
context=0x6f3514) at src/Core/Entities/ShipEntity.m:3416
#5 0x004a917d in -[ShipEntity equipmentValidToAdd:inContext:] (
self=0x3449990, _cmd=0x6f2550, equipmentKey=0x6f352c, context=0x6f3514)
at src/Core/Entities/ShipEntity.m:3382
#6 0x004b2d65 in -[ShipEntity canAddEquipment:inContext:] (self=0x3449990,
_cmd=0x6ce658, equipmentKey=0x6f352c, context=0x6f3514)
at src/Core/Entities/ShipEntity.m:3226
#7 0x004361ce in -[PlayerEntity canAddEquipment:inContext:] (self=0x3449990,
_cmd=0x6f2698, equipmentKey=0x6f352c, context=0x6f3514)
at src/Core/Entities/PlayerEntity.m:11118
#8 0x004bcf5a in -[ShipEntity addEquipmentItem:withValidation:inContext:] (
self=0x3449990, _cmd=0x6cdf90, equipmentKey=0x6f352c,
validateAddition=1 '\001', context=0x6f3514)
at src/Core/Entities/ShipEntity.m:3533
#9 0x0043d69b in -[PlayerEntity addEquipmentItem:withValidation:inContext:] (
self=0x3449990, _cmd=0x6cdf90, equipmentKey=0x6f352c,
validateAddition=1 '\001', context=0x6f3514)
at src/Core/Entities/PlayerEntity.m:11153
#10 0x004256cd in -[PlayerEntity addEquipmentItem:inContext:] (
self=0x3449990, _cmd=0x6f1b00, equipmentKey=0x6f352c, context=0x6f3514)
at src/Core/Entities/PlayerEntity.m:11129
#11 0x004e088a in -[ShipEntity setUpFromDictionary:] (self=0x3449990,
_cmd=0x6cd508, shipDict=0x3e9fef8) at src/Core/Entities/ShipEntity.m:331
#12 0x00434be4 in -[PlayerEntity setUpShipFromDictionary:] (
self=self@entry=0x3449990, _cmd=_cmd@entry=0x7aefa0, shipDict=0x3e9fef8)
at src/Core/Entities/PlayerEntity.m:2207
#13 0x00688704 in -[Universe setUpInitialUniverse] (self=0x42c1820,
_cmd=0x7adcb8) at src/Core/Universe.m:9911
#14 0x006955b6 in -[Universe reinitAndShowDemo:] (self=0x42c1820,
_cmd=0x7add20, showDemo=0 '\000') at src/Core/Universe.m:9853
#15 0x00496a4d in -[PlayerEntity(LoadSave) loadPlayerFromFile:asNew:] (
self=0x3449990, _cmd=0x6e8318, fileToOpen=0x3562c08, asNew=1 '\001')
at src/Core/Entities/PlayerEntityLoadSave.m:646
#16 0x00495202 in -[PlayerEntity(LoadSave) startScenario] (self=0x3449990,
_cmd=0x6df4f0) at src/Core/Entities/PlayerEntityLoadSave.m:345
#17 0x00472da3 in -[PlayerEntity(OOControlsPrivate) pollDemoControls:] (
self=0x3449990, _cmd=0x6de9b0, delta_t=0.017000019550323486)
at src/Core/Entities/PlayerEntityControls.m:4352
#18 0x0046fb83 in -[PlayerEntity(Controls) pollControls:] (self=0x3449990,
_cmd=0x6cd5f8, delta_t=0.017000019550323486)
at src/Core/Entities/PlayerEntityControls.m:389
#19 0x0043e216 in -[PlayerEntity update:] (self=0x3449990, _cmd=0x7aeb38,
delta_t=0.017000019550323486) at src/Core/Entities/PlayerEntity.m:2554
#20 0x006a7a38 in -[Universe update:] (self=0x42c1820, _cmd=0x79b9d0,
inDeltaT=0.017000019550323486) at src/Core/Universe.m:6629
#21 0x0065ebc0 in -[GameController doPerformGameTick] (self=0x42c80d0,
_cmd=0x79b9c8) at src/Core/GameController.m:350
#22 0x0065da53 in -[GameController performGameTick:] (self=0x42c80d0,
_cmd=0x79ba00, sender=0xb4a6340) at src/Core/GameController.m:328
#23 0x6494637e in gnustep-base-1_20!GSUnregisterCurrentThread ()
from c:\DriveD\OoliteProject\oogit\ooliteReadOnly\oolite\oolite.app\gnustep-base-1_20.dll
#24 0x0079ba00 in _OBJC_SELECTOR_TABLE ()
#25 0x0b4a6340 in ?? ()
#26 0x00000000 in ?? ()
(gdb)

[Day]

Sorry, I didn't check the known issues
Should I test on the branch with the suggested fix, or is there currently enough input for this bug?

[another_commander]

Feel free to test the suggested fix; I think it works, but I have not got it entirely clear yet why. I feel we may be still missing something.

[Smivs]

Apologies if this has been mentioned before. Getting hundreds of these in the log at the moment.

Code: Select all

16:37:13.439 [texture.load.png.warning]: ----- A PNG loading warning occurred for /home/smivs/GNUstep/Applications/Oolite-trunk/oolite.app/Resources/Textures/oolite_asteroid_diffuse.png: Ignoring bad adaptive filter type.

Latest trunk I think:- 1.85.0.6897.170218-15eb90f

[another_commander]

Smivs, when did those start coming up? We have not changed any pngs or any png handling code for a very long time. Has there been an update of libpng in your system?

Still, it's quite strange because Oolite downloaded from the nightly build server should be using its own version of libpng and not that of the system. One thing you may want to check is whether 1.84 shows the same type of warnings or not. The other thing is try to pinpoint the first 1.85 build showing the problem if you can.

[Smivs]

I updated to this version on Monday, and it was the first time I've updated Trunk for possibly a year as I've not been too active game-wise for a while. It replaced a v1.83.xxx so that's not going to help pin down anything I'm afraid.
I do vaguely remember what might have been a libpng update coming through recently - Mint 17.1 - but can't be sure. Current versions listed in Synaptic are libpng12-0:i386 and libpng12-0.

[Getafix]

@Smivs
Considering that you updated from Trunk, oolite-trunk is looking for Oolite's own libpng that is libpng14.so.14.
To confirm that, please, execute the following in a command shell:
(replace <Oolite-trunk home folder> as per your Oolite-trunk installation)

Code: Select all

$ ldd <Oolite-trunk home folder>/oolite.app/oolite | grep libpng

Please, post the output here, including the ldd line.

[Smivs]

Thanks Getafix. I'm getting this

Code: Select all

libpng14.so.14 => not found

That's the only output. Looks like it might be helpful, sort of.

[Getafix]

Although you did not share the ldd command line
(that would have given me your Oolite Trunk home folder,
and then I would have the opportunity to ask you to crosscheck that you are actually executing the correct oolite-trunk ),
this is the correct and expected behavior.

This proves that your Oolite for Trunk is linked to libpng14.so.14.
Your system cannot find this library (and this is how we want it to be), because it is not in the usual system library paths.
It is in the Oolite installation path and will be made visible to oolite-trunk upon its execution.

Conclusion
We now know that the issue you observe, is not due to your system's libpng being updated or not.
That was just my one penny worth here.

[Smivs]

Although you did not share the ldd command line
(that would have given me your Oolite Trunk home folder,
and then I would have the opportunity to ask you to crosscheck that you are actually executing the correct oolite-trunk ),
this is the correct and expected behavior.

Ah, sorry. This is the path

Code: Select all

ldd GNUstep/Applications/Oolite-trunk/oolite.app/oolite | grep libpng

and is the only Trunk I have (I think).

However I do also seem to have Oolite (v1.84) in GNUstep/Applications, but it doesn't appear in the 'Games' menu and I can find no way to launch it! What on Earth have I done?!

[Cody]

I can find no way to launch it! What on Earth have I done?!

<sniggers>