[RELEASE] Hyperspace Hangar OXP

[phkb]

There appears to be a bug when you swap your current ship for one in storage. It seems to be wiping out all your credits!

I think the issue is in the "hyperhanger.js" file, line 172. Commenting out the player.credits = this._playerCredit - price; line seems to sort the issue out.

[Ramen]

Thanks, I will fix this.

[Ramen]

VERSION 1.14.7 IS OUT AFTER TOO LONG!

Changes include:
- A bugfix for credits being wiped under certain circumstances

You can get it here or from the oxp manager.

[Cmdr. Aiden Henessy]

Just thought I'd put it out there, I recently discovered an OXP incompatibility. If you have Ship Comparisons installed, it will override the "store ship" menu for the Hyperspace Hanger OXP.

[phkb]

If you have Ship Comparisons installed, it will override the "store ship" menu for the Hyperspace Hanger OXP.

ShipComparison doesn't do anything with the current player ship, or with the menus in HH, so I'd be very surprised if it was the cause of the conflict. But I'll check out the combination and get back to you.

[Cmdr. Aiden Henessy]

ShipComparison doesn't do anything with the current player ship, or with the menus in HH, so I'd be very surprised if it was the cause of the conflict. But I'll check out the combination and get back to you.

Well what happened was that when I'd buy a ship, a screen would pop up detailing all the schematics of the ship, all the attached gear, etc, then ask if I wanted to confirm. There was never any option afterwords that asked if I wanted to store my old ship in the hanger, which is what the Hyperspace Hanger is supposed to do. After I removed the Comparisons mod, though, the Hanger functioned as normal and asked me if I wanted to store or re-sell my old ship.

[phkb]

My first quick test allowed me to buy a new ship and store the old one. I could then swap between them quite happily. This was with both OXP's installed, and other even more invasive ones (like Ship Configuration). Can you post a list of all the OXP's you're running? The "latest.log" file should have them in it.

Edit to add: A copy of your save game would also be helpful if you can post it somewhere. If you don't have anywhere to post them send me a PM and we'll work something out.

[phkb]

I'm looking through HH code now and I did find a bug, although I doubt it has anything to do with your issue. A variable is initialised as "this._shipPercent", but in a couple of spots is used as "this.shipPercent" (ie without the underscore). Anyway, I'll continue looking.

[phkb]

Found another really small bug, but again, nothing to do with your issue. Once you store a ship, if you go through the process of switching to or selling your stored ship, the ship model will be displayed while you're asked to confirm the choice. But the entityPersonality used for the model display is different to the actual stored ship (because no personality value is actually being set). For some ships this will make no difference at all. But some ships use the entityPersonality to change the colour of the ship. This results in a confirmation display that is slightly disconcerting -- "That's not my ship!". If you choose to go ahead with the swap you will end up with the correct entityPersonality, so, as I said, this is really minor. Nit-pick, really.

[Cmdr. Aiden Henessy]

My first quick test allowed me to buy a new ship and store the old one. I could then swap between them quite happily. This was with both OXP's installed, and other even more invasive ones (like Ship Configuration). Can you post a list of all the OXP's you're running? The "latest.log" file should have them in it.

Edit to add: A copy of your save game would also be helpful if you can post it somewhere. If you don't have anywhere to post them send me a PM and we'll work something out.

Hmm... okay. That's a big list. Now I must publicly reveal how messy I am with OXP installation!... I know for a fact I probably have conflicting OXPs or ones that do the same thing (I think I have like three variations of a bounty scanner...) but my life is such that I rarely get a chance to use internet to download things, so when I do, I grab as much as I can and sort it out later. Problem is, there never is a "later."

I got rid of all the "fluff" pertaining to finding it. They're all installed through the OXP manager, except for like five down at the bottom. It may be worth noting that Hangers is manually installed.

Also, for my save game, this was probably two or three days ago, and I've been on it a lot since then. I'm not sure how long it goes back and saves everything? I can PM you about it, though, if it would be helpful.

DTT.Atlas 1.1.Paradox.oxz
DTT.Cyclops 1.0.Paradox.oxz
DTT.Galaxy_Liner 1.0.Paradox.oxz
DTT.Heart_of_Gold 1.0.Paradox.oxz
DTT.Kraken.Paradox.oxz
DTT.Manta.Paradox.oxz
DTT.MK-1 1.0.Paradox.oxz
DTT.Planet_Express 1.1.Paradox.oxz
DTT.Snake Charmer Pinup 1.1.Paradox.oxz
DTT.Space Zeppelin 1.0.Paradox.oxz
DTT.Tomahawk.Paradox.oxz
DTT.War_Lance.Paradox.oxz
DTT.Wraith.Paradox.oxz
.ace..Cruzer.oxz
ace..Hornet.oxz
ace..NightAdder.oxz
amah.noshaders_Mimoriarty_rl_ships.oxz
amah.noshaders_Mimoriarty_rl_yasenturret_upgrade.oxz
AndreyBelov.BountyInformer.oxz
.AndreyBelov.Targeter.oxz
ArexackHeretic.att1.oxz
.ArexackHeretic.CargoWreck.oxz
ArexackHeretic.ThargornThreat.oxz
BeeTLeBeTHLeHeM.LifeInTheFrontier.oxz
captain_beatnik.coluber_hud_ch01.oxz
captain_beatnik.Pitviper2.oxz
captkev.fighter_hud2.oxz
CaptMurphy.BreakableEnergyUnit.oxz
CaptMurphy.BreakableEngines.oxz
CaptMurphy.BreakableHUDIFFScanner.oxz
CaptMurphy.BreakableShieldGenerators.oxz
CaptMurphy.BreakableTorusDrive.oxz
CaptMurphy.BreakableWitchDrive.oxz
CaptMurphy.EscortContracts.oxz
CaptMurphy.ExplorersClub.oxz
CaptMurphy.ShipStorageHelper.oxz
CaptSolo.Cobra_Mk3-XT.oxz
captsolo.copperhead21.1.oxz
captsolo.cougar_st1.5.oxz
captsolo.solos-good-fortune.oxz
captsolo.tori2.02.oxz
capt_murphy.Illegal_Goods_Tweak.oxz
cim.camera-drones.oxz
cim.combat-simulator.oxz
cim.comms-pack-a.oxz
cim.energy-bomb.oxz
cim.escort-formations.oxz
cim.extracts-tre-clan.oxz
cim.ships-library.oxz
cim.skilled-npcs.oxz
cim.systemfeatures.rings.oxz
cim.systemfeatures.sunspots.oxz
ClymAngus.Kirin.oxz
ClymAngus.KirinSport.oxz
ClymAngus.NeoCaduceus.oxz
cody.green-gecko-xl.oxz
Commander_McLane.Anarchies.oxz
Commander_McLane.Display_reputation.oxz
Commander_McLane.Randomshipnames.oxz
Commander_McLane.Total_patrol.oxz
CommonSenseOTB.CustomShields.oxz
CommonSenseOTB.SniperLock.oxz
Diagoras.MiningContracts.oxz
Disembodied.FreeTradeZone.oxz
Diziet.hyperradioCATACLYSM.oxz
Draco_Caeles.GenerationShips.oxz
DrNil.Commies.oxz
DrTripsa.InSystemTrader.oxz
.EricWalch.DeepSpaceDredger.oxz
EricWalch.DeepSpacePirates.oxz
EricWalch.PirateCove.oxz
Frame.FuelCollector.oxz
Griff.Bug_(Elite2).oxz
.Griff.Gnat_(Elite2).oxz
Griff.Griffin1_(Elite2).oxz
Griff.Griff_shipset_decals.oxz
Griff.Hognose.oxz
.Griff.Ophidian_(EliteA).oxz
.Griff.Prototype_Boa.oxz
.Griff.Station_Bundle.oxz
.Griff.Viper_Interceptor_exp.oxz
.Griff.Wolf_Mk_II.oxz
.jh145.ScannerAlertingEnhancement.oxz
.Knotty.mvm_veloceeappuntita.oxz
.Knotty.RealisticStars.oxz
.Layne.DockingFees.oxz
.LittleBear.AsteroidStorm.oxz
.littlebear.blackmonks.oxz
.Lone_Wolf.ETTHomingBeacon.oxz
.Murgh.HoOpyCasino.oxz
.Murgh.MilitaryFiasco.oxz
.Murgh.NuVipers.oxz
.Neelix.WaypointHere.oxz
.Norby.Andromeda.oxz
.Norby.Carriers.oxz
.Norby.Carriers_with_turrets.oxz
.Norby.CombatMFD.oxz
.Norby.Eco_Lasers.oxz
.Norby.Engine_Sound.oxz
.Norby.EscortDeck.oxz
.Norby.EscortPack.oxz
.Norby.Fighters.oxz
.Norby.Gallery.oxz
.Norby.Gatling_Laser.oxz
.Norby.HardShips.oxz
.Norby.Headlights.oxz
.Norby.HUDSelector.oxz
.Norby.ILS.oxz
.Norby.LaserCannons.oxz
.Norby.LogEvents.oxz
.Norby.MinerCobra.oxz
.Norby.Multiple_Lasers.oxz
.Norby.Planetfall_Markets.oxz
.Norby.ReverseControl.oxz
.Norby.SafetyCatch.oxz
.Norby.SellAll.oxz
.Norby.Separated_Lasers.oxz
.Norby.Sniper_Gun.oxz
.Norby.Superhub_for_Extra_Planets.oxz
.Norby.TorusToSun.oxz
.Norby.Trails.oxz
.Norby.VariableMasslock.oxz
.Okti.CargoScanner.oxz
.Pagroove.FamousPlanets.oxz
.Pagroove.Superhub.oxz
.phkb.AutoDock.oxz
.phkb.BountySystem.oxz
.phkb.BroadcastCommsMFD.oxz
.phkb.CommsLogMFD.oxz
.phkb.DamageReportMFD.oxz
.phkb.DeathComms.oxz
.phkb.EmailSystem.oxz
.phkb.FastTargetSelector.oxz
.phkb.IllicitUnlock.oxz
.phkb.LMSS.oxz
.phkb.ModernStart.oxz
.phkb.ShipRespray.oxz
.phkb.Smugglers_TGU.oxz
.Ramen.Status_Quo-Ship's_Library.oxz
.Ramirez.BlOombergMarkets.oxz
.Ramirez.Dictators.oxz
.Ramirez.ExecutiveSpaceWays.oxz
.Ramirez.FeudalStates.oxz
.Ramirez.MissilesandBombs.oxz
.Ramirez.ResistanceCommander.oxz
.Ramirez.SalezaAeronautics.oxz
.redspear.additional_planets_sr_demux_alien_pack.oxz
.redspear.additional_planets_sr_demux_earthlike_pack.oxz
.redspear.additional_planets_sr_demux_ocean_pack.oxz
.redspear.additional_planets_sr_demux_volcanic.oxz
.redspear.additional_planets_sr_others_gas_giants.oxz
.redspear.free_bitmaps_dusty.oxz
.redspear.free_bitmaps_icy.oxz
.redspear.free_bitmaps_rocky.oxz
.redspear.hyperdrives.oxz
.redspear.new_lasers.oxz
.rorschachhamster.Dragonships.oxz
.sdrubble.Dark_Rainbow.oxz
.SMax.AsteroidRandomizer.oxz
.smivs.aliens.oxz
.smivs.better Buoys.oxz
.smivs.Clippers.oxz
.smivs.CombatHUD_v3.0.oxz
.smivs.contractor.oxz
.smivs.Delightful Docking.oxz
.smivs.ExtraFuelTanks.oxz
.smivs.SmartHUD.oxz
.smivs.Star-jelly.oxz
.smivs.teretrurus.oxz
.smivs.yellooCabs.oxz
.spara.additional_planets_sr_base.oxz
.spara.additional_planets_sr_pack_redux.oxz
.spara.asteroid-tweaks.oxz
.spara.audible_docking_clearance.oxz
.spara.behemoth.oxz
.spara.in-system_taxi.oxz
.spara.manifest_mfd.oxz
.spara.market_cooldown.oxz
.spara.market_observer.oxz
.spara.navigation_mfd.oxz
.spara.random_hits.oxz
.spara.random_hits_shipset.oxz
.spara.random_player-ship_name.oxz
.spara.rescue_stations.oxz
.spara.sb-faves.oxz
.spara.spicy_hermits.oxz
.spara.start_choices.oxz
.spara.stations_for_extra_planets.oxz
.spara.station_ads.oxz
.spara.trophy_collector.oxz
.spud42.Eagle_Transporter.oxz
.Staer9.Icesteroids.oxz
.staer9.staer9_shipset.oxz
.staer9.StarDestroyer.oxz
.stormrider.Darkside_Moonshine_Distillery.oxz
.stormrider.manifestScanner.oxz
.Stormrider.Stormbrewer.oxz
.Strato1.MoreEscapePods.oxz
.Svengali.BGS.oxz
.Svengali.CCL.oxz
.Svengali.Eric.BuoyRepair.oxz
.Svengali.Hyperradio.oxz
.Svengali.HyperradioAFC01.oxz
.Svengali.HyperradioHH01.oxz
.Svengali.HyperradioJFRG01.oxz
.Svengali.HyperradioPSY01.oxz
.Svengali.HyperradioTN01.oxz
.Svengali.OXPConfig.oxz
.Svengali.Pagroove.BGSSoundset.oxz
.Svengali.Snoopers.oxz
.Switeck.Auto-ECM.oxz
.Switeck.Cargo-Contract-Mod.oxz
.Thargoid.APRIL.oxz
.Thargoid.Aquatics.oxz
.Thargoid.Armoury.oxz
.Thargoid.Bigships.oxz
.Thargoid.CargoShepherd.oxz
.Thargoid.CargoSpotter.oxz
.Thargoid.CommandersLog.oxz
.Thargoid.FlightLog.oxz
.Thargoid.FuelStation.oxz
.Thargoid.Gates.oxz
.Thargoid.HiredGuns.oxz
.Thargoid.LaveAcademy.oxz
.Thargoid.Liners.oxz
.Thargoid.NavalGrid.oxz
.Thargoid.Neo-Docklights.oxz
.Thargoid.OoCheat.oxz
.Thargoid.PlanetaryCompass.oxz
.Thargoid.PlanetaryCompassPackA.oxz
.Thargoid.PlanetaryCompassPackB.oxz
.Thargoid.PlanetaryCompassPackC.oxz
.Thargoid.PlanetaryCompassPackD.oxz
.Thargoid.Planetfall.oxz
.Thargoid.Pods.oxz
.Thargoid.RealisticDamage.oxz
.Thargoid.RetroRockets.oxz
.Thargoid.RingRacer.oxz
.Thargoid.SecondWave.oxz
.Thargoid.StellarSerpents.oxz
.Thargoid.TAP.oxz
.Thargoid.Tracker.oxz
.Thargoid.TrackerCam.oxz
.Thargoid.TrafficControl.oxz
.Thargoid.Vortex.oxz
.Thargoid.WelcomeMat.oxz
.Thargoid.Wildships.oxz
.Thargoid.YAH-Mobile.oxz
.Tricky.Jaguar_Company.oxz
.UK_Eliter.ExtraThargoids.oxz
.UK_Eliter.Ferdelance_3G.oxz
.UK_Eliter.InterstellarTweaks.oxz
.UK_Eliter.NexusMissile.oxz
.UK_Eliter.SuperSidewinder.oxz
.Vincentz.NovaLuxHUD.oxz
.Wildeblood.alerting_crosshairs.oxz
.Wildeblood.Contracted_Goods_Reminder.oxz
.Wildeblood.DistantSpace.oxz
.Wildeblood.LaserificCrosshairs.oxz
.Wildeblood.ShieldtasticCrosshairs.oxz
.Wildeblood.Station_Self_Destruction.oxz
.Wildeblood.Undocumented_Launch.oxz
.Wildeblood.Untrumbled.oxz
.zireael.oranged-hud.oxz
.ZygoUgo.Explosions.oxz
.ZygoUgo.ZygoCinematicSkyNebulas.oxz
StationDockControl.oxz
tws_satnav.oxz
../AddOns/Hyperspace_Hangar_1.14.7.oxz
../AddOns/ .Norby.Towbar.oxz
../AddOns/Povray_Planets_Galaxy1_Textures_v1.1.oxp
../AddOns/Povray_Planets_Galaxy6_Textures.oxp

[phkb]

Hmm... that is quite a list. Save games will include items from removed OXP's so it could still be helpful. It's certainly an easier place to start...

[Cmdr. Aiden Henessy]

Well, I feel rather dumb right now actually. I think the problem might have been with Ship Version. The screen I saw is actually from Ship Version oxp, not Ship Comparisons. I don't have the time at the moment to test that for sure this is causing the issue, but I realize that screen was not from Ship Comparisons, it was from Ship Version. Thus the reason why testing the program with Comparisons didn't result in the bug.


.... I'm leading everybody down a fun goose chase. I apologize.

[Theta Seven]

Running Oolite v1.84, I found some bugs with the oxp:

First, when I buy ships, my credits get wiped out - I fixed it following the small bug phkb mentioned - the missing underscores in this._shipPercent caused the problem, so now it works perfectly.

Second, and I haven't yet found what causes it, was that after I bought a ship, my credit balance actually grew - I had a python and when I bought a ship for about 80K for testing, I received an extra ~50K... It seems that even though my old ship gets stored, the game thinks I sold it, and I get the money for it.

[Ramen]

Are you running the latest version? I swear I fixed the credit wipe bug.
...I might not have remembered to upload it though.
Also, I have unfortunately found myself with little to no time to maintain this oxp. If someone is willing to take over, that would be great.
I will fix your bugs, but I don't think I can keep this in ongoing development.

[Theta Seven]

I am running the latest version, according to the in-game manager.

I would take over it, however my lack of skills make me a pretty unsuitable maintainer, so I have to say no to that.