Display Current Course OXP

Discussion and information relevant to creating special missions, new ships, skins etc.

Moderators: winston, another_commander

User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Display Current Course OXP

Post by phkb »

Zireael wrote:
he image in first post doesn't show up
Really? The image is stored on the wiki - can you get to this wiki link OK: http://wiki.alioth.net/index.php/Display_Current_Course?
User avatar
ffutures
---- E L I T E ----
---- E L I T E ----
Posts: 2172
Joined: Wed Dec 04, 2013 12:34 pm
Location: London, UK
Contact:

Re: Display Current Course OXP

Post by ffutures »

I hate to say it, but the problem with the displayed route changing has appeared a couple more times. But only on the parcel contract screen, not cargo or passengers. Could there be something different about this page that might cause it?
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Display Current Course OXP

Post by phkb »

Hmm, there shouldn't be any difference with parcel contracts. Can you produce the issue consistently? Is there a definite sequence of events that will produce the issue? Do you have any other OXP's installed that may be involved (for instance, I know that Escort Contracts doesn't reset the player's original course after displaying contract details)?
Fritz
---- E L I T E ----
---- E L I T E ----
Posts: 591
Joined: Sun Jul 12, 2015 2:30 pm
Location: Bavaria, Germany
Contact:

Re: Display Current Course OXP

Post by Fritz »

phkb wrote:
for instance, I know that Escort Contracts doesn't reset the player's original course after displaying contract details
The target system is changed if you use the map during contract selection, like it is changed when selecting any other system on the map. The bad thing is that the change is also made permanent when the contract isn't selected. I'll try to fix it.
"You wouldn't kill me just for a few credits, would you?" – "No, I'll do it just for the fun!"
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Display Current Course OXP

Post by phkb »

Fritz wrote:
I'll try to fix it
The fix is pretty simple - store the players current "targetSystem" when opening the page, and restore it when leaving. The built in contracts screens have a good sample for when the save and restore should take place.
User avatar
ffutures
---- E L I T E ----
---- E L I T E ----
Posts: 2172
Joined: Wed Dec 04, 2013 12:34 pm
Location: London, UK
Contact:

Re: Display Current Course OXP

Post by ffutures »

Sorry - I should make this clearer, this is only showing on the contract map, it isn't changing the course that's actually set for the ship.
Fritz
---- E L I T E ----
---- E L I T E ----
Posts: 591
Joined: Sun Jul 12, 2015 2:30 pm
Location: Bavaria, Germany
Contact:

Re: Display Current Course OXP

Post by Fritz »

phkb wrote:
The fix is pretty simple
Yes, it's working already.
"You wouldn't kill me just for a few credits, would you?" – "No, I'll do it just for the fun!"
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Display Current Course OXP

Post by phkb »

ffutures, I'm really struggling to reproduce the issue. I'm obviously too close to the code, and I'm doing things the program expects, so I'm not seeing the same results as you. I've tried every menu option combination and screen sequence I can think of, but I can only get the current route plotted. If you're able to document a sequence of events I can really nail this bug. To the wall. With a nail gun.
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Re: Display Current Course OXP

Post by Cody »

Just installed this for a poke around - first use gets this: set route and contract route.

With no set route, it still displays both routes as in the contract image above.
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
User avatar
ffutures
---- E L I T E ----
---- E L I T E ----
Posts: 2172
Joined: Wed Dec 04, 2013 12:34 pm
Location: London, UK
Contact:

Re: Display Current Course OXP

Post by ffutures »

Cody wrote:
Just installed this for a poke around - first use gets this: set route and contract route.

With no set route, it still displays both routes as in the contract image above.
I've occasionally got that result even when a different route has been set. I can't think of any other special circumstances, if it happens again I'll try to see what else seems to be happening.
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Display Current Course OXP

Post by phkb »

Cody wrote:
With no set route, it still displays both routes as in the contract image above.
Cody, when you say "No route set", do you mean you set your destination to your current system, thus completely removing any route information. Or do you use Shift-6 on the galactic chart and switch to "Route Mode - None"? Because if it's the latter I think I can see the problem - I'm assuming that switching to "route mode - none" you still have a route, which I'm plotting with fewest jumps. However, I now can see that assumption is incorrect. "Route mode - none" means just that - no route is selected.
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Re: Display Current Course OXP

Post by Cody »

phkb wrote:
Or do you use Shift-6 on the galactic chart and switch to "Route Mode - None"?
<nods> Yeah... exactly that!
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Display Current Course OXP

Post by phkb »

Right! Fix on the way! <starts rummaging through code>
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Display Current Course OXP

Post by phkb »

OK, version 1.4 is now available, which corrects my assumptions about the "Route Mode - None" selection on the Galactic chart.
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Re: Display Current Course OXP

Post by Cody »

I think that gets it... with parcels, anyway.
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
Post Reply