Trunk nightly

[Cody]

Is "galactic_hyperspace_behaviour" = "BEHAVIOUR_STANDARD"; (the default) working correctly?
It keeps dumping me in the centre of G8 (Maarabi), having left G7 in the extreme NE corner (Inlaoran).

[another_commander]

Hmm... Worked well from Edoned, but leaving G7 from Inlaoran does indeed land you on Maarabi (G8). Not sure why.

[another_commander]

I think I know why it happens and it looks like a typical, baseline, typo in the code. Stand by for incoming fix in trunk.

[kanthoney]

I don't think it was a typo - it looks like it was that way to avoid double counting links (since the distance from A to B is the same as from B to A, you should be able to save a lot of work by only checking one of them).

Edit: Also, what happens if i=j? Then the distance would be zero for all systems, and they'd all be marked as connected.

Edit 2: Actually, no it wouldn't, unless the system is already connected. Forget that.

[another_commander]

I don't think it was a typo - it looks like it was that way to avoid double counting links (since the distance from A to B is the same as from B to A, you should be able to save a lot of work by only checking one of them).

Maybe it was meant as an optimization indeed, but the thing is, the two nested loops in that method need to run from 0 to 255, otherwise updating the planet-is-connected-to-system-0 status fails. This, together with the fact that the findConnectedSystemAtCoords: withGalaxy: is called only when galactic jumping, makes me doubt about the benefit of optimizing this in the first place, that's why I believed it to be a typo.

Edit: Adding github commit 666b02e fixing this.

[Cody]

Thanks - on another cross-chart run now, but I'll be back at Inlaoran by tomorrow.

[another_commander]

Looks like it may have not been a typo after all Turns out that the findNeighbouringSystemToCoords method needed the same fix too. Thankfully, it doesn't seem to be called from anywhere though.

[Cody]

A quirk of the route-planner? Something to do with rounding? It changed itself after the first jump - here and here.

[Cody]

Weird scenes in the aegis!

[Cody]

Is the default descriptions.plist correct? No separator between number groups - only a space instead of a comma?
Also, in Joystick Config, when Toggle Weapons Online is set, it jumps back to the first page.

[another_commander]

Is the default descriptions.plist correct? No separator between number groups - only a space instead of a comma?
Also, in Joystick Config, when Toggle Weapons Online is set, it jumps back to the first page.

Yes, the descriptions.plist has intentionally the whitespace as number separaator. Easier to handle from an i18n perspective. For some countries, the decimal separator is the comma and the number groups separator is the dot, so having the group separator as simply whitespace is good for all.

The unintentional reset to the stickmapper first page when (un)setting Weapons Online Toggle should be fixed with commit 5b81391. Thanks for that, good catch.

[Cody]

Personally, I think the default whitespace looks daft... but there you go!
How do I add separators to contract values when displayed on F5/F5?

[another_commander]

How do I add separators to contract values when displayed on F5/F5?

You will have to install tomorrow's nightly and then they will be formatted too. Feature/fix added with commit dfa53f1. Note also the key number-group-threshold in descriptions.plist, which tells Oolite after how many digits it will start looking at separating number groups. Default is 5, which means that a value of 1,000.0 will apear as 1000.0, while a value of 10,000.0 will appear as 10 000.0. You can adjust that key to 4, which is probably a more correct value.

[Cody]

You will have to install tomorrow's nightly and then they will be formatted too.

Muchas gracias, Admiral!

[Cody]

Erm... got a bunch of these:

Code: Select all

13:57:37.691 [strings.expand.warning.unknownExpansion]: ----- WARNING: Unknown expansion key [fee] in string.
13:57:37.691 [strings.expand.warning.unbalancedClosingBracket]: ----- WARNING: Unbalanced ] in string.

The contract screen has 'fee' instead of the amount.