Scooping platinum/gold while carrying more than 499

[Anonymissimus]

Difficult to reproduce, but now I'm sure that there is some problem here:
Be carrying more than the "free" capacity 499 of either platinum or gold, then scoop a cargo canister of that cargo type. This at least *sometimes* (perhaps always - not sure) "deletes" some of that carried cargo. I've witnessed it happening in the manifest MFD. I also had it happening several times already and thought that I must have been hit on the hull but that wasn't always so. Perhaps it is necessary to have a full cargo hold previously, I dropped another container previously to be able to scoop.
A few other times I saw it happening that scooping that gold/platinum took more than just 1 TC, perhaps that's the same bug or related. In that case my cargo hold hadn't been full previously or there was more than just 1 free TC cargo space.
This is 1.82.1@23b4ca1c3256ca48ef3a9f4955fe2d44bab60417

[Switeck]

What may be happening is the "temporary" cargo container that you just scooped pushes the current amount over 499 kg so the game says the excess uses 1 TC on its own...then suddenly realizes it doesn't have room for the "temporary" cargo container, and destroys it along with a random amount of platinum/gold.

Be interesting to try scooping some platinum/gold cargo containers when already at ~499 kg to see if they cause a 2 TC increase in carried cargo.

[Anonymissimus]

I just scooped an escape pod while carrying 0/5 TC cargo space (military manta ray from aquatics with cargo expansion and pylon reloader). It's consuming 2 TC cargo space, so 2/5 TC now according to the MFD and manifest screen. Other than that I only have 0 gold, 118kg platinum and 94g gemstones. Manifest shows that the platinum would consume 1 TC. Which is nonsense as I didn't scoop anything else since I was docked the last time.

[another_commander]

Does this happen without OXPs?

[Anonymissimus]

No idea. I assume one could assemble a test case using an almost strict fresh Jameson and putting stuff to scoop near the witchpoint in Zaonce, if I knew how to do that.
My addons:

Code: Select all

    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.CargoShepherd.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.EricWalch.MissileAnalyser.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.CargoSpotter.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Wildeblood.Display_Reputation.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Norby.EscortDeck.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.EricWalch.PirateCove.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.phkb.DamageReportMFD.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/DTT.Planet_Express 1.1.Paradox.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.cim.comms-pack-a.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Norby.VariableMasslock.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Switeck.Auto-ECM.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Lone_Wolf.ETTHomingBeacon.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.EricWalch.DeepSpaceDredger.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.spara.manifest_mfd.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.phkb.StationDockControl.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Norby.HUDSelector.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.spara.rescue_stations.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.spara.behemoth.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Ramirez.FuelTank.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.HiredGuns.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.Bigships.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.cim.combat-simulator.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.spara.start_choices.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.AndreyBelov.BountyInformer.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.spara.random_hits_resources.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Wildeblood.Untrumbled.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.NavalGrid.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Diziet.Q-Bomb-Detector.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Norby.CombatMFD.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Svengali.CCL.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.LittleBear.AsteroidStorm.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.Vortex.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.EricWalch.DeepSpacePirates.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.CaptMurphy.ShipStorageHelper.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.ClymAngus.NeoCaduceus.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.spara.navigation_mfd.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Norby.ReverseYControl.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.spara.market_observer.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Neelix.WaypointHere.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.BeeTLeBeTHLeHeM.LifeInTheFrontier.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.phkb.BroadcastCommsMFD.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.APRIL.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.CaptMurphy.PoliceIFFScanner.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.MilFuelInj.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.phkb.EmailSystem.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Svengali.OXPConfig.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.cim.skilled-npcs.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.Neo-Docklights.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.phkb.CommsLogMFD.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.CmdrWombat.ThargoidWars.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.spara.random_hits.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Commander_McLane.Randomshipnames.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.IronHide.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.CommonSenseOTB.ShieldEqualizer+Capacitors.oxz
    ~/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Okti.CargoScanner.oxz
    ~/.Oolite/AddOns/oolite.oxp.Thargoid.TAP-1.12.oxp
    ~/.Oolite/AddOns/UsefulMFDs_0.3.oxp
    ~/.Oolite/AddOns/oolite.oxp.Thargoid.Aquatics-2.32.oxp

[another_commander]

I assume one could assemble a test case using an almost strict fresh Jameson and putting stuff to scoop near the witchpoint in Zaonce, if I knew how to do that.

Quick guide how to do that:
1. Use the OXP Developer version of the game (also known as Test Release) and make sure that Basic-debug.oxp is present.
2. Install the Debug Console. There is a link to it in the Downloads page on oolite.org.
3. Start the debug console, then launch Oolite. If all has gone well, you should see the console reporting "Opened connection with Oolite version 1.82".
4. In the console type:

Code: Select all

PS.manifest.gold=<whatever gold you want to have>
PS.manifest.platinum=<whatever platinum you want to have>
PS.manifest.gem_stones=<whatever gemstones you want to have>

5. Launch in the game.
6. Type in the console :spawn cargopod to spawn a cargopod or :spawn escape-capsule for an escape pod. The items will be spawned within scanner range.
7. Repeat step 6 as many times as you want, then scoop and see what happens.

The console works also in strict mode.

[Anonymissimus]

I'm using a git checkout and don't install anything else. The stuff seems present (it should be shouldn't it), perhaps I need to build the debug console previously ? Is the updated 1.82.x branch already a "test release" ?

[another_commander]

I'm using a git checkout and don't install anything else. The stuff seems present (it should be shouldn't it), perhaps I need to build the debug console previously ? Is the updated 1.82.x branch already a "test release" ?

The debug console sources are on github but they are not part of the Oolite checkout. They are contained in the oolite-debug-console subproject. If you are on Linux you need Python to run it, but I cannot give more details, as Linux is not my territory. On Windows, the easiest solution is to use the pre-compiled binary provided by oolite.org.

Test Release, Deployment Release etc. are just different configurations with which you can build the code. You can build 1.82.x either way, depending on what make command you execute. Doing a make -fMakefile release will give you a Test Release build, while doing a make -fMakefile release-deployment will generate an end-user build. There are other configurations too; doing a make -fMakefile help will list them.

[Diziet Sma]

If you are on Linux you need Python to run it, but I cannot give more details, as Linux is not my territory.

For Linux users, I'm not certain as to whether the debug console uses Python 2.7 or 3.4, as I have both installed on my system. (The Python script for converting XML plists to NeXTSTEP requires 2.7) If it doesn't work, install the version you don't have, (and let us know about it, please, so we can make a note of it somewhere).

[Lone_Wolf]

I'm not certain as to whether the debug console uses Python 2.7 or 3.4

Python2.7 , i had to install python2 version of twisted to get the debug console to work.

[Anonymissimus]

So, I finally did the debug console thing...
The problem is probably not reproducible without addons (other than DebugOXP).
I could reproduce something with addons and the console pointed me to the Vortex OXP, it contains this code

Code: Select all

this.shipScoopedOther = this.safeCargo = function()
	{
	this.gold = manifest["gold"];
	this.platinum = manifest["platinum"];
	this.gems = manifest["gemStones"];
	manifest["gold"] = 0;
	manifest["platinum"] = 0;
	manifest["gemStones"] = 0;
	manifest["gold"] = this.gold;
	manifest["platinum"] = this.platinum;
	manifest["gemStones"] = this.gems;
	}

which causes some platinum to use a cargo container after something else was scooped. So ship's manifest shows 2 TC in use, one for 499kg platinum which was the only cargo previously, and the scooped cargo (which is alright). This is probably the cause of or related to the problem(s).
From a scripter point of view, the above code should not alter the ship's manifest as displayed by F5, no ?
The other question is why that code is run albeit it's only needed for the Vortex, that being an addon bug then.