[Solved] Illegal Goods Problem - Oolite 1.81 (trunk)

[CommRLock78]

Greetings! There seems to be a bug with IG when you dock to meet with a relative a freed slave. The spacebar doesn't move seem to work, so I get stuck there on this screen:
https://dl.dropboxusercontent.com/u/959 ... Thanks.png

Here's the latest log:
https://dl.dropboxusercontent.com/u/95921622/Latest.log

It appears the relevent messages start about line 1763.

Edit: It looks like mission.unmarkSystem no longer uses numbers ( )

Edit 2: Fixed conflict with Email System and Illegal Good Tweak

[cim]

16:33:17.930 [oxp-standards.deprecated]: Use of numbers for mission.unmarkSystem is deprecated

Harmless - though using the new format would allow more control over the mission markers and prevent other OXPs from accidentally overwriting them. "deprecated" is just a hint to OXP authors that there's a better way available now, and that log message won't even appear in non-developer builds of Oolite.

16:33:17.933 [script.javaScript.exception.uncaughtException]: ***** JavaScript exception (illegal_goods_missions 2.0.0): uncaught exception: Invalid settings: sender must be supplied.

This will be what's causing the problem - but the message "Invalid settings: sender must be supplied." doesn't appear anywhere in the Oolite source, so I suspect an OXP problem. Which OXP, I don't know.

[Wildeblood]

16:33:17.933 [script.javaScript.exception.uncaughtException]: ***** JavaScript exception (illegal_goods_missions 2.0.0): uncaught exception: Invalid settings: sender must be supplied.

This will be what's causing the problem - but the message "Invalid settings: sender must be supplied." doesn't appear anywhere in the Oolite source, so I suspect an OXP problem. Which OXP, I don't know.

Email system. Every email it sends has a sender specified, but some are as literal text and some are like this:-

w.$createEmail({sender:expandMissionText("[mission_ig_contactname]"),
subject:"Eternal Gratitude",
date:global.clock.seconds,
message:expandMissionText("end_mission_email")}
);

I suspect the missiontext expansion.

[phkb]

Yep, my bad. Last minute changes are a bad idea. Note to self.

New version on the way.

[CommRLock78]

Thanks for fixing those things so quickly Phkb!