Issue with targetSystem at Divees/Tezabi

Discussion and information relevant to creating special missions, new ships, skins etc.

Moderators: winston, another_commander

Post Reply
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Issue with targetSystem at Divees/Tezabi

Post by phkb »

There seems to be an issue with the player.ship.targetSystem (in 1.80) when I'm in G5 Divees. Now, Divees and Tezabi have the same galactic coordinates (37,130). When I'm in Tezabi, I can set my destination to Divees and everything works OK. My HUD displays the correct system, player.ship.targetSystem also picks up the correct system, and things like BroadcastComms MFD and Navigation MFD use it to do various things with.

But, if I'm in Divees, and I set my destination to Tezabi, things go a little funny. Navigation MFD thinks I don't have a destination set. BroadcastComms MFD (which uses player.ship.targetSystem) also thinks I don't have a target system set.

However, my HUD quite happily displays my destination as Tezabi, so at least one unit seems to know where I'm going!

Is this a bug with player.ship.targetSystem? Or have I done something silly elsewhere?
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Re: Issue with targetSystem at Divees/Tezabi

Post by Cody »

Divees and Tezabi - ah yes, I remember them well! They, and the other double systems, caused some trouble way back.
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
User avatar
spara
---- E L I T E ----
---- E L I T E ----
Posts: 2691
Joined: Wed Aug 15, 2012 4:19 am
Location: Finland

Re: Issue with targetSystem at Divees/Tezabi

Post by spara »

phkb wrote:
Is this a bug with player.ship.targetSystem? Or have I done something silly elsewhere?
Looks like it. Has been fixed in Oolite 1.81.
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Issue with targetSystem at Divees/Tezabi

Post by phkb »

spara wrote:
Has been fixed in Oolite 1.81.
Ah, right. Thanks spara!
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: Issue with targetSystem at Divees/Tezabi

Post by cim »

In 1.80 and earlier the internal representation of currentSystem and targetSystem (and a few other similar variables) is as a set of 'x,y' coordinates. There's then a layer of stuff built on top of that for distinguishing properly between zero-distance doubles, which sometimes even works.

In 1.81 the internal representation is the system ID number. There may still be some bugs around zero-distance doubles, so if you're testing that version please keep your eyes open for them.
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Re: Issue with targetSystem at Divees/Tezabi

Post by Cody »

cim wrote:
In 1.81 [snip]There may still be some bugs around zero-distance doubles, so if you're testing that version please keep your eyes open for them.
I've not seen any problems - apart from F6 not showing distance/travel time between a double, that is.
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: Issue with targetSystem at Divees/Tezabi

Post by cim »

Cody wrote:
apart from F6 not showing distance/travel time between a double, that is.
Thanks - that bit is still using coordinates more than it needs to. I'll fix it up.
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: Issue with targetSystem at Divees/Tezabi

Post by cim »

Okay, this should be fixed in tonight's nightly so that the distance/time for a jump between a zero-distance pair shows correctly. A bug with selection introduced at some point during 1.81 is also fixed.

Please keep looking for others.
Post Reply