Trunk nightly

[another_commander]

I can confirm this.
The shipyard is always named after the (ultimate) hyperspace destination system although in my case there aren't only Morays for sale.

This is now fixed in commit ea1eaae. Just a small typo or maybe copy/paste thing.

[cim]

I have just had it happen again (in Ceerdiza), this time in front of me. Don't know if it helps but when it happened I got a flash of my engine exhausts on my front view screen, then the Coriolis station started spinning fast and at a changed angle. I was in normal flight heading towards the station, not doing anything else.

That certainly matches all the symptoms - at some point a bunch of junk data gets written to various properties, including the station roll rate - but unfortunately without the right debugging setup it's very hard to work out why, especially since it seems to be exclusive to the Mac.

I expect we'll track it down eventually.

[Venator Dha]

I have just had it happen again (in Ceerdiza), this time in front of me. Don't know if it helps but when it happened I got a flash of my engine exhausts on my front view screen, then the Coriolis station started spinning fast and at a changed angle. I was in normal flight heading towards the station, not doing anything else.

That certainly matches all the symptoms - at some point a bunch of junk data gets written to various properties, including the station roll rate - but unfortunately without the right debugging setup it's very hard to work out why, especially since it seems to be exclusive to the Mac.

I expect we'll track it down eventually.

I'm sure you will, it's not a game killer however, just slightly annoying. I wish I understood the programming side better to help, but I think it would require a lot of work to just understand what to do.
It might be coincidence that I've only just had this happen to me with the last two trunks, could something that's been changed recently be the cause?

[cim]

It might be coincidence that I've only just had this happen to me with the last two trunks, could something that's been changed recently be the cause?

With it being a memory-overwriting bug of some sort, exactly what gets overwritten and whether that matters is going to depend very heavily on the exact layout of the application in memory. So it's certainly possible that some builds are more prone to it than others, or on some builds the overwrite ends up being harmless.

[Venator Dha]

With it being a memory-overwriting bug of some sort, exactly what gets overwritten and whether that matters is going to depend very heavily on the exact layout of the application in memory. So it's certainly possible that some builds are more prone to it than others, or on some builds the overwrite ends up being harmless.

Does that mean that having other apps open/running could affect it?
Another thought is that I'm now running it on a MacbookAir, rather than an iMac so different RAM (8GB vs 12GB). If it would be worth it I can run it on both?

[cim]

I don't know. Either might make a difference to the internal memory layout, but we're unlikely to get that much useful information out of it if it does.

[Venator Dha]

I don't know. Either might make a difference to the internal memory layout, but we're unlikely to get that much useful information out of it if it does.

OK, thanks. I'll keep a watching brief on it.

[Cody]

Upon scooping some platinum, this appeared - closely followed by this:

Code: Select all

19:00:55.948 [strings.expand.warning.unknownExpansion]: ----- WARNING: Unknown expansion key [containers] in string.
19:00:55.948 [strings.expand.warning.unbalancedClosingBracket]: ----- WARNING: Unbalanced ] in string.

While I'm here: I've been seeing what I presume are cloud shadows on some Povray gas giants - is this correct?

[cim]

Upon scooping some platinum, this appeared

Thanks - fixed in 1aa818b0.

Yes, the clouds are normal. For gas giants, cloud_alpha = 0 (or at least a low number like 0.1) in the system's planetinfo.plist is probably a good idea. (When I had Povray installed, I set cloud_alpha = 0.2 in the universal section, since a lot of the non-giant planets also have clouds)

[Cody]

There's more...

Code: Select all

19:24:20.687 [script.javaScript.warning.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 388.
19:24:20.687 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:388) <anonymous function>
19:24:20.687 [script.javaScript.stackTrace]:     this: {...}
19:24:20.687 [script.javaScript.stackTrace]:     priority: 3
19:24:20.687 [script.javaScript.stackTrace]:     params: [Wormhole destination: Andibia ttl: -14248.14s arrival: 2089737:08:00:17]
19:24:20.687 [script.javaScript.stackTrace]:     key: "oolite_beginningAttack"
19:24:20.687 [script.javaScript.stackTrace]:     message: undefined
19:24:20.687 [script.javaScript.stackTrace]:     template: "[commsPackA_freelancer_beginningAttack]"
19:24:20.687 [script.javaScript.stackTrace]:     recv: 180553305620.34753
19:24:20.687 [script.javaScript.stackTrace]:     send: 180553305620.34753
19:24:20.687 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:670) <anonymous function>
19:24:20.687 [script.javaScript.stackTrace]:     this: {...}
19:24:20.687 [script.javaScript.stackTrace]:     priority: 3
19:24:20.687 [script.javaScript.stackTrace]:     code: "beginning"
19:24:20.687 [script.javaScript.stackTrace]:     target: [Wormhole destination: Andibia ttl: -14248.14s arrival: 2089737:08:00:17]
19:24:20.687 [script.javaScript.stackTrace]:     scan: "CLASS_WORMHOLE"
19:24:20.687 [script.javaScript.stackTrace]:     msgcode: "oolite_beginningAttack"
19:24:20.687 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:2916) <anonymous function>
19:24:20.687 [script.javaScript.stackTrace]:     this: {...}
19:24:20.687 [script.javaScript.stackTrace]:     handlers: {...}
19:24:20.687 [script.javaScript.stackTrace]:  3 (oolite-priorityai.js:224) _reconsider()
19:24:20.687 [script.javaScript.stackTrace]:     this: {...}
19:24:20.687 [script.javaScript.stackTrace]:     newBehaviour: function
19:24:20.687 [script.javaScript.stackTrace]:  4 (oolite-priorityai.js:75) _handlerAIAwoken()
19:24:20.687 [script.javaScript.stackTrace]:     this: {...}
19:24:20.687 [script.javaScript.warning.ooliteDefined]: ----- JavaScript warning (Oolite Assassin AI 1.81): Unbalanced ] in string.
19:24:20.687 [script.javaScript.warning.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 388.
19:24:20.687 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:388) <anonymous function>
19:24:20.687 [script.javaScript.stackTrace]:     this: {...}
19:24:20.687 [script.javaScript.stackTrace]:     priority: 3
19:24:20.687 [script.javaScript.stackTrace]:     params: [Wormhole destination: Andibia ttl: -14248.14s arrival: 2089737:08:00:17]
19:24:20.687 [script.javaScript.stackTrace]:     key: "oolite_beginningAttack"
19:24:20.687 [script.javaScript.stackTrace]:     message: undefined
19:24:20.687 [script.javaScript.stackTrace]:     template: "[commsPackA_freelancer_beginningAttack]"
19:24:20.687 [script.javaScript.stackTrace]:     recv: 180553305620.34753
19:24:20.687 [script.javaScript.stackTrace]:     send: 180553305620.34753
19:24:20.687 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:670) <anonymous function>
19:24:20.687 [script.javaScript.stackTrace]:     this: {...}
19:24:20.687 [script.javaScript.stackTrace]:     priority: 3
19:24:20.687 [script.javaScript.stackTrace]:     code: "beginning"
19:24:20.687 [script.javaScript.stackTrace]:     target: [Wormhole destination: Andibia ttl: -14248.14s arrival: 2089737:08:00:17]
19:24:20.687 [script.javaScript.stackTrace]:     scan: "CLASS_WORMHOLE"
19:24:20.687 [script.javaScript.stackTrace]:     msgcode: "oolite_beginningAttack"
19:24:20.687 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:2916) <anonymous function>
19:24:20.687 [script.javaScript.stackTrace]:     this: {...}
19:24:20.687 [script.javaScript.stackTrace]:     handlers: {...}
19:24:20.687 [script.javaScript.stackTrace]:  3 (oolite-priorityai.js:224) _reconsider()
19:24:20.687 [script.javaScript.stackTrace]:     this: {...}
19:24:20.687 [script.javaScript.stackTrace]:     newBehaviour: function
19:24:20.687 [script.javaScript.stackTrace]:  4 (oolite-priorityai.js:75) _handlerAIAwoken()
19:24:20.687 [script.javaScript.stackTrace]:     this: {...}
19:24:20.688 [strings.expand.warning.unknownExpansion]: ----- WARNING: Unknown expansion key [oolite_entityName] in string.
19:24:20.688 [strings.expand.warning.unbalancedClosingBracket]: ----- WARNING: Unbalanced ] in string.

[spara]

When you press f6 twice while in hyperspace countdown the screen only partially changes to the long range chart. You get the find planet dialog, but the map itself stays in the short range chart.

[gizmo]

When in the long range chart (regardless if in flight or docked) you can't toggle the TAF / FPS display (Shift-F).
This also happens in some of the F4 subscreens.

Releated suggestion: since changing the TAF in the F2-F8 screens doesn't work anyway the TAF should be automatically reset to 1 (and toggled off) when docked.

[cim]

When in the long range chart (regardless if in flight or docked) you can't toggle the TAF / FPS display (Shift-F).
This also happens in some of the F4 subscreens.

Quite a lot of keys won't work on those screens, as they're in "text input" mode. "Shift-F" will add "F" to the text string, but on the F6 screen without OXPs no system names contain the letter 'F', so this doesn't appear to do anything. (On the other hand, having the FPS display appear when you're trying to enter 'F' into a mission screen is really irritating)

This remains true even if you remap the FPS toggle to a non-printable key, which isn't entirely ideal but is tricky to fix.

Releated suggestion: since changing the TAF in the F2-F8 screens doesn't work anyway the TAF should be automatically reset to 1 (and toggled off) when docked.

TAF is a debugging feature, and there are cases while debugging you might want to continue with accelerated (or decelerated) time while docked, so I'm not sure forcing resets of it is a good idea.

If you want this for your own game, add this to a worldscript.

Code: Select all

this.shipDockedWithStation = function() {
  timeAccelerationFactor = 1;
}

[cim]

When you press f6 twice while in hyperspace countdown the screen only partially changes to the long range chart. You get the find planet dialog, but the map itself stays in the short range chart.

I suspect that's intentional, though kanthoney would know. You can't take actions which change your witchspace target system while a countdown is in progress, and changing the zoom level can affect your target system.

[cim]

There's more...

Thanks - I thought I'd got all of those. I'll take a look.