Trunk nightly

[cim]

The attack threshold should vary depending on system government. You should always be okay with a single credit bounty, though, even in Corporate States. The occasional trader attacking you when no-one's looking - and then in your case running away when they discover that your ship is heavily armed - is intentional, but this should be very rare.

There's a bug introduced into the "in combat" check for the player - if the ship is targeting the player, who has weapons online, then this is assumed to be a hostile condition even if neither ship is actually hostile. I'll adjust for this.

EDIT: should be fixed in tonight's build

[Venator Dha]

The attack threshold should vary depending on system government. You should always be okay with a single credit bounty, though, even in Corporate States. The occasional trader attacking you when no-one's looking - and then in your case running away when they discover that your ship is heavily armed - is intentional, but this should be very rare.

There's a bug introduced into the "in combat" check for the player - if the ship is targeting the player, who has weapons online, then this is assumed to be a hostile condition even if neither ship is actually hostile. I'll adjust for this.

EDIT: should be fixed in tonight's build

Thanks Cim
Looks like it's all linked to the weapons online - I never take them off-line Quick test with weapons off-line means that they don't attack with only a single bounty.

[spara]

Code: Select all

setup_actions = ( initialiseTurret );

in shipdata.plist is giving

Code: Select all

13:44:47.242 [oxp-standards.deprecated]: The setup_actions ship key is deprecated on Ball Turret.

errors and should be removed.

[cim]

setup_actions = ( initialiseTurret );

Removed. Thanks for the report.

[Duggan]

Hello there,

I am not sure if as yet this oxz related bug has been remedied as I am just shy of downloading the latest trunk build.

Stations for Extra Planets seem so far to have no trading capability, that is to say, nothing to trade and no value for any goods, I do appreciate that this may be an issue for Spara though

[spara]

Hello there,

I am not sure if as yet this oxz related bug has been remedied as I am just shy of downloading the latest trunk build.

Stations for Extra Planets seem so far to have no trading capability, that is to say, nothing to trade and no value for any goods, I do appreciate that this may be an issue for Spara though

Markets have gone through a big change in the trunk, thus all old style markets in OXPs are non functional. So far I have fixed RandomHits and Behemoth oxps. And hOopy casino, but that's not really a market for traders. An update for Stations for Extra Planets is coming up next, but it will take a while as I'm fixing those deprecation errors caused by the old style subentities definitions at the same time and there will be some Solo magic included too.

[spara]

Code: Select all

system.mainStation.market["computers"].displayName

returns "undefined" in trunk. In 1.80 it returns "Computers". Looks like a bug as the price comes out just fine.

[cim]

This is expected behaviour. Most of the keys in the market entries have different names to the 1.80 version - for example, there is no longer a marketMaskPrice property because the market price algorithm no longer uses a mask.

As scripts using that data were going to need updating anyway to cope with there no longer being exactly 17 properties with predictable names on the market object it didn't seem worthwhile to try too hard to preserve the subproperty names.

"price" and "quantity" happen to have the same name as the previous object. I suppose I could call the 1.81 property "displayName" instead of "name", but if market.computers isn't guaranteed to exist it maybe isn't worth trying to guarantee that market.computers.name will.

[spara]

Ah . I get it now. The actual name comes from the descriptions.plist where I pull it with the property key from station.market object. We're back in business again . Thanks for answering, it's all clear again.

[spara]

I'm having serious trouble with docking when playing with trunk. No problem in 1.80. Has something changed? I scratch my ship real bad, blow it up or fly through the back of the dock and explode.

[Cody]

Yep, me too! Just went for a quick test - no trouble at a Torus station, but definitely dodgy at a core Coriolis!

[cim]

Confirmed. Any stations with the docks the "wrong" way round are going to be trouble. Stick to Dodecs for now. I have a basic fix for it but that has another bug which allows docking sideways at a Coriolis (though at the cost of serious damage) - I'll keep looking at it and see if I can fix both at once.

EDIT: should now be fixed in tonight's build. Worth testing with both Coriolis (rotated dock) and Dodec (normal dock). Thanks for the reports.

[Rorschachhamster]

I had a strange visual bug just now. I met a colourful illuminated fight between thargoids and a few ships. The highlights from my and everyone else hits on the shields stayed in game, no engine sound anymore and when I finally shot the last thargoid, I activated the torus drive and stars and nebulas from zygoids started to pass my ship (a rather glorius effect, if someone could make something similar for hyperspace, this would be mind blowing ) - until planets, moons and stations hung only in black and I could only see stars behind me...
a "short" part from the logfile shows a lot of errors:

Code: Select all

21:46:52.187 [LogEvents]: Thargoid Invader 20076 spawned at 68 km
21:46:56.415 [LogEvents]: Player alert condition changed from 2 to 1
21:48:33.289 [script.javaScript.warning.ooliteDefined]: ----- JavaScript warning (Oolite Bounty Hunter AI 1.81): Unknown expansion key [oolite_entityClass] in string.
21:48:33.289 [script.javaScript.warning.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 388.
21:48:33.289 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:388) <anonymous function>
21:48:33.289 [script.javaScript.stackTrace]:     this: {...}
21:48:33.289 [script.javaScript.stackTrace]:     priority: 3
21:48:33.289 [script.javaScript.stackTrace]:     params: [Wormhole destination: Usmaso ttl: 89.42s arrival: 2085075:00:33:10]
21:48:33.289 [script.javaScript.stackTrace]:     key: "oolite_beginningAttack"
21:48:33.289 [script.javaScript.stackTrace]:     message: undefined
21:48:33.289 [script.javaScript.stackTrace]:     template: "[commsPackA_mercenary_beginningAttack]"
21:48:33.289 [script.javaScript.stackTrace]:     recv: 16.57568359375
21:48:33.289 [script.javaScript.stackTrace]:     send: 180150472776.32928
21:48:33.289 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:670) <anonymous function>
21:48:33.289 [script.javaScript.stackTrace]:     this: {...}
21:48:33.289 [script.javaScript.stackTrace]:     priority: 3
21:48:33.289 [script.javaScript.stackTrace]:     code: "beginning"
21:48:33.290 [script.javaScript.stackTrace]:     target: [Wormhole destination: Usmaso ttl: 89.42s arrival: 2085075:00:33:10]
21:48:33.290 [script.javaScript.stackTrace]:     scan: "CLASS_WORMHOLE"
21:48:33.290 [script.javaScript.stackTrace]:     msgcode: "oolite_beginningAttack"
21:48:33.290 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:2913) <anonymous function>
21:48:33.290 [script.javaScript.stackTrace]:     this: {...}
21:48:33.290 [script.javaScript.stackTrace]:     handlers: {...}
21:48:33.290 [script.javaScript.stackTrace]:  3 (oolite-priorityai.js:224) _reconsider()
21:48:33.290 [script.javaScript.stackTrace]:     this: {...}
21:48:33.290 [script.javaScript.stackTrace]:     newBehaviour: function
21:48:33.290 [script.javaScript.stackTrace]:  4 (oolite-priorityai.js:75) _handlerAIAwoken()
21:48:33.290 [script.javaScript.stackTrace]:     this: {...}
21:48:33.290 [script.javaScript.warning.ooliteDefined]: ----- JavaScript warning (Oolite Bounty Hunter AI 1.81): Unbalanced ] in string.
21:48:33.290 [script.javaScript.warning.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 388.
21:48:33.290 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:388) <anonymous function>
21:48:33.290 [script.javaScript.stackTrace]:     this: {...}
21:48:33.290 [script.javaScript.stackTrace]:     priority: 3
21:48:33.290 [script.javaScript.stackTrace]:     params: [Wormhole destination: Usmaso ttl: 89.42s arrival: 2085075:00:33:10]
21:48:33.290 [script.javaScript.stackTrace]:     key: "oolite_beginningAttack"
21:48:33.290 [script.javaScript.stackTrace]:     message: undefined
21:48:33.290 [script.javaScript.stackTrace]:     template: "[commsPackA_mercenary_beginningAttack]"
21:48:33.290 [script.javaScript.stackTrace]:     recv: 16.57568359375
21:48:33.290 [script.javaScript.stackTrace]:     send: 180150472776.32928
21:48:33.290 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:670) <anonymous function>
21:48:33.290 [script.javaScript.stackTrace]:     this: {...}
21:48:33.290 [script.javaScript.stackTrace]:     priority: 3
21:48:33.291 [script.javaScript.stackTrace]:     code: "beginning"
21:48:33.291 [script.javaScript.stackTrace]:     target: [Wormhole destination: Usmaso ttl: 89.42s arrival: 2085075:00:33:10]
21:48:33.291 [script.javaScript.stackTrace]:     scan: "CLASS_WORMHOLE"
21:48:33.291 [script.javaScript.stackTrace]:     msgcode: "oolite_beginningAttack"
21:48:33.291 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:2913) <anonymous function>
21:48:33.291 [script.javaScript.stackTrace]:     this: {...}
21:48:33.291 [script.javaScript.stackTrace]:     handlers: {...}
21:48:33.291 [script.javaScript.stackTrace]:  3 (oolite-priorityai.js:224) _reconsider()
21:48:33.291 [script.javaScript.stackTrace]:     this: {...}
21:48:33.291 [script.javaScript.stackTrace]:     newBehaviour: function
21:48:33.291 [script.javaScript.stackTrace]:  4 (oolite-priorityai.js:75) _handlerAIAwoken()
21:48:33.291 [script.javaScript.stackTrace]:     this: {...}
21:48:33.291 [strings.expand.warning.unknownExpansion]: ----- WARNING: Unknown expansion key [oolite_entityClass] in string.
21:48:33.291 [strings.expand.warning.unbalancedClosingBracket]: ----- WARNING: Unbalanced ] in string.
21:48:33.291 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (Oolite Bounty Hunter Leader AI 1.81): Error: Ship.addDefenseTarget: Invalid arguments ([Wormhole destination: Usmaso ttl: 89.42s arrival: 2085075:00:33:10]) -- expected target.
21:48:33.291 [script.javaScript.exception.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 5006.
21:48:33.291 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:2914) <anonymous function>
21:48:33.291 [script.javaScript.stackTrace]:     this: {...}
21:48:33.291 [script.javaScript.stackTrace]:     handlers: {...}
21:48:33.292 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:224) _reconsider()
21:48:33.292 [script.javaScript.stackTrace]:     this: {...}
21:48:33.292 [script.javaScript.stackTrace]:     newBehaviour: function
21:48:33.292 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:75) _handlerAIAwoken()
21:48:33.292 [script.javaScript.stackTrace]:     this: {...}
21:48:33.292 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (Oolite Bounty Hunter AI 1.81): Error: Ship.addDefenseTarget: Invalid arguments ([Wormhole destination: Usmaso ttl: 89.42s arrival: 2085075:00:33:10]) -- expected target.
21:48:33.292 [script.javaScript.exception.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 5006.
21:48:33.292 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:2914) <anonymous function>
21:48:33.292 [script.javaScript.stackTrace]:     this: {...}
21:48:33.292 [script.javaScript.stackTrace]:     handlers: {...}
21:48:33.292 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:224) _reconsider()
21:48:33.292 [script.javaScript.stackTrace]:     this: {...}
21:48:33.292 [script.javaScript.stackTrace]:     newBehaviour: function
21:48:33.292 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:75) _handlerAIAwoken()
21:48:33.292 [script.javaScript.stackTrace]:     this: {...}
21:48:33.292 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (Oolite Bounty Hunter AI 1.81): Error: Ship.addDefenseTarget: Invalid arguments ([Wormhole destination: Usmaso ttl: 89.42s arrival: 2085075:00:33:10]) -- expected target.
21:48:33.292 [script.javaScript.exception.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 5006.
21:48:33.292 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:2914) <anonymous function>
21:48:33.292 [script.javaScript.stackTrace]:     this: {...}
21:48:33.292 [script.javaScript.stackTrace]:     handlers: {...}
21:48:33.292 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:224) _reconsider()
21:48:33.292 [script.javaScript.stackTrace]:     this: {...}
21:48:33.293 [script.javaScript.stackTrace]:     newBehaviour: function
21:48:33.293 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:75) _handlerAIAwoken()
21:48:33.293 [script.javaScript.stackTrace]:     this: {...}
21:48:33.293 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (Oolite Bounty Hunter AI 1.81): Error: Ship.addDefenseTarget: Invalid arguments ([Wormhole destination: Usmaso ttl: 89.42s arrival: 2085075:00:33:10]) -- expected target.
21:48:33.293 [script.javaScript.exception.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 5006.
21:48:33.293 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:2914) <anonymous function>
21:48:33.293 [script.javaScript.stackTrace]:     this: {...}
21:48:33.293 [script.javaScript.stackTrace]:     handlers: {...}
21:48:33.293 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:224) _reconsider()
21:48:33.293 [script.javaScript.stackTrace]:     this: {...}
21:48:33.293 [script.javaScript.stackTrace]:     newBehaviour: function
21:48:33.293 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:75) _handlerAIAwoken()
21:48:33.293 [script.javaScript.stackTrace]:     this: {...}
21:48:33.293 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (Oolite Bounty Hunter AI 1.81): Error: Ship.addDefenseTarget: Invalid arguments ([Wormhole destination: Usmaso ttl: 89.42s arrival: 2085075:00:33:10]) -- expected target.
21:48:33.293 [script.javaScript.exception.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 5006.
21:48:33.293 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:2914) <anonymous function>
21:48:33.293 [script.javaScript.stackTrace]:     this: {...}
21:48:33.293 [script.javaScript.stackTrace]:     handlers: {...}
21:48:33.293 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:224) _reconsider()
21:48:33.293 [script.javaScript.stackTrace]:     this: {...}
21:48:33.293 [script.javaScript.stackTrace]:     newBehaviour: function
21:48:33.293 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:75) _handlerAIAwoken()
21:48:33.293 [script.javaScript.stackTrace]:     this: {...}
21:48:33.603 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (Oolite Bounty Hunter Leader AI 1.81): Error: Ship.addDefenseTarget: Invalid arguments ([Wormhole destination: Usmaso ttl: 89.10s arrival: 2085075:00:33:10]) -- expected target.
21:48:33.603 [script.javaScript.exception.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 5006.
21:48:33.603 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:2914) <anonymous function>
21:48:33.604 [script.javaScript.stackTrace]:     this: {...}
21:48:33.604 [script.javaScript.stackTrace]:     handlers: {...}
21:48:33.604 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:224) _reconsider()
21:48:33.604 [script.javaScript.stackTrace]:     this: {...}
21:48:33.604 [script.javaScript.stackTrace]:     newBehaviour: function
21:48:33.604 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:75) _handlerAIAwoken()
21:48:33.604 [script.javaScript.stackTrace]:     this: {...}
21:48:33.604 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (Oolite Bounty Hunter AI 1.81): Error: Ship.addDefenseTarget: Invalid arguments ([Wormhole destination: Usmaso ttl: 89.10s arrival: 2085075:00:33:10]) -- expected target.
21:48:33.604 [script.javaScript.exception.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 5006.
21:48:33.604 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:2914) <anonymous function>
21:48:33.604 [script.javaScript.stackTrace]:     this: {...}
21:48:33.604 [script.javaScript.stackTrace]:     handlers: {...}
21:48:33.604 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:224) _reconsider()
21:48:33.604 [script.javaScript.stackTrace]:     this: {...}
21:48:33.604 [script.javaScript.stackTrace]:     newBehaviour: function
21:48:33.604 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:75) _handlerAIAwoken()
21:48:33.604 [script.javaScript.stackTrace]:     this: {...}
21:48:33.604 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (Oolite Bounty Hunter AI 1.81): Error: Ship.addDefenseTarget: Invalid arguments ([Wormhole destination: Usmaso ttl: 89.10s arrival: 2085075:00:33:10]) -- expected target.
21:48:33.604 [script.javaScript.exception.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 5006.
21:48:33.605 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:2914) <anonymous function>
21:48:33.605 [script.javaScript.stackTrace]:     this: {...}
21:48:33.605 [script.javaScript.stackTrace]:     handlers: {...}
21:48:33.605 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:224) _reconsider()
21:48:33.605 [script.javaScript.stackTrace]:     this: {...}
21:48:33.605 [script.javaScript.stackTrace]:     newBehaviour: function
21:48:33.605 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:75) _handlerAIAwoken()
21:48:33.605 [script.javaScript.stackTrace]:     this: {...}
21:48:33.605 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (Oolite Bounty Hunter AI 1.81): Error: Ship.addDefenseTarget: Invalid arguments ([Wormhole destination: Usmaso ttl: 89.10s arrival: 2085075:00:33:10]) -- expected target.
21:48:33.605 [script.javaScript.exception.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 5006.
21:48:33.605 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:2914) <anonymous function>
21:48:33.605 [script.javaScript.stackTrace]:     this: {...}
21:48:33.605 [script.javaScript.stackTrace]:     handlers: {...}
21:48:33.605 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:224) _reconsider()
21:48:33.605 [script.javaScript.stackTrace]:     this: {...}
21:48:33.605 [script.javaScript.stackTrace]:     newBehaviour: function
21:48:33.605 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:75) _handlerAIAwoken()
21:48:33.605 [script.javaScript.stackTrace]:     this: {...}
21:48:33.605 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (Oolite Bounty Hunter AI 1.81): Error: Ship.addDefenseTarget: Invalid arguments ([Wormhole destination: Usmaso ttl: 89.10s arrival: 2085075:00:33:10]) -- expected target.
21:48:33.605 [script.javaScript.exception.ooliteDefined]:       Resources/Scripts/oolite-priorityai.js, line 5006.
21:48:33.605 [script.javaScript.stackTrace]:  0 (oolite-priorityai.js:2914) <anonymous function>
21:48:33.606 [script.javaScript.stackTrace]:     this: {...}
21:48:33.606 [script.javaScript.stackTrace]:     handlers: {...}
21:48:33.606 [script.javaScript.stackTrace]:  1 (oolite-priorityai.js:224) _reconsider()
21:48:33.606 [script.javaScript.stackTrace]:     this: {...}
21:48:33.606 [script.javaScript.stackTrace]:     newBehaviour: function
21:48:33.606 [script.javaScript.stackTrace]:  2 (oolite-priorityai.js:75) _handlerAIAwoken()
21:48:33.606 [script.javaScript.stackTrace]:     this: {...}
21:48:33.864 [exception]: ***** Exception during [update:entity [<ShipEntity 0x1d0921f0>{"Pitviper Mk II (Bountyhunter)" position: (-19527.6, -2649.65, 256474) scanClass: CLASS_NEUTRAL status: STATUS_IN_FLIGHT}]] in [Universe update:] : NSInvalidArgumentException : WormholeEntity(instance) does not recognize primaryTarget *****
21:48:33.876 [exception]: ***** Exception during [update:entity [<ShipEntity 0x1d0921f0>{"Pitviper Mk II (Bountyhunter)" position: (-19527.6, -2649.65, 256474) scanClass: CLASS_NEUTRAL status: STATUS_IN_FLIGHT}]] in [Universe update:] : 

etc.pp. with different ships...
Here is the complete log from my box account. 10 MB.

Oolite development version 1.81.0.6238-141128-056aa56 (x86-64 test release) under Windows 6.1.7601 Service Pack 1 64-bit with a radeon hd5450

[cim]

1.81.0.6238-141128-056aa56

I believe this one was fixed on either 28 November (but after that morning's build), 30 November or 6 December, depending on the exact cause, so you should be fine if you update your nightly build.

[another_commander]

You seem to be using a two-weeks old build, when there were some problems spotted with how wormholes were handled. Many of those cases were fixed in more recent builds. Can you try to upgrade to the latest nightly?

Edit: Ninja'd (again).