Oolite 1.80 crashing

[Hamishthecat]

Hi there,

Version 1.80 is crashing on a regular basis. It doesn't happen every time but more often than not.

I've checked the log file and the last entry is this error message:

16:34:24.793 [gnustep]: 2014-10-20 16:34:24.793 oolite[3240] src/Core/Entities/PlayerEntity.m:604 Assertion failed in PlayerEntity(instance), method commanderDataDictionary. Cannot create commander data dictionary unless docked.

Please can anyone help? Is there anything that I can do to avoid getting the error?

Thanks, Dave

[cim]

That seems like it's trying to save the game while you aren't docked.

So ...
- does the crash happen when you try to save?
- do you have autosave turned on? If so, does it still crash when you turn it off?
- could we have a full Latest.log file from a crash?

[Hamishthecat]

Hi Cim,

Thanks for the info.

The crash only happens during flight - when i'm docked, and saving the game, it's fine.

Autosave is switched off so it's not that.

Next time it happens, I'll paste a copy of the Latest log here.

Thanks, Dave

[another_commander]

I think some OXP is trying to read the player ship's price while not docked. I can trigger this assert just by executing the below command on the debug console after launching with a no-OXPs Jameson from Lave:

Code: Select all

PS.price

This is true also for current trunk.

Edit: Issue #115 has been opened on github to track this. Also, moving to Testing and Bug Reports.

[another_commander]

Just an update on this problem: After some investigation, it looks like this might be an exception handling issue present in the 64-bit Windows version of the game. @Hamishthecat: I imagine you are on Win64? If so, can you try the 32-bit version of the game and see if this still causes crashes or not?

A potential fix is in the works for the 64-bit version and may go in for tonight's nightly build.

[Hamishthecat]

Hi Another Commander,

Yes, I am on Win7 64bit.

I'll try the 32 bit version and report back.

[another_commander]

I believe the problem should now be fixed also for 64-bit. I have uploaded a new gnustep-base-1_20.dll on github, which can be downloaded from this link: https://github.com/OoliteProject/oolite ... l?raw=true .

@Hamishthecat: Can you please try copying this dll in your 64-bit oolite.app folder (backup the original one first) and try to play with it and see if it solves the problem for you?

[Hamishthecat]

I've not tried the fix yet as the problem hasn't occured again. I have removed a few expansion packs so maybe that's cured it. The ones i've removed are:

Gates
Ring Racer
Torus Stations
Retro Rockets
Coluber HUD CH01
Skilled NPCs
Start Choices
Carriers
Contractor MkII
Copperhead Mk II
Cougar ST
Green Gecko XL
NeoCaduceus
Simon B's Favorites
SuperSidewinder

so maybe one of those was causing it - or maybe the sheer number of expansion packs i'd installed!

If the problem occurs again then i'll try the fix.

[Diziet Sma]

Please do consider doing the testing.. OXPs should not be able to crash Oolite.. so it would be good to identify it, if one is.. you can use the binary testing method to speed things up, since you have a lot of OXPs installed.

[Hamishthecat]

I've now played the 32bit version, added the dll to the 64 bit version and haven't had the problem re-occur. Strange.

[another_commander]

I've now played the 32bit version, added the dll to the 64 bit version and haven't had the problem re-occur. Strange.

I'd choose to call that fixed. The 32-bit version was handling exceptions in a way that did not crash the game and the new dll fixes that handling also for the 64-bit version. Thanks for reporting the problem and pointing us to a way to reproduce it and be able to fix it.

[toto d merchant]

[quote="Diziet Sma"]Please do consider doing the testing.. OXPs should not be able to crash Oolite..
oxps do crash Oolite, they seem to overload my graphics card.

[another_commander]

oxps do crash Oolite, they seem to overload my graphics card.

Dizzy is right. OXPs should not crash Oolite and if that happens, we need to investigate why. Next time it crashes, can you please post the full Latest.log and also - if present inside oolite.app - stderr.txt?