Trunk nightly

[Cody]

I wonder if this is because of the equipment.plist you had...

Yep, that was it... again! Saves are now working fine, it seems. Guess I'll have to remove that plist in future.
Shame though, as I like my kit in a certain order. Oh yeah... I don't much like damaged kit jumping to the top of the list.

[Cody]

Another aegis oddity - a Python (appropriately named Goodnight) launched from the Torus at Quandixe and headed more or less straight for the planet.
I followed it down 'til my altitude was in the red - then it blew!

[Diziet Sma]

I've noticed today that the Expansion Manager doesn't handle internet dropouts during a download very gracefully..

My internet (ADSL2+) is generally pretty good, but when the weather is bad, it gets lots of dropouts.. takes the modem anywhere from a few seconds to 2 minutes (or more) to re-establish a connection to the ISP. And dropouts can happen every 10-20 seconds if things are bad.. which can be absolute hell when downloading from sites that don't support resumable downloads.

(My best guess is that moisture is getting into the lines/equipment somewhere between me and the exchange.. after a couple of dry days, things improve.. although sometimes it can happen even after weeks of good weather.)

I've noticed that Oolite seems to be pretty good about small disconnects, but if the connection doesn't get re-established within 15-20 seconds, the download just hangs. If there's no progress for 1-2 minutes, I have to cancel and restart the download again to get things going again, even though the modem has already re-established the connection.

If Oolite and the wiki repository don't/can't be made to support resumable downloads, then it may be necessary to have some kind of time-out instituted, so that Oolite doesn't just hang, waiting forever for the download to complete.

[cim]

There's an "on error" handler in the URL downloading library, which we're using. If that's not picking up disconnects properly there's probably nothing we can do about it. (If it does actually pick up the disconnect - have you tried waiting 5-10 minutes to see what it does? - then it should be possible to resume the download from that point.)

You might be best downloading the larger OXZs directly.

[Diziet Sma]

Fair enough...

have you tried waiting 5-10 minutes to see what it does? - then it should be possible to resume the download from that point

I'll keep that in mind to test..

[Diziet Sma]

have you tried waiting 5-10 minutes to see what it does? - then it should be possible to resume the download from that point

No joy.. it still just hangs forever. Even though, going by my phone's connection, the internet had dropped out and reconnected a couple of times in the 10 minutes I waited.. (tested twice)

There's nothing in the API of the downloading library for checking/monitoring connectivity?

You might be best downloading the larger OXZs directly.

Well, that pretty much leaves me with the same problem..

But mostly, I was hoping there'd be some way for Oolite to recognise there was a problem, and abort, if resuming wasn't possible.

[spara]

I spotted a small error in roles in shipdata.plist. Cobramk1 has a role "escort-light". Should be just "escort".

[spara]

I'm testing the new extra column in the market screen with this script:

Code: Select all

this.name = "market_test";

this.startUp = function() {
	for (var i in system.mainStation.market) {
		manifest.setShortComment(i, "foo");
	}
}

As a result the Kiota stations that I have installed get their markets nullified with 0.0 prices and "-" units. Is this because they use the old commodities.plist definitions or is it a bug?

[Norby]

If I have an error in my js then the current trunk print a line into the log:

Code: Select all

11:27:13.667 [script.javaScript.exception.undeclaredVar] ReportJSError (OOJavaScriptEngine.m:203): ***** JavaScript exception (numerichudv3 3.27): ReferenceError: assignment to undeclared variable a

But 1.80 print two lines and the second tell the exact line number:

Code: Select all

11:25:55.103 [script.javaScript.exception.undeclaredVar] ReportJSError (OOJavaScriptEngine.m:203): ***** JavaScript exception (numerichudv3 3.27): ReferenceError: assignment to undeclared variable a
11:25:55.103 [script.javaScript.exception.undeclaredVar] ReportJSError (OOJavaScriptEngine.m:214):       /home/norbi/.Oolite/AddOns/NumericHUD_3.27.oxz/Scripts/numerichudv3.js, line 10.

Please put back this useful feature.

[Tricky]

Use jslint and jshint to help validate you JS code.

[Wildeblood]

Is this because they use the old commodities.plist definitions or is it a bug?

You discount the possibility of a mistake on your part?

[spara]

Is this because they use the old commodities.plist definitions or is it a bug?

You discount the possibility of a mistake on your part?

That's always possible and I might have understood something totally wrong, although I doubt it this time. Kiotas and and the script above are all I have in my test setting.

[Wildeblood]

I think you were thinking of a prop in object loop?

Code: Select all

this.name = "market_test";

this.startUp = function() {
	for (var i in system.mainStation.market) {
		manifest.setShortComment(i, "foo");
	}
}

Code: Select all

this.name = "market_test";

this.startUp = function() {
	for (prop in system.mainStation.market) {
            if (prop != "list") {
		manifest.setShortComment(prop, "foo");
            }
	}
}

[spara]

Yes, I was thinking about properties in the loop but is there really any difference here? The result seems to be same in both cases. Including nulled Kiota market.

[cim]

Is this because they use the old commodities.plist definitions

Specifically, because they only use the old definitions. The old and new definitions use completely different shipdata keys so you can safely put both in the same file and have it work in 1.80 and 1.81 - for now, though, 1.81 makes no attempt to parse the old format and set prices and quantities from it.

(If we get near to 1.82 release and take up of the new definitions remains minimal, then that might need rethinking, but there aren't that many station-adding OXPs out there, so I'm hoping the community will update them before then)

I'll sort out the escort role and investigate the JS error messages later - at the moment I've got a giant mess which doesn't even compile in my Oolite folder, as I try to make planetinfo.plist static, so it's not a good time to be working on other stuff and forgetting where I've got up to with that.