Main Station Docking Issue

[CaptSolo]

Last night arrived at Dioris main (chart 5) and, per my usual custom, requested docking clearance, and was placed in the queue. Then I noticed some laser fire so went to investigate. A Black Monk Gunship was after some poor sod in a Boa, but when I targeted the gunship she was clean. The Boa however was fugitive and the cops were after her as well. This caused station control to declare an emergency and rescind my docking request. After the Boa was destroyed and order was restored, I requested docking clearance again, and once more was placed in a queue... seventh in line. Unfortunately, none of the craft in the aegis made any motion toward the docking bay. This went on long enough for me to realize there was a problem. My docking computer had been damaged so I couldn't fast dock. So, I had to head away toward the sun for fuel and my next stop. Is it possible the station AI did not give the all clear after the emergency was over? The log was clean.

[Neelix]

I noticed something similar a while back in the Pandora version (which was then based on 1.77.1)

Here's how I described it to smivs on IRC:

<Neelix> I've run into an odd situation waiting for docking clearance at Maises...
<smivs>
<smivs> What's the problem?
<Neelix> Playing Oolite on my Pandora... I was called to dinner just as I arrived at the station, so I set the Docking computer to auto-pilot and put the pandora aside while I ate. When I finished eating I was still in a holding pattern.
<smivs> That's odd! Perhaps it was just busy there or something.
<Neelix> I noticed that in the meantime there had been some kind of fight in the Aegis, so I cancelled the auto-dock and went around collecting debris for a while, then came back and requested docking clearance again with Shift-L - I was given position 13 in the queue, so settled down to wait and watch... since then as near I can tell there have been no ships in or out and there is a massive cloud of ships waiting to dock

I was able to insta-dock ok with Shift-C but when I came back out there had been no change except that there were even more ships waiting to dock.


- Neelix

[cim]

It seems to happen when one of the ships on approach before the emergency gets destroyed during it - perhaps at other times too. I'll see if there's a straightforward fix to it: the docking queue code is rather fragile, and if it's not an easy fix I'm likely to add more bugs while fixing this one ... but we'll see.

[Neelix]

It seems to happen when one of the ships on approach before the emergency gets destroyed during it - perhaps at other times too. I'll see if there's a straightforward fix to it: the docking queue code is rather fragile, and if it's not an easy fix I'm likely to add more bugs while fixing this one ... but we'll see.

This may seem like a long shot but I've noticed that shipTargetLost event doesn't seem to be firing when a cargo Escape pod is destroyed. (e.g. by colliding with it instead of scooping it) Could this be related?

-Neelix

[cim]

The docking queue bug should be fixed now - and safely.

This may seem like a long shot but I've noticed that shipTargetLost event doesn't seem to be firing when a Escape pod is destroyed.

I can't duplicate this - the event seems to fire normally here.

[CaptSolo]

I should have added the version number I'm running: 1.79.0.5764-140525-f299e5e

[Neelix]

This may seem like a long shot but I've noticed that shipTargetLost event doesn't seem to be firing when a Escape pod is destroyed.

I can't duplicate this - the event seems to fire normally here.

I think it fires for the player ship but not for non-player ships. (like the escape pod beacon) I added code to the escape pod beacon script to put a message on the console any time the this.shipTargetLost handler triggers. It triggers twice when a pod is scooped - once when scooping starts, (at which point the handler restores the target) and then again once the scooping is completed. (at which point the beacon is removed) If the pod is destroyed though there is no message at all.
I have the LogEvents OXP installed so I was able to confirm that the event was received by the player ship though.

- Neelix

[cim]

This is to do with the NPC AI - it only notes a lost target if it's currently in an AI mode which cares about its target. That would probably be possible to fix by adding to the other modes, but it's too late to go in for 1.80, I think.

[Diziet Sma]

The to-do list for 1.80.1 grows steadily longer..