[UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Discussion and information relevant to creating special missions, new ships, skins etc.

Moderators: winston, another_commander

User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by cim »

Hmm... I think I know what's going on there. The pod still exists - it's in your hold - but the reference isn't being changed in the same way as it would be in 1.76. That probably means the beacon never gets removed. I'll have a look and see if there's a way around this. (Well, in 1.77 there will be a better way to implement the ECL, but that's not important right now)
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by Eric Walch »

cim wrote:
The pod still exists - it's in your hold - but the reference isn't being changed in the same way as it would be in 1.76. That probably means the beacon never gets removed.
When you track the pod, you must always check its status. As soon it is "STATUS_IN_HOLD" it should be removed, and probably re-installed as soon as the player dumps the pot and it becomes "STATUS_IN_FLIGHT" again. :)
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by cim »

The problem seems to be that shipTargetLost isn't always firing when it should. I'll try to fix for tonight's nightly.

EDIT: should be fixed in r5591. shipTargetLost should do the same thing as it did in 1.76, now, but this will need some more testing.
User avatar
Solonar
Deadly
Deadly
Posts: 174
Joined: Sun Dec 04, 2011 4:04 am
Location: Galaxy 2 - Space Truckin

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by Solonar »

Getting warmer. While using trunk 5592 I had an encounter with the destruction of an Osirus Ferry that ejected numerous escape pods. As I scooped pods, some of the beacons were removed correctly and some were not, continuing to be detected on the ACS and failing to give the signal lost message even after they no longer existed. This time though after docking and then launching from the main station all of the ghost beacons were removed and no longer detectable.
Image

SolarTech proudly presents the Plasma Turret Regulator Device Apparatus, aka the Turret Toggler
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by cim »

Hmm. If there were lots of dots on the scanner, that's quite possible. I'll have another look at it.
User avatar
Solonar
Deadly
Deadly
Posts: 174
Joined: Sun Dec 04, 2011 4:04 am
Location: Galaxy 2 - Space Truckin

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by Solonar »

I reported a similar issue with Thargoid's Cargo Spotter. Maybe they are a related issue?

Reference Cargo Spotter here...

https://bb.oolite.space/viewtopic.php?f= ... 90#p191054
Image

SolarTech proudly presents the Plasma Turret Regulator Device Apparatus, aka the Turret Toggler
User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by Thargoid »

It's a very similar issue - in my case the script may be fooled slight as the cargo still technically exists, but it's now in the ship hold as Cim mentioned above (but won't be picked up by the scan for cargo, hence why turning off and on again cures it).

That's quite easily dealt with (as Eric mentioned above - just an in-flight check being needed) - I've PM'd you a link to try a new beta of cargo spotter with the relevant code tweak to confirm it fixes that issue. If so then I'll update the main beta release with it.
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by cim »

Same root cause - essentially it wasn't possible to keep track of a cargo item once it had gone into a hold, and now it is. I think the remaining issues probably need to be fixed in the OXPs - r5593 has an "isInSpace" property added, which should be checked instead of "isValid"
User avatar
Solonar
Deadly
Deadly
Posts: 174
Joined: Sun Dec 04, 2011 4:04 am
Location: Galaxy 2 - Space Truckin

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by Solonar »

I may have narrowed down the problem some. I am using trunk 5595 and had another encounter with the destruction of an Osiris Ferry. It may have something to do with the GalTech Escape Pods OXP. This time while paying attention to the different escape pods I observed that all of the original core escape pods were having their beacons removed correctly but all the GalTech escape pods were not. I removed the GalTech Escape Pods OXP so that only the core escape pods appear and I have not yet had issues with the ghost escape pod beacons.
Image

SolarTech proudly presents the Plasma Turret Regulator Device Apparatus, aka the Turret Toggler
User avatar
Solonar
Deadly
Deadly
Posts: 174
Joined: Sun Dec 04, 2011 4:04 am
Location: Galaxy 2 - Space Truckin

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by Solonar »

Nevermind that. I started having instances of ghost beacons the following day in a new session.
Image

SolarTech proudly presents the Plasma Turret Regulator Device Apparatus, aka the Turret Toggler
User avatar
ozhank
Competent
Competent
Posts: 56
Joined: Fri Sep 14, 2012 3:17 am
Location: The other side of the black stump

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by ozhank »

At last I am not alone. I have just updated to 1.77 on Ubuntu, using Escape Pod Locator to apprehend marks if they manage to escape from assassin or pick up a pirate, and am also getting ghost locations. Nothing on scanner, just fly to advanced compass icon as swings from green to red but nothing is present. Happens randomly in space.
"Blessed are the cracked, for they let the light shine in". Spike Milligan

Debian 9.* XFCE4 on Toshiba Laptop
User avatar
Captain Patrick
Competent
Competent
Posts: 42
Joined: Tue Jun 22, 2010 6:14 am

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by Captain Patrick »

I can report the same "ghost beacons" problem for Oolite 1.77.1 for the Mac.
User avatar
Diziet Sma
---- E L I T E ----
---- E L I T E ----
Posts: 6312
Joined: Mon Apr 06, 2009 12:20 pm
Location: Aboard the Pitviper S.E. "Blackwidow"

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by Diziet Sma »

Ghosts that refuse to die, oh my... :lol:

I must admit, this has been one quite persistent bug.. it's survived several attempts to eradicate it..

Although, as cim points out, the bugs in core have been fixed.. the rest needs to be sorted in the OXP itself.. it's been about 3 months since Capt. Murphy last checked in here.
cim wrote:
I think the remaining issues probably need to be fixed in the OXPs - r5593 has an "isInSpace" property added, which should be checked instead of "isValid"
Most games have some sort of paddling-pool-and-water-wings beginning to ease you in: Oolite takes the rather more Darwinian approach of heaving you straight into the ocean, often with a brick or two in your pockets for luck. ~ Disembodied
User avatar
Diziet Sma
---- E L I T E ----
---- E L I T E ----
Posts: 6312
Joined: Mon Apr 06, 2009 12:20 pm
Location: Aboard the Pitviper S.E. "Blackwidow"

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by Diziet Sma »

cim wrote:
I think the remaining issues probably need to be fixed in the OXPs - r5593 has an "isInSpace" property added, which should be checked instead of "isValid"
I've made the suggested change in ecl_escape_pod_beacon.js and escapePodLocator.js, and put the new versions in a zip file for testing.

To use, download the zip and follow the included instructions. Let me know if the fixes do or don't work for you, please.

Download Link
Most games have some sort of paddling-pool-and-water-wings beginning to ease you in: Oolite takes the rather more Darwinian approach of heaving you straight into the ocean, often with a brick or two in your pockets for luck. ~ Disembodied
User avatar
Diziet Sma
---- E L I T E ----
---- E L I T E ----
Posts: 6312
Joined: Mon Apr 06, 2009 12:20 pm
Location: Aboard the Pitviper S.E. "Blackwidow"

Re: [UPDATED RELEASE] - Escape Pod Locator v1.4.1 (05/06/12)

Post by Diziet Sma »

<sigh> I've had one report already, via the Pandora forum, that the patch isn't working.. still getting ghost beacons. :( :x
Most games have some sort of paddling-pool-and-water-wings beginning to ease you in: Oolite takes the rather more Darwinian approach of heaving you straight into the ocean, often with a brick or two in your pockets for luck. ~ Disembodied
Post Reply