Diziet Sma wrote:cim wrote:Source code gives Thargoid ships a scan range of 50km, compared with human 25.6km (due to technical issues in Oolite, they don't currently have a 50km scan range, but I believe they're supposed to).
Ummm.. would this "technical issue" be the now-solved lack of double-precision coordinates?
No, it wouldn't. Single-precision coordinates are adequate up to around 1000km and are the move to double-precision is about expanding the scale possible in the system so that
we can move to realistically-sized systems for Oolite II: Frooontier you don't get noticeable imprecision while sun-skimming or at some mission OXP's deep-space station.
Note that that post was written several months before I joined the dev team, and before I'd looked at the scanning code in great detail - I knew they didn't have a 50km scan range despite what shipdata said, but I hadn't looked in to why. There are essentially two answers to that question:
1) The code for scanning sometimes uses the shipdata scan range, and sometimes uses the hard-coded 25.6km constant. Occasionally it uses both in the same function. How far a Thargoid can actually see is unclear.
2) Scanning a larger volume is potentially less efficient. In practice most scans use the fast 'checkScanner' internal function, which only returns 16 objects within scanner range (32 in 1.79 or later). Part of how the function is fast is that it doesn't return the 16 or 32 closest objects; in busy space the objects it returns may even end up all on one side of the ship. So long as there are generally fewer objects really within scanner range than the maximum check, the oddities aren't too noticeable.
The first I probably should fix. The second ... I suspect isn't going to be that much of a problem for a 50km scan range on Thargoids, but might well be on other ships.