Liners OXP

[pagroove]

Nice Smivs! I didn't know about a bug in the Emerald Dock. Docking worked on my computer.

[Commander McLane]

Nice Smivs! I didn't know about a bug in the Emerald Dock. Docking worked on my computer.

The bug was probably mainly cosmetic.

[Thargoid]

Completely cosmetic - somehow the dock had been shifted into the model 100m or so. Hence whilst you could dock, you could also see stars going past between its edge and the front of the liner.

Didn't exactly look good

[Smivs]

Docking worked on my computer.

Ha, yes, it all worked OK...Just didn't look good. Thargoid gave me the heads up a few days ago, and when I looked it was definitely not right! The strange thing is nobody noticed it sooner.

[Commander McLane]

Docking worked on my computer.

Ha, yes, it all worked OK...Just didn't look good. Thargoid gave me the heads up a few days ago, and when I looked it was definitely not right! The strange thing is nobody noticed it sooner.

Well, the fact of the matter is that I never docked with an Emerald, and you don't see it from the distance.

I just tried it for the first time after I posted, and indeed, I could see the stars.

[Mauiby de Fug]

Code: Select all

  16:54:41.711 [shader.compile.failure]: ***** ERROR: GLSL vertex shader compilation failed for liners_tigershark.vertex:
>>>>> GLSL log:
0:0(9): preprocessor error: Redefinition of macro OO_TANGENT_ATTR



16:54:41.711 [shader.load.failed]: ***** ERROR: Could not build shader liners_tigershark.vertex/liners_tigershark.fragment.

What a familiar error message... Same fix as always I assume - delete the offending line - which in this case is line 1 in liners_tigershark.vertex

[JazHaz]

Code: Select all

  16:54:41.711 [shader.compile.failure]: ***** ERROR: GLSL vertex shader compilation failed for liners_tigershark.vertex:
>>>>> GLSL log:
0:0(9): preprocessor error: Redefinition of macro OO_TANGENT_ATTR



16:54:41.711 [shader.load.failed]: ***** ERROR: Could not build shader liners_tigershark.vertex/liners_tigershark.fragment.

What a familiar error message... Same fix as always I assume - delete the offending line - which in this case is line 1 in liners_tigershark.vertex

Hmmm, I wonder if the preprocessor error is caused by your graphics card not being very good with OpenGL?

[another_commander]

No, it's a shader code error, one I'll never forgive myself for. I never thought this mistake would be so widely spread across OXPs.

[Cody]

No, it's a shader code error, one I'll never forgive myself for.

<hands the Admiral a pistol, salutes, turns and leaves the room>

[JazHaz]

No, it's a shader code error, one I'll never forgive myself for. I never thought this mistake would be so widely spread across OXPs.

How comes it doesn't get seen by everyone though?

[another_commander]

How comes it doesn't get seen by everyone though?

No idea. I would dare say that drivers that don't report the error are the ones likely to be considered buggy. Believe me, it is an error.

[Smivs]

The mug person responsible for hosting this OXP hasn't got a clue about this clever shadery stuff so could someone confirm that to fix this all I need to do is delete line 1

Code: Select all

#define OO_TANGENT_ATTR 1  // <---- Define OO_TANGENT_ATTR to 1 so that Oolite gives correct tangent data to shader.

from the liners_tigershark.vertex file?

[Svengali]

Get rid of the whole head part

Code: Select all

#define OO_TANGENT_ATTR 1
#ifdef OO_TANGENT_ATTR
attribute vec3 tangent;
#else
const vec3 tangent = vec3(1.0, 0.0, 0.0);
#endif

and simply use

Code: Select all

attribute vec3 tangent;

[Smivs]

Thank you

<heads off to the OXP workshop...>

[Smivs]

<...returns!>
v1.6 is now available with the fix suggested above. Hopefully this will clear-up this problem for good. Thanks again, Svengali.