Errors and warnings when building 1.77 trunk

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Re: Errors and warnings when building 1.77 trunk

Post by Thargoid »

Gimi wrote:
r5455 seems to have sorted it out.
Indeed - same here :)

Although it has generated a huge log file about openGL state rendering, presumably due to Ahruman's commit 5451 perhaps.
Top
User avatar
Gimi
---- E L I T E ----
---- E L I T E ----
Posts: 2073
Joined: Tue Aug 29, 2006 5:02 pm
Location: Norway

Re: Errors and warnings when building 1.77 trunk

Post by Gimi »

Get the following warning when building r5472.

Code: Select all

 Compiling file src/Core/Entities/OOFlasherEntity.m ...
src/Core/Entities/OOFlasherEntity.m:182: warning: incomplete implementation of class 'OOFlasherEntity'
src/Core/Entities/OOFlasherEntity.m:182: warning: method definition for '-drawSubEntityImmediate:translucent:' not found
src/Core/Entities/OOFlasherEntity.m:182: warning: class 'OOFlasherEntity' does not fully implement the 'OOSubEntity' protocol
 Compiling file src/Core/Entities/OOExhaustPlumeEntity.m ...
"A brilliant game of blasting and trading... Truly a mega-game... The game of a lifetime."
(Gold Medal Award, Zzap!64 May 1985).
Top
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6682
Joined: Wed Feb 28, 2007 7:54 am

Re: Errors and warnings when building 1.77 trunk

Post by another_commander »

Gimi wrote:
Get the following warning when building r5472.

Code: Select all

 Compiling file src/Core/Entities/OOFlasherEntity.m ...
src/Core/Entities/OOFlasherEntity.m:182: warning: incomplete implementation of class 'OOFlasherEntity'
src/Core/Entities/OOFlasherEntity.m:182: warning: method definition for '-drawSubEntityImmediate:translucent:' not found
src/Core/Entities/OOFlasherEntity.m:182: warning: class 'OOFlasherEntity' does not fully implement the 'OOSubEntity' protocol
 Compiling file src/Core/Entities/OOExhaustPlumeEntity.m ...
Should be fixed in r5473.
Top
User avatar
Gimi
---- E L I T E ----
---- E L I T E ----
Posts: 2073
Joined: Tue Aug 29, 2006 5:02 pm
Location: Norway

Re: Errors and warnings when building 1.77 trunk

Post by Gimi »

another_commander wrote:
Should be fixed in r5473.
Thank you. No warnings when building r5473.
"A brilliant game of blasting and trading... Truly a mega-game... The game of a lifetime."
(Gold Medal Award, Zzap!64 May 1985).
Top
User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Re: Errors and warnings when building 1.77 trunk

Post by Thargoid »

I'm getting these when building 5487 after a make clean (editted low-lights):

Code: Select all

Compiling file src/Core/Entities/PlayerEntityContracts.m ...
src/Core/Entities/PlayerEntityContracts.m: In function '-[PlayerEntity(Contracts) pickFromGuiContractsScreen]':
src/Core/Entities/PlayerEntityContracts.m:1165: warning: 'StationEntity' may not respond to '-localPassengers'
src/Core/Entities/PlayerEntityContracts.m:1165: warning: (Messages without a matching method signature
src/Core/Entities/PlayerEntityContracts.m:1165: warning: will be assumed to return 'id' and accept
src/Core/Entities/PlayerEntityContracts.m:1165: warning: '...' as arguments.)
src/Core/Entities/PlayerEntityContracts.m:1166: warning: 'StationEntity' may not respond to '-localContracts'
src/Core/Entities/PlayerEntityContracts.m: In function '-[PlayerEntity(Contracts) highlightSystemFromGuiContractsScreen]':
src/Core/Entities/PlayerEntityContracts.m:1251: warning: 'StationEntity' may not respond to '-localPassengers'
src/Core/Entities/PlayerEntityContracts.m:1252: warning: 'StationEntity' may not respond to '-localContracts'
 Compiling file src/Core/Entities/PlayerEntityControls.m ...
src/Core/Entities/PlayerEntityControls.m:109: warning: 'queryPressed' defined but not used
src/Core/Entities/PlayerEntityControls.m:113: warning: 'switching_market_screens' defined but not used
src/Core/Entities/PlayerEntityControls.m:122: warning: 'oldSelection' defined but not used


Compiling file src/Core/Scripting/OOJSVisualEffect.m ...
src/Core/Scripting/OOJSVisualEffect.m: In function 'VisualEffectGetProperty':
src/Core/Scripting/OOJSVisualEffect.m:275: warning: 'OOVisualEffectEntity' may not respond to '-subEntitiesForScript'
src/Core/Scripting/OOJSVisualEffect.m:275: warning: (Messages without a matching method signature
src/Core/Scripting/OOJSVisualEffect.m:275: warning: will be assumed to return 'id' and accept
src/Core/Scripting/OOJSVisualEffect.m:275: warning: '...' as arguments.)
src/Core/Scripting/OOJSVisualEffect.m: In function 'VisualEffectRestoreSubEntities':
src/Core/Scripting/OOJSVisualEffect.m:712: warning: 'OOVisualEffectEntity' may not respond to '-subEntitiesForScript'
src/Core/Scripting/OOJSVisualEffect.m:717: warning: 'OOVisualEffectEntity' may not respond to '-subEntitiesForScript'
src/Core/Scripting/OOJSVisualEffect.m:717: warning: 'OOVisualEffectEntity' may not respond to '-subEntitiesForScript'


 Compiling file src/Core/Universe.m ...
src/Core/Universe.m:7697: warning: 'estimatedTimeForJourney' defined but not used
Now trying 5488 (without pre-clean), but still getting

Code: Select all

make -f GNUmakefile SNAPSHOT_BUILD=yes VERSION_STRING=1.77.0.5488 debug=no
make[1]: Entering directory `/c/Oolite/trunk'
Making all for objc_program oolite...
 Compiling file src/Core/Entities/PlayerEntity.m ...
 Compiling file src/Core/Entities/PlayerEntityContracts.m ...
 Compiling file src/Core/Entities/PlayerEntityControls.m ...
src/Core/Entities/PlayerEntityControls.m:109: warning: 'queryPressed' defined but not used
src/Core/Entities/PlayerEntityControls.m:113: warning: 'switching_market_screens' defined but not used
src/Core/Entities/PlayerEntityControls.m:122: warning: 'oldSelection' defined but not used
 Compiling file src/Core/Entities/PlayerEntityLoadSave.m ...
 Compiling file src/Core/Scripting/OOJSManifest.m ...
 Compiling file src/Core/Scripting/OOJSPlayer.m ...
 Compiling file src/Core/Scripting/OOJSPlayerShip.m ...
 Compiling file src/Core/Universe.m ...
src/Core/Universe.m:7697: warning: 'estimatedTimeForJourney' defined but not used
 Linking objc_program oolite ...
/OOgstep/System/Library/Makefiles/mkinstalldirs oolite.app
/OOgstep/System/Library/Makefiles/mkinstalldirs oolite.app/Resources
Editted to add - 5489 builds fine :D[/color]
Top
User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Re: Errors and warnings when building 1.77 trunk

Post by Thargoid »

And now 5492 is playing silly buggers:

Code: Select all

 Compiling file src/Core/Universe.m ...
src/Core/Universe.m:7696:1: warning: "/*" within comment
src/Core/Universe.m: In function '-[Universe passengersForLocalSystemAtTime:]':
src/Core/Universe.m:7802: warning: implicit declaration of function 'estimatedTimeForJourney'
src/Core/Universe.m: At top level:
src/Core/Universe.m:7852: error: expected identifier or '(' before '/' token
src/Core/Universe.m:10690: warning: incomplete implementation of class 'Universe'
src/Core/Universe.m:10690: warning: method definition for '-timeDescription:' not found
make[4]: *** [obj.win.spk/oolite.obj/Universe.m.o] Error 1
make[3]: *** [internal-objc_program-all_] Error 2
make[2]: *** [oolite.all.objc-program.variables] Error 2
make[1]: *** [internal-all] Error 2
make[1]: Leaving directory `/c/Oolite/trunk'
make: *** [release-snapshot] Error 2
Time for bed said Zebedee...[/color]
Top
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: Errors and warnings when building 1.77 trunk

Post by cim »

Thanks. Fixed in 5493.
Top
User avatar
Gimi
---- E L I T E ----
---- E L I T E ----
Posts: 2073
Joined: Tue Aug 29, 2006 5:02 pm
Location: Norway

Re: Errors and warnings when building 1.77 trunk

Post by Gimi »

Warnings when building r5569 (New environment)

Code: Select all

 Compiling file src/Core/Debug/OOJSConsole.m ...
src/Core/Debug/OOJSConsole.m: In function 'ConsoleIsExecutableJavaScript':
src/Core/Debug/OOJSConsole.m:819:11: warning: variable 'result' set but not used
 [-Wunused-but-set-variable]
 Compiling file src/Core/Entities/DockEntity.m ...

Code: Select all

 Compiling file src/Core/Scripting/OOJSShip.m ...
src/Core/Scripting/OOJSShip.m: In function 'ShipDealEnergyDamage':
src/Core/Scripting/OOJSShip.m:1661:7: warning: variable 'gotVBias' set but not u
sed [-Wunused-but-set-variable]
src/Core/Scripting/OOJSShip.m:1660:7: warning: variable 'gotRange' set but not u
sed [-Wunused-but-set-variable]
src/Core/Scripting/OOJSShip.m:1659:7: warning: variable 'gotDamage' set but not
used [-Wunused-but-set-variable]
 Compiling file src/Core/Scripting/OOJSShipGroup.m ...
"A brilliant game of blasting and trading... Truly a mega-game... The game of a lifetime."
(Gold Medal Award, Zzap!64 May 1985).
Top
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: Errors and warnings when building 1.77 trunk

Post by cim »

Code: Select all

 Compiling file src/Core/Debug/OOJSConsole.m ...
src/Core/Debug/OOJSConsole.m: In function 'ConsoleIsExecutableJavaScript':
src/Core/Debug/OOJSConsole.m:819:11: warning: variable 'result' set but not used
Possibly line 837 should probably be OOJS_RETURN_BOOL(result);, but it might just be that the result variable is superfluous. I don't know enough about the console to say for sure.

Code: Select all

 Compiling file src/Core/Scripting/OOJSShip.m ...
Fixed in r5572. Thanks.
Top
User avatar
Gimi
---- E L I T E ----
---- E L I T E ----
Posts: 2073
Joined: Tue Aug 29, 2006 5:02 pm
Location: Norway

Re: Errors and warnings when building 1.77 trunk

Post by Gimi »

cim wrote:
Fixed in r5572. Thanks.
Thanks are going in the wrong direction here.
Thanks ...
"A brilliant game of blasting and trading... Truly a mega-game... The game of a lifetime."
(Gold Medal Award, Zzap!64 May 1985).
Top
User avatar
Tricky
---- E L I T E ----
---- E L I T E ----
Posts: 821
Joined: Sun May 13, 2012 11:12 pm
Location: Bradford, UK. (Anarchic)

Re: Errors and warnings when building 1.77 trunk

Post by Tricky »

Warnings when building (Windows environment) r5675 (release-snapshot & release-deployment)...

Code: Select all

 Compiling file src/Core/Scripting/OOJSQuaternion.m ...
src/Core/Scripting/OOJSQuaternion.m: In function 'QuaternionStaticRandom':
src/Core/Scripting/OOJSQuaternion.m:864:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSQuaternion.m: In function 'QuaternionRotateZ':
src/Core/Scripting/OOJSQuaternion.m:728:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSQuaternion.m: In function 'QuaternionRotateY':
src/Core/Scripting/OOJSQuaternion.m:709:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSQuaternion.m: In function 'QuaternionRotateX':
src/Core/Scripting/OOJSQuaternion.m:690:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSQuaternion.m: In function 'QuaternionRotate':
src/Core/Scripting/OOJSQuaternion.m:671:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSQuaternion.m: In function 'QuaternionConjugate':
src/Core/Scripting/OOJSQuaternion.m:762:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSQuaternion.m: In function 'QuaternionNormalize':
src/Core/Scripting/OOJSQuaternion.m:745:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSQuaternion.m: In function 'QuaternionMultiply':
src/Core/Scripting/OOJSQuaternion.m:624:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]

Code: Select all

 Compiling file src/Core/Scripting/OOJSVector.m ...
src/Core/Scripting/OOJSVector.m: In function 'VectorStaticRandomDirection':
src/Core/Scripting/OOJSVector.m:1062:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSVector.m: In function 'VectorStaticRandomDirectionAndLength':
src/Core/Scripting/OOJSVector.m:1077:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSVector.m: In function 'VectorMultiply':
src/Core/Scripting/OOJSVector.m:711:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSVector.m: In function 'VectorFromCoordinateSystem':
src/Core/Scripting/OOJSVector.m:991:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSVector.m: In function 'VectorDirection':
src/Core/Scripting/OOJSVector.m:813:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSVector.m: In function 'VectorStaticRandom':
src/Core/Scripting/OOJSVector.m:1047:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSVector.m: In function 'VectorToCoordinateSystem':
src/Core/Scripting/OOJSVector.m:962:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSVector.m: In function 'VectorRotateBy':
src/Core/Scripting/OOJSVector.m:901:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSVector.m: In function 'VectorSubtract':
src/Core/Scripting/OOJSVector.m:654:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSVector.m: In function 'VectorAdd':
src/Core/Scripting/OOJSVector.m:636:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSVector.m: In function 'VectorStaticInterpolate':
src/Core/Scripting/OOJSVector.m:1026:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]
src/Core/Scripting/OOJSVector.m: In function 'VectorCross':
src/Core/Scripting/OOJSVector.m:772:2: warning: 'jsresult' may be used uninitialized in this function [-Wmaybe-uninitialized]

Code: Select all

 Compiling file src/SDL/OOSDLJoystickManager.m ...
src/SDL/OOSDLJoystickManager.m: In function '-[OOSDLJoystickManager init]':
src/SDL/OOSDLJoystickManager.m:55:9: warning: array subscript is above array bounds [-Warray-bounds]
I noticed this some time ago but forgot to get around to posting the log.
Top
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6682
Joined: Wed Feb 28, 2007 7:54 am

Re: Errors and warnings when building 1.77 trunk

Post by another_commander »

Tricky: It builds warningless here, both for test and deployment configurations. Also, the nightly build log states:
Nightly build Diagnostics wrote:
Build process diagnostics for r5675

The build process diagnostics log is empty.
I would recommend a clean re-build of everything.
Top
User avatar
Tricky
---- E L I T E ----
---- E L I T E ----
Posts: 821
Joined: Sun May 13, 2012 11:12 pm
Location: Bradford, UK. (Anarchic)

Re: Errors and warnings when building 1.77 trunk

Post by Tricky »

another_commander wrote:
Tricky: It builds warningless here, both for test and deployment configurations. Also, the nightly build log states:
Nightly build Diagnostics wrote:
Build process diagnostics for r5675

The build process diagnostics log is empty.
I would recommend a clean re-build of everything.
It was a clean re-build (which is why I saw it), plus I thought it might need a little bump. Looked at it myself and can't work out the joystick one. The others I have an idea (initialising jsresult to JSVAL_VOID) but leaving it for an official patch since ObjC isn't my field. Can parse it but don't program in it.
Top
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6682
Joined: Wed Feb 28, 2007 7:54 am

Re: Errors and warnings when building 1.77 trunk

Post by another_commander »

Tricky wrote:
It was a clean re-build (which is why I saw it), plus I thought it might need a little bump. Looked at it myself and can't work out the joystick one. The others I have an idea (initialising jsresult to JSVAL_VOID) but leaving it for an official patch since ObjC isn't my field. Can parse it but don't program in it.
The thing is, you should not have to do anything. The current code base compiles as-is on Windows (actually, on all three supported platforms) with 0 warnings and 0 errors. Something is probably wrong with your compiler setup, or you are possibly using a makefile setting/flag that may not be meant for the Windows build. If all else fails, maybe checking out the codebase afresh with svn could help.

Just to be sure, you are using the latest Dev Environment posted, the one with gcc 4.7.1, right?
Top
User avatar
Tricky
---- E L I T E ----
---- E L I T E ----
Posts: 821
Joined: Sun May 13, 2012 11:12 pm
Location: Bradford, UK. (Anarchic)

Re: Errors and warnings when building 1.77 trunk

Post by Tricky »

another_commander wrote:
Tricky wrote:
It was a clean re-build (which is why I saw it), plus I thought it might need a little bump. Looked at it myself and can't work out the joystick one. The others I have an idea (initialising jsresult to JSVAL_VOID) but leaving it for an official patch since ObjC isn't my field. Can parse it but don't program in it.
The thing is, you should not have to do anything. The current code base compiles as-is on Windows (actually, on all three supported platforms) with 0 warnings and 0 errors. Something is probably wrong with your compiler setup, or you are possibly using a makefile setting/flag that may not be meant for the Windows build. If all else fails, maybe checking out the codebase afresh with svn could help.

Just to be sure, you are using the latest Dev Environment posted, the one with gcc 4.7.1, right?
Ah! :oops:

It is the latest Dev Environment. Could be something with the files themselves, although the only thing I know I have changed is GNUmakefile. I'll do a fresh import from the svn codebase later tonight.
Top
Post Reply

Return to “Testing and Bug reports”