q-mine while cloaked in passive mode question.

[Fatleaf]

I installed a couple of custom sounds and installed them as such:

Download the two files here: https://www.box.com/s/l7fa8ju0g6n36r23b56j And place them in the folder: \Oolite\oolite.app\Resources\sounds folder

You will need to alter your sound file to recognise them. Like this.
\Oolite\oolite.app\Resources\Config\customsounsds

Line 44 "[cloaking-device-on]" = "cloakon.ogg";
Line 45 "[cloaking-device-off]" = "cloakoff.ogg";

The sounds work fine when the 0 (Zero) is pressed but when I fire the laser (which turns off the cloak) the cloakoff.ogg doesn't get played.

Is this meant to be this way? If so shouldn't the .ogg file play regardless of the manner of the cloak disengaging?

[another_commander]

Fixed in r5650. Same revision fixes a problem with the cloak-off message not being displayed when a missile was fired with passive cloak activated.

Open for discussion: at the moment, deploying a q-mine while cloaked in passive mode does NOT deactivate cloak. Do we want to consider this a bug as well?

[Fatleaf]

Fixed in r5650. Same revision fixes a problem with the cloak-off message not being displayed when a missile was fired with passive cloak activated.

Open for discussion: at the moment, deploying a q-mine while cloaked in passive mode does NOT deactivate cloak. Do we want to consider this a bug as well?

Great thanks. Topic changed to reflect the question.

But an interesting question. My initial thought is, yes! I see the cloak (besides just a big fat cheat) as a very delicate thing and is easily disrupted while in operation.

Even though you can still get shot and it remains active, which I would like to see changed to deactivating when you're shot, but that is another question

[Cody]

... at the moment, deploying a q-mine while cloaked in passive mode does NOT deactivate cloak. Do we want to consider this a bug as well?

Yes... I reckon anything deployed whilst cloaked should deactivate the cloak.

[another_commander]

OK, let's give it a try. I agree that it is at least weird if deploying q-mines does not deactivate the passive cloak, so this is fixed in r5651. Please test general cloak operation because this revision contains a generic overhaul of the cloak code, making it more consistent and easy to read and work with, hopefully not creating a total mess while at it.

If deactivation of the cloak when q-mines are deployed proves not to be a desirable fix later on, it is very easy to change it back. So feel free to test and advise.

[Cody]

So feel free to test and advise.

A license to kill, is that. I've not used the cloak (nor QCMs, for that matter) offensively for years... great fun!