Crash in 1.77: AsteroidStorm4.03 + thargoid_carrier2.0

[Bogatyr]

I encountere a crash upon jumping into Leesti with AsteroidStorm4.03, and after failing the mission so that the station was destroyed. With thargoid_carrier2.0, the game crashes on entry to the system.

Here's a save file one jump away from Leesti that shows the crash:

https://www.box.com/s/s0p4arjyennkj2uihf6z

I removed all OXPs except these two and the crash still occurs. It makes sense, thargoid_carrier is probably not checking for the possibility that the station does not exist.

CmdrLuke (Bogatyr)

[Eric Walch]

Thanks for the clear analysis of the problem.

It is probably this line in Thargoidcarrier were it goes wrong:

Code: Select all

var otherSystemStations = system.filteredEntities(this, $isOtherSystemStation, system.mainStation);

This line should return null itself and than the following line:

Code: Select all

if(otherSystemStations.length > 0)

should throw an error as null has no length.

Crashing itself is an Oolite bug. I'll check it tonight if system.filteredEntities could crash oolite with a null parameter.

[Commander McLane]

Thanks for the report and analyses. Fixed for the next version. In the meantime you can fix it yourself by inserting the line

Code: Select all

        if(!system.mainStation) return;

just in front of the first line quoted by Eric.

[Bogatyr]

Thanks for the report and analyses. Fixed for the next version. In the meantime you can fix it yourself by inserting the line

Code: Select all

        if(!system.mainStation) return;

just in front of the first line quoted by Eric.

Glad to help out. Thanks for the workaround, I could then jump into Leesti without crashing