Issue with Safe Docking OXP and Docking Clearance

[CaptSolo]

Moderator: This discussion split from the GalCop Rewards thread.

Hello PG, Love Safe Docking and GalCop Rewards. Decided to add these as I rarely use the docking computer. I have one observation which only occurs when I am placed in a queue: The Dockmaster states, "You have docked at this station without clearance. I can not award you any Reward Points."
If I cancel docking clearance when it's my turn and immediately ask for clearance again, then all is well.

I am using Oolite version 1.76.1.

[PhantorGorth]

Hello PG, Love Safe Docking and GalCop Rewards. Decided to add these as I rarely use the docking computer. I have one observation which only occurs when I am placed in a queue: The Dockmaster states, "You have docked at this station without clearance. I can not award you any Reward Points."
If I cancel docking clearance when it's my turn and immediately ask for clearance again, then all is well.

I am using Oolite version 1.76.1.

That's weird. Was there anything special about your setup or what you did?

I will give it a test and get back to you.

Phantor

[CaptSolo]

That's weird. Was there anything special about your setup or what you did?

I will give it a test and get back to you.

Phantor

When in a queue I park near the station but not in the lane between station and buoy. I watch the activity out my port view. That couldn't possibly be the cause, could it?

[Cody]

When in a queue I park near the station but not in the lane between station and buoy. I watch the activity out my port view. That couldn't possibly be the cause, could it?

Dodgy behaviour, is that... I'm not surprised you get no reward. I still think it's a shame that one can park-up, motionless... I wish the ship drifted slowly, as in strict mode.

[CaptSolo]

When in a queue I park near the station but not in the lane between station and buoy. I watch the activity out my port view. That couldn't possibly be the cause, could it?

Dodgy behaviour, is that... I'm not surprised you get no reward. I still think it's a shame that one can park-up, motionless... I wish the ship drifted slowly, as in strict mode.

I call it otherwise. GalCop Vipers like to play the chicken game but they find no sport with me.

[Cody]

Heh... Vipers get plenty of sport out of me. Mind you, I usually jump queues (I rarely use the DC).

[PhantorGorth]

When in a queue I park near the station but not in the lane between station and buoy. I watch the activity out my port view. That couldn't possibly be the cause, could it?

The code doesn't care about your position unless you auto-dock. When it comes to Docking Clearance in Safe Docking here are the various bits of code that does the job:

Code: Select all

this.reward_shipWillDockWithStation = function(transition, stateBackup)
{
  ...
  if ((player.ship.dockedStation.requiresDockingClearance) && (self.dockingClearance != "DOCKING_CLEARANCE_GRANTED") && (self.dockingClearance != "DOCKING_CLEARANCE_NOT_REQUIRED") && (self.dockingClearance != "DOCKING_CLEARANCE_EXTENDED") && (actual_points > 0))
  {
    str = expandDescription("[SafeDocking_No_Docking_Clearance]");
  }
  ...  //check is true if the player has returned too soon.
  if ((actual_points > 0) && ((check) || ((player.ship.dockedStation.requiresDockingClearance) && (self.dockingClearance != "DOCKING_CLEARANCE_GRANTED") && (self.dockingClearance != "DOCKING_CLEARANCE_NOT_REQUIRED") && (self.dockingClearance != "DOCKING_CLEARANCE_EXTENDED"))))
  {
    actual_points = 0;						
  }
  ...
}

this.playerRequestedDockingClearance = function(message)
{
  this.dockingClearance = message;
}

this.shipLaunchedFromStation = function(station)
{
  ...
  this.dockingClearance = null;
  ...
}

I can not see any reason for the issue from looking at the code. So it will have to be a proper test flight to sort this one.

[CaptSolo]

When in a queue I park near the station but not in the lane between station and buoy. I watch the activity out my port view. That couldn't possibly be the cause, could it?

The code doesn't care about your position...

Didn't think so, and confirmed just a minute ago. Thanks for your efforts, PG.

[PhantorGorth]

Well I can see what the issue is. I check only at request and if that is wait in the queue then it doesn't get updated when you are allowed to dock. I should be using the property of player.dockingClearanceStatus instead. Give me bit and I will fix this.

Thank you for your patience.

Phantor

PS my next post regarding Safe Docking will be in the correct thread for it. Could all future post regarding Safe Docking be made there unless it directly impacts on GalCop Rewards.

[Diziet Sma]

I still think it's a shame that one can park-up, motionless... I wish the ship drifted slowly, as in strict mode.

Unfortunately, coming to a complete halt is necessary to use Fuel Stations.. even 1 m/s of drift is enough to move you out of the fuelling zone before the tank is full. I recall how, a few years back, when you zeroed the joystick throttle, Oolite would impart about half a m/s of reverse thrust.. that was a real PITA for refuelling.

[Cody]

Ah well... I have no need of fuel stations. How do they work... do they magic the quirium into the ship somehow?

[Diziet Sma]

As they're his invention, you'd have to ask the Green One about that..

[Cody]

I'll spare the TMA the trouble, and consult the Wiki... ahh, I see!