Full screen resolutions

[Eric Walch]

yes, with those changes, it compiles okay.

EDIT: On testing, I also don't see any oddities with full screen settings.

(However, on my equipment screen I only see the first 3 rows of equipment. The non displayed equipment is there because I can use it. Must be recent bug in trunk, unrelated to the full screen settings.)

[Eric Walch]

Having problems building Oolite myself since this weekend, I grabbed the last Nighty r5396. But it crashed on my mac with snow leopard.

Code: Select all

Application Specific Information:
[dataCache.rebuild.explicitFlush]: Cache explicitly flushed with always-flush-cache preference. Rebuilding from scratch.
 

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   org.aegidian.oolite           	0x0000000100049dcd -[MyOpenGLView viewDidMoveToWindow] + 21
1   com.apple.AppKit              	0x00007fff86ac8d57 -[NSView _setWindow:] + 2047
2   com.apple.CoreFoundation      	0x00007fff80622d3e CFArrayApplyFunction + 222
3   com.apple.AppKit              	0x00007fff86ac8d45 -[NSView _setWindow:] + 2029
4   com.apple.AppKit              	0x00007fff86ad187a -[NSView addSubview:] + 375
5   com.apple.AppKit              	0x00007fff86af91e1 -[NSFrameView addSubview:] + 45
6   com.apple.AppKit              	0x00007fff86ad0b59 -[NSWindow setContentView:] + 273
7   com.apple.AppKit              	0x00007fff86b34e04 -[NSWindowTemplate nibInstantiate] + 1204
8   com.apple.AppKit              	0x00007fff86ab701b -[NSIBObjectData instantiateObject:] + 259
9   com.apple.AppKit              	0x00007fff86ab6406 -[NSIBObjectData nibInstantiateWithOwner:topLevelObjects:] + 336
10  com.apple.AppKit              	0x00007fff86ab4a91 loadNib + 226
11  com.apple.AppKit              	0x00007fff86ab3fa1 +[NSBundle(NSNibLoading) _loadNibFile:nameTable:withZone:ownerBundle:] + 248
12  com.apple.AppKit              	0x00007fff86ab3dd9 +[NSBundle(NSNibLoading) loadNibNamed:owner:] + 326
13  com.apple.AppKit              	0x00007fff86ab135b NSApplicationMain + 279
14  org.aegidian.oolite           	0x0000000100001444 start + 52

It looks like it is related with creating the window. Nothing in the log after the [dataCache.rebuild.explicitFlush] line, so it looks like it crashed early in the startup process.

I also tested it on my 'brand new' second hand laptop with Mountain Lion. There it opened okay.

[JensAyton]

The Snow Leopard issue should be fixed in r5405.

[Eric Walch]

Confirmed. I just downloaded the latest Nighty and it runs fine on Snow Leopard (both in 32 bit and 64 bit mode) and on Leopard.

And it really makes a great difference having the menu and docks available in full screen in the 64 bit modes. I just noticed again while comparing.

[JensAyton]

Just to double-check, you’re no longer seeing the GL-related crash in the legacy build?

[Eric Walch]

It works okay in 32 bit mode on Snow Leopard. The only glitch is that ⌘f can still be used to switch from full screen to windowed mode, in addition to the new key combination.

On Leopard, it still crashes though. Strange, as I was sure it worked before. But maybe it was only the crashing on startup that was fixed now and I forgot the test the full screen thing. Anyhow, I can fly in full screen, but on leaving windowed mode I get a ctd with:

Code: Select all

Thread 0 Crashed:
0   org.aegidian.oolite           	0x0018dd11 -[OOConcreteTexture dealloc] + 162
1   org.aegidian.oolite           	0x0011e496 -[OOTexture releaseInContext:] + 272
2   org.aegidian.oolite           	0x0011e5ca -[OOTexture release] + 43
3   org.aegidian.oolite           	0x0011909e -[OOShaderMaterial dealloc] + 114
4   org.aegidian.oolite           	0x001229a3 -[OOMesh dealloc] + 139
5   com.apple.Foundation          	0x9126344f NSPopAutoreleasePool + 431
6   org.aegidian.oolite           	0x0000e6cb -[GameController applicationDidFinishLaunching:] + 911
7   com.apple.Foundation          	0x9126742a _nsnote_callback + 106
8   com.apple.CoreFoundation      	0x9720447a __CFXNotificationPost + 362
9   com.apple.CoreFoundation      	0x97204753 _CFXNotificationPostNotification + 179
10  com.apple.Foundation          	0x91264680 -[NSNotificationCenter postNotificationName:object:userInfo:] + 128
11  com.apple.Foundation          	0x9126ded8 -[NSNotificationCenter postNotificationName:object:] + 56
12  com.apple.AppKit              	0x925ecdf2 -[NSApplication _postDidFinishNotification] + 125
13  com.apple.AppKit              	0x925ecd01 -[NSApplication _sendFinishLaunchingNotification] + 77
14  com.apple.AppKit              	0x9256681b -[NSApplication(NSAppleEventHandling) _handleAEOpen:] + 284
15  com.apple.AppKit              	0x92566014 -[NSApplication(NSAppleEventHandling) _handleCoreEvent:withReplyEvent:] + 98
16  com.apple.Foundation          	0x9128ca9f -[NSAppleEventManager dispatchRawAppleEvent:withRawReply:handlerRefCon:] + 655
17  com.apple.Foundation          	0x9128c7af _NSAppleEventManagerGenericHandler + 223
18  com.apple.AE                  	0x92e66648 aeDispatchAppleEvent(AEDesc const*, AEDesc*, unsigned long, unsigned char*) + 144
19  com.apple.AE                  	0x92e6657e dispatchEventAndSendReply(AEDesc const*, AEDesc*) + 44
20  com.apple.AE                  	0x92e66425 aeProcessAppleEvent + 177
21  com.apple.HIToolbox           	0x93d85981 AEProcessAppleEvent + 38
22  com.apple.AppKit              	0x925638e9 _DPSNextEvent + 1189
23  com.apple.AppKit              	0x92562f88 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128
24  com.apple.AppKit              	0x9255bf9f -[NSApplication run] + 795
25  com.apple.AppKit              	0x925291d8 NSApplicationMain + 574
26  org.aegidian.oolite           	0x00002b75 start + 53

Unrelated: I want to update my Leopard mac to Snow Leopard in some time for security reasons, because Apple stopped any support for it. (surprisingly they still did one Java update for it this summer for the Java bug that infected many macs this spring) And now also firefox and Google Chrome stopped updating their browsers for it.

[JensAyton]

Unrelated: I want to update my Leopard mac to Snow Leopard in some time for security reasons, because Apple stopped any support for it.

And I want to get this over with, so I guess our interests align. :-) (Or, y’know, drop support for 32-bit/10.5. But people complain when I do things like that. Mostly non-Mac developers, now that I think about it…)

Please try to reproduce it with this binary: http://jens.ayton.se/temp/Oolite-testre ... c4.3.2.zip and send me the full crash report. Also, precisely what do you mean by “on leaving windowed mode”?

[JensAyton]

Oh yeah, please also enable display.macLegacy in logcontrol.plist, and send the log too.

[Eric Walch]

I have been playing a bit.
- No crash without any oxps installed.
- No crash when starting in windowed mode.
- No crash when starting in Full screen but switch briefly to and from windowed mode before launch. (Maybe because not all oxp ships are added than)

- Only a crash when starting and launching in full screen mode and than switching to windowed mode.

I assume the crash is related to cobra from the startup screen. (See application specific info below)

Code: Select all

Application Specific Information:
13:55:33.160 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1fad8740 (cobra3_redux.png) with current OpenGL context (null)


Thread 0 Crashed:
0   org.aegidian.oolite           	0x0018ba89 -[OOConcreteTexture dealloc] + 291
1   org.aegidian.oolite           	0x0011ca48 -[OOTexture releaseInContext:] + 272
2   org.aegidian.oolite           	0x0011cb7c -[OOTexture release] + 43
3   org.aegidian.oolite           	0x001176af -[OOShaderMaterial dealloc] + 114
4   org.aegidian.oolite           	0x00120f3a -[OOMesh dealloc] + 139
5   com.apple.Foundation          	0x9126344f NSPopAutoreleasePool + 431
6   org.aegidian.oolite           	0x0000df15 -[GameController applicationDidFinishLaunching:] + 911
7   com.apple.Foundation          	0x9126742a _nsnote_callback + 106
8   com.apple.CoreFoundation      	0x9720447a __CFXNotificationPost + 362
9   com.apple.CoreFoundation      	0x97204753 _CFXNotificationPostNotification + 179
10  com.apple.Foundation          	0x91264680 -[NSNotificationCenter postNotificationName:object:userInfo:] + 128
11  com.apple.Foundation          	0x9126ded8 -[NSNotificationCenter postNotificationName:object:] + 56
12  com.apple.AppKit              	0x925ecdf2 -[NSApplication _postDidFinishNotification] + 125
13  com.apple.AppKit              	0x925ecd01 -[NSApplication _sendFinishLaunchingNotification] + 77
14  com.apple.AppKit              	0x9256681b -[NSApplication(NSAppleEventHandling) _handleAEOpen:] + 284
15  com.apple.AppKit              	0x92566014 -[NSApplication(NSAppleEventHandling) _handleCoreEvent:withReplyEvent:] + 98
16  com.apple.Foundation          	0x9128ca9f -[NSAppleEventManager dispatchRawAppleEvent:withRawReply:handlerRefCon:] + 655
17  com.apple.Foundation          	0x9128c7af _NSAppleEventManagerGenericHandler + 223
18  com.apple.AE                  	0x92e66648 aeDispatchAppleEvent(AEDesc const*, AEDesc*, unsigned long, unsigned char*) + 144
19  com.apple.AE                  	0x92e6657e dispatchEventAndSendReply(AEDesc const*, AEDesc*) + 44
20  com.apple.AE                  	0x92e66425 aeProcessAppleEvent + 177
21  com.apple.HIToolbox           	0x93d85981 AEProcessAppleEvent + 38
22  com.apple.AppKit              	0x925638e9 _DPSNextEvent + 1189
23  com.apple.AppKit              	0x92562f88 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128
24  com.apple.AppKit              	0x9255bf9f -[NSApplication run] + 795
25  com.apple.AppKit              	0x925291d8 NSApplicationMain + 574
26  org.aegidian.oolite           	0x00002445 start + 53

The latest log (with legacy logging on) I don't think it contains valuable information.

Code: Select all

    13:55:26.735 [load.upgrade.replacedEnergyBomb] PlayerEntity.m:1213: Replaced legacy energy bomb with Quirium cascade mine.
    13:55:27.490 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f874f30 (tear-neon_tex.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:27.499 [script.javaScript.exception.parenInParen] OOJavaScriptEngine.m:198: ***** JavaScript exception (wyvernMilitaryMissile.js.anon-script): SyntaxError: missing ) in parenthetical
    13:55:27.499 [script.javaScript.exception.parenInParen] OOJavaScriptEngine.m:205:       /Users/ericwalch/Library/Application Support/Oolite/AddOns/milmissile.oxp/Scripts/wyvernMilitaryMissile.js, line 11: 	function allNasties(entity) {return entity.isShip && (entity.isPirate || entity.isThargoid || entity.primaryRole == "hardpirate"}; 
    13:55:27.500 [script.javaScript.load.failed] OOJSScript.m:242: ***** Error loading JavaScript script /Users/ericwalch/Library/Application Support/Oolite/AddOns/milmissile.oxp/Scripts/wyvernMilitaryMissile.js -- compilation failed
13:55:27.666 [texture.load.png.error] OOPNGTextureLoader.m:223: ***** A PNG loading error occurred for /Users/ericwalch/Library/Application Support/Oolite/AddOns/RandomHits1.4.9.oxp/Textures/imp_cour_tex.png: bad adaptive filter value.
    13:55:28.049 [test] OOJSGlobal.m:256: missionScreenOpportunity has fired
    13:55:28.054 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f8c3400 (griff_gecko_sharkteeth_decal.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.055 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x20df9490 (griff_moray_diffuse_med.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.056 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f9fa720 (griff_moray_normal.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.057 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f9f8210 (griff_moray_masks.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.057 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f9d6510 (griff_moray_effects.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.058 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f944fb0 (griff_newkrait_decals.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.059 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1ec68160 (Griff_cobra_mk3_mainhull_diffuse_spec.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.059 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f8588a0 (Griff_cobra_mk3_mainhull_normal.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.060 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f81da50 (Griff_cobra_mk3_mainhull_effects.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.061 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1ec47a30 (Guard_tex.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.062 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f870180 (Griff_cobra_mk3_front_gun_diffuse_spec.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.062 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f810450 (Griff_cobra_mk3_front_gun_normal.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.063 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1fa8d480 (griff_newkrait_diffuse.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.063 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f92ed30 (griff_newkrait_normal.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.064 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f944ae0 (griff_newkrait_effects.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.066 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f9f0d70 (griff_sidewinder_diffuse.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.066 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f9d5890 (griff_sidewinder_normal.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.067 [temp.texture.dealloc] OOConcreteTexture.m:146: Deallocating and uncaching texture 0x1f9ce760 (griff_sidewinder_effects.png) with current OpenGL context <NSOpenGLContext 0x1f5ee540>
    13:55:28.081 [test] OOJSGlobal.m:256: Player Collided with [Station "Coriolis Station" "Coriolis Station" position: (31423.9, -1401.73, 213661) scanClass: CLASS_STATION status: STATUS_ACTIVE]
    13:55:29.699 [bigShips_populator] OOJSGlobal.m:256: 0 big trader(s) added to the Diti system.
    13:55:29.700 [script.javaScript.exception.notFunction] OOJavaScriptEngine.m:198: ***** JavaScript exception (Pi-Forty-Two Con stores 4.1.4): TypeError: System.addShips is not a function
    13:55:29.700 [script.javaScript.exception.notFunction] OOJavaScriptEngine.m:209:       /Users/ericwalch/Library/Application Support/Oolite/AddOns/YOUR_AD_HERE.oxp/Scripts/your_ad_here.js, line 24.

I notice that the application specific info is not in the log and is also logged several seconds after the latest log line. Probably the moment of the crash. And on every crash it is about the "cobra3_redux.png". I assume it is the cobra from the startup screen.

Also, precisely what do you mean by “on leaving windowed mode”?

I mend entering windowed mode.

[JensAyton]

You know that bit where I asked for a full crash report? There was actually a reason for that.

Still, this bit looks like the smoking gun (I had a hunch):

with current OpenGL context (null)

Hopefully fixed in r5537.

[Eric Walch]

Hopefully fixed in r5537.

I think yes. No more crashes now.

You know that bit where I asked for a full crash report? There was actually a reason for that.

Still, this bit looks like the smoking gun (I had a hunch):

with current OpenGL context (null)

I know, but normally the Application Specific Information holds nothing related to the bug. I looked it up and yesterdays crashlog just showed:

Code: Select all

Application Specific Information:
22:28:48.993 [script.javaScript.stackTrace] OOJavaScriptEngine.m:719:     this: [Script "test" version 1.00]