compassTarget in interstellar space causes instant CTD

[Wildeblood]

Try this on a Win7 computer: start with a plain vanilla Oolite 1.76.1, no OXPs except basic-debug; jump into interstellar space; type PS.compassTarget into the console. Here that causes an instant crash. Even typing :d PS into the console does the same, as soon as it tries to evaluate player.ship.compassTarget

Code: Select all

Use Up and Down arrows to scroll through the command history.
Type /quit to quit.
Waiting for connection...
Opened connection with Oolite version 1.76.1
> :d PS
> dumpObject(eval("PS"))
Connection closed with no message.
Opened connection with Oolite version 1.76.1
> PS.compassMode
COMPASS_MODE_BASIC
> PS.compassTarget
Connection closed with no message.

Code: Select all

17:02:01.327 [log.header]: Opening log for Oolite version 1.76.1 (x86-32 test release) under Windows at 2012-11-05 17:02:01 +0800.
2 processors detected.
Build options: spoken messages, mass/fuel pricing, JavaScript console support, OXP verifier, localization tools, debug GraphViz support, JavaScript profiling.

Note that the contents of the log file can be adjusted by editing logcontrol.plist.

17:02:02.162 [display.mode.list.native]: Windows native resolution detected: 1920 x 1200
17:02:02.276 [joystick.init]: Number of joysticks detected: 0
17:02:02.312 [rendering.opengl.version]: OpenGL renderer version: 2.1.0 ("2.1.0 - Build 8.15.10.2302"). Vendor: "Intel". Renderer: "Mobile Intel(R) 4 Series Express Chipset Family".
17:02:02.312 [rendering.opengl.extensions]: OpenGL extensions (82):
GL_ARB_texture_env_crossbar, GL_EXT_abgr, GL_ARB_shadow, GL_IBM_texture_mirrored_repeat, GL_EXT_separate_specular_color, GL_EXT_texture_edge_clamp, GL_EXT_blend_minmax, GL_EXT_draw_buffers2, GL_ARB_texture_env_add, GL_EXT_framebuffer_blit, GL_EXT_transform_feedback, GL_ARB_texture_env_dot3, GL_EXT_framebuffer_object, GL_EXT_blend_subtract, GL_3DFX_texture_compression_FXT1, GL_NV_conditional_render, GL_ARB_multitexture, GL_EXT_stencil_wrap, GL_ARB_texture_border_clamp, GL_ARB_framebuffer_sRGB, GL_ARB_texture_env_combine, GL_EXT_texture_env_add, GL_EXT_packed_pixels, GL_SGIS_texture_edge_clamp, GL_ARB_depth_texture, GL_SGIS_texture_lod, GL_ARB_occlusion_query, GL_ARB_transpose_matrix, GL_NV_texgen_reflection, GL_EXT_stencil_two_side, GL_ARB_shading_language_100, GL_ARB_texture_compression_rgtc, GL_EXT_texture_shared_exponent, GL_EXT_rescale_normal, GL_ARB_pixel_buffer_object, GL_EXT_secondary_color, GL_ARB_half_float_pixel, GL_EXT_blend_equation_separate, GL_EXT_draw_range_elements, GL_EXT_texture_lod_bias, GL_EXT_texture_filter_anisotropic, GL_ARB_half_float_vertex, GL_EXT_texture_swizzle, GL_SGIS_generate_mipmap, GL_ARB_texture_rectangle, GL_ARB_texture_non_power_of_two, GL_ARB_point_sprite, GL_EXT_packed_depth_stencil, GL_ARB_vertex_shader, GL_EXT_texture_compression_s3tc, GL_ARB_depth_buffer_float, GL_ARB_draw_instanced, GL_ARB_vertex_buffer_object, GL_WIN_swap_hint, GL_ARB_color_buffer_float, GL_ARB_shader_objects, GL_ATI_separate_stencil, GL_EXT_packed_float, GL_EXT_texture_rectangle, GL_ARB_texture_rg, GL_ARB_fragment_shader, GL_EXT_fog_coord, GL_EXT_texture3D, GL_ARB_window_pos, GL_ARB_fragment_program, GL_ARB_vertex_program, GL_EXT_texture_env_combine, GL_ARB_point_parameters, GL_ARB_texture_cube_map, GL_EXT_bgra, GL_EXT_compiled_vertex_array, GL_ARB_vertex_array_object, GL_ARB_draw_buffers, GL_ARB_texture_compression, GL_EXT_multi_draw_arrays, GL_ARB_texture_float, GL_EXT_blend_func_separate, GL_EXT_texture_sRGB, GL_EXT_shadow_funcs, GL_EXT_clip_volume_hint, GL_EXT_blend_color, GL_NV_blend_square
17:02:02.319 [rendering.opengl.shader.support]: Shaders are supported.
17:02:02.319 [speech.synthesis]: Spoken messages are off.
17:02:02.344 [searchPaths.dumpAll]: Unrestricted mode - resource paths:
    Resources
    ../AddOns
    ../AddOns/Basic-debug.oxp
17:02:02.678 [script.load.world.listAll]: Loaded 5 world scripts:
    oolite-cloaking-device 1.76.1
    oolite-constrictor-hunt 1.76.1
    oolite-nova 1.76.1
    oolite-thargoid-plans 1.76.1
    oolite-trumbles 1.76.1
17:02:05.566 [loading.complete]: ========== Loading complete. ==========
17:02:05.676 [debugTCP.connected]: Connected to debug console "DebugConsole".

That's the cause of the CTD reported here: https://bb.oolite.space/viewtopic.php?f=4&t=12434.
Because it switches between two compasses on screen, the HUD script contains a check on launching from a station, to ensure that nothing has gone wrong and at least one is displayed. That check is simply if(!player.ship.compassTarget). So launching from a station in interstellar space caused the reported CTD.

[cim]

Should be fixed in trunk in r5474. Thanks for tracking this one down.