Trunk Revision Numbers

An area for discussing new ideas and additions to Oolite.

Moderators: winston, another_commander

Post Reply
User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Trunk Revision Numbers

Post by Thargoid »

A small thought - would it be possible to have trunk add its current revision number to the latest.log when it opens? Maybe add it to the first line of the log for example

Code: Select all

Opening log for Oolite version 1.77 (x86-32 test release) under Windows at 2012-10-26 21:56:24 +0100.
Perhaps add it in after the 1.77 as either 1.77.xxxx or 1.77 rev xxxx?

Just thinking to make life a little easier to track what revision is currently in use, for bug tracking and making sure correct revisions are in use for new feature availability etc.[/color]
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Re: Trunk Revision Numbers

Post by Cody »

The trunk version numbers are already added to logs from the nightly builds, thus:

Code: Select all

Oolite development version 1.77.0.5436
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Re: Trunk Revision Numbers

Post by Thargoid »

I mean for build-from-source builds. They don't have any branding.

Sorry should have been more specific.
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Re: Trunk Revision Numbers

Post by Cody »

Thargoid wrote:
I mean for build-from-source builds.
Yeah, I realised that - I was just saying...
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: Trunk Revision Numbers

Post by cim »

"make release-snapshot" adds the watermark. Or explicitly define the SNAPSHOT_BUILD compile option, if you prefer.
User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Re: Trunk Revision Numbers

Post by Thargoid »

Those either seem to do nothing, aren't recognised as command line options or add "Development build" without a number to the screen as a watermark...
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: Trunk Revision Numbers

Post by cim »

Try "make -f Makefile" rather than "make" as the command?
User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Re: Trunk Revision Numbers

Post by Thargoid »

cim wrote:
Try "make -f Makefile" rather than "make" as the command?
Using make -f Makefile release-snapshot performed a make, but didn't watermark anything.

I'll try the other variations later and see if I can get something that works.
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6683
Joined: Wed Feb 28, 2007 7:54 am

Re: Trunk Revision Numbers

Post by another_commander »

Did you try a make -fMakefile clean first? Remember, when you change build settings, you must perform a make clean to be sure that everything is updated with the new settings.
User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Re: Trunk Revision Numbers

Post by Thargoid »

No I hadn't. Now done and watermark is there fully.
Post Reply