Permanent GalDrive OXP

[Wildeblood]

Righto, I just did the mission in question. The result was an almost 1 megabyte log file full of this junk...

Also three annoyed passengers who refused to pay because I delivered them to the wrong galaxy. Until then I had a perfect passenger reputation. All-in-all, I'm not very impressed with this "mission". I don't see what all the fuss was about.

[Eric Walch]

With, or without?

without of cause.

Before the escorts jumped on their own, but now those without the motor are unaffected and keep their original behaviour of following a mother.
Other ships like shuttles or Geckos are now also unaffected in their AI and try to do what they always did.
For geckos that will be no problem, but rising shuttles will have their own problem without station to go to.

Anyhow, this will lead internally to some discussion if the 'sendAllShipsAway' should really send them all away, of just those that can jump. The command was written for the nova mission to let all ships flee and in that light it is realistic that those without the right equipment stay trapped in the system.

[Switeck]

Can't npcs that lack hyperdrives just seek out other npc wormholes?
...using enterTargetWormhole in its AI.plist.

[Eric Walch]

Can't npcs that lack hyperdrives just seek out other npc wormholes?
...using enterTargetWormhole in its AI.plist.

Problem is that ships generally can't target Wormholes. There is a lot of code inside Oolite that assumes that npc targets are ship entities. In the current state it could lead to crashes when allowing wormholes as target. To prevent crashes, the npc code needs probably in a hundred places a check for not being a wormhole.
Therefor in update, any wormhole used as target is immediately lost. 'enterTargetWormhole' only works in the same update cycle when the mother gives the wormhole target to the escorts.

[Smivs]

Clearly a bug in XeptatisSword

No longer Updated to v1.0.2 to correct this.

[Eric Walch]

Clearly a bug in XeptatisSword

No longer Updated to v1.0.2 to correct this.

Thanks. But as similar incompatibilities will pop up in the future, I think we also should change it in Oolite itself. There "none" was used in the belief this would be a non-existing role in the old days. I think we should change it to "noneExistingRoleInTheWholeUniverse" (or similar) to be sure it will not exist in any oxp.

[Smivs]

I think we should change it to "noneExistingRoleInTheWholeUniverse"

Yeah, that's a nice snappy name...I like that