[UPDATED RELEASE] - Escort Contracts OXP - 1.5.6 (07/05/12)

[Capt. Murphy]

Sorry - if you are the 1 person whose downloaded this in the last 5-10 minutes, please redownload.

I forgot to remove the reportAImessages flag from the original upload - reuploaded.

[Wildeblood]

Version 1.2 uploaded - see first post for updated read me and download link.

Added an additional check to avoid anomalous communication from the mother when docked.

Which bits do I need to comment out? These "anomalous communications" were not a bug, they were a reminder.

[Capt. Murphy]

The anomalous communications were those reported by Oathbreaker - i.e. he launched, was acknowledged by the mother, but then redocked. At this point the intention is that the contract is failed and the mother should be silently removed from the system. So any communications received from the mother after this point are most definitely a bug and not a reminder.

What has changed is lines 23 to 27 of ec_mother.js

Was

Code: Select all

if(!player.ship)
		{
		return;	
		}

is now

Code: Select all

	if(!player.ship || player.ship.docked == true)
		{
		this.ship.reactToAIMessage("TARGET_LOST");
		return;		
		}

[Wildeblood]

The anomalous communications were those reported by Oathbreaker - i.e. he launched, was acknowledged by the mother, but then redocked. At this point the intention is that the contract is failed and the mother should be silently removed from the system.

Why? He might have realized welching on a contract was wrong, and changed his mind again. Then he'd re-launch (within three hours game time), find the mother-ship had left early and come here to report that as a bug. There's a difference between "doesn't suit me" and "is a bug". Players making bug reports because they've decided to welch on a contract should be given a stern talking to.

[Capt. Murphy]

Why? He might have realized welching on a contract was wrong, and changed his mind again. Then he'd re-launch (within three hours game time), find the mother-ship had left early and come here to report that as a bug. There's a difference between "doesn't suit me" and "is a bug". Players making bug reports because they've decided to welch on a contract should be given a stern talking to.

Why? Because that was how the code was intended to work from the first release, and did work until I broke it rewriting the AI for the last release. I.e. the mother sees their escort launch and then redock and so thinks b*ll*cks to you and jumps out of the system - contract failed. If you relaunch and find the mother or keep getting commsMessages after getting the contract failed consoleMessage then it's clearly a bug and correctly reported. If someone reported the mother not being there on a second launch as a bug they would be politely informed that that is the intended behaviour and did they miss the contract failed message?

Sure it would be nice if you could launch, realise you'd forgotten to top up your fuel or whatever and send a nice comms message asking the mother to hang around because you'll be back, but realistically that is probably beyond the scope of my scripting ability, and not necessary for the overall purpose and enjoyment of this OXP

Is it 3 in the morning where you are again?

[Capt. Murphy]

Morning.

Version 1.3 is available for download. As per Oathbreaker's suggestion mission screen handling has been tweaked to give the option to view the Short Range Chart whilst perusing the available contracts and return to the contract mission screens once you've looked at the chart.

Also took the opportunity to add in a check to stop a contract being offered to a post-nova system having finally worked out how to do it. There was some missing documentation on the Wiki which is now there (thanks Eric).

See first post for read me and download link.

[Eric Walch]

Version 1.3 is available for download.

I expect soon a version 1.3.1 also as I found in my log:

Code: Select all

[plist.parse.failed] OOPListParsing.m:74: Failed to parse /Users/ericwalch/Library/Application Support/Oolite/AddOns/Escort Contracts 1.3.oxp/Config/missiontext.plist as a property list.

The reason is a missing semicolon in the line:

Code: Select all

 "3_NOT_INTERESTED" = "Not interested in an escort contract at this time.";

Apparently only an error the mac parser complains about, so others can use the oxp without problems.

[Capt. Murphy]

*cough* - you'd think I would have double checked my plist edits after last time - *cough*

1.3.1 is available for download with missing semi-colon corrected for fussy Macs....

Thanks Eric.

[FleurDeMal]

Hi,

I really like this OXP! But sometimes when I'm synchronising Jump Drives with the mother Oolite crashes completely... I'm using the latest versions of everything, has anyone else had this problem?

It is a great mission though!

Cheers

[Capt. Murphy]

Welcome to the friendliest board this side of Reidquat.....

I haven't suffered any crashes in lots of play-testing so something odd going on here

Can you post your latest.log, taken from immediately after the game has crashed to see if there is any useful info in there. And is it crashing to desk-top or hanging/freezing?

Just in case you don't know where your latest log is this is from http://wiki.alioth.net/index.php/Oolite_FAQ

Question: Someone asked me for my log file. What is that, and where is it?
Answer: In the test releases of Oolite, various diagnostic information is written to a file called Latest.log. Where it is depends on your operating system:

Mac OS X: ~/Library/Logs/Oolite/Latest.log (that is, in your home folder, open the folder named Library, then Logs, then Oolite). Alternatively, select “Show Previous Log” from the “Oolite” menu in the menu bar when running Oolite.
Windows: in Oolite’s folder (typically in C:\Program Files), there is a folder called oolite.app, which contains a folder called Logs.
Linux and other Unix-like systems: ~/.Oolite/Logs (that is, in the hidden folder .Oolite in your home folder). If you’re using Nautilus or Konqueror—if you’ve never heard of them, you probably are—select Show Hidden Files from the View menu.

[FleurDeMal]

It was crashing to desktop - it's happened a few times, always when lining up with the 'Mother' for jump-synching.

Currently away from home but cheers for the info, will post you the log next time it happens...

Cheers again!

[Capt. Murphy]

Hi FleurDeMal,

I've sent you a PM with a link to a download of an replacement ec_mother.js which includes some extra logging. Can you play with that one for a while and then once you've had another crash post the log.

Cheers,

Capt. Murphy.

[FleurDeMal]

Hi!

Thanks for your help with this...

Just had another crash (to desktop), just as I was about to sync jump drives with the mother.

Here's the last lines of the log, is this enough?

17:17:00.125 [Escort_Contracts_Mother]: Mass locked or mother going to fast.
17:17:12.140 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:17:12.140 [Escort_Contracts_Mother]: Targets: [Ship "Cobra Mark I" position: (-6920.21, -38330.1, 77876.1) scanClass: CLASS_NEUTRAL status: STATUS_IN_FLIGHT]
17:17:12.140 [Escort_Contracts_Mother]: Mother position: (-9246.02, -62011.2, 81009.6) Player position: (-9378.44, -61650.3, 77333.5)
17:17:12.140 [Escort_Contracts_Mother]: Distance between player and mother: 3696.1852163326053
17:17:12.140 [Escort_Contracts_Mother]: Heading match (dot product): 0.9915211795456327
17:17:12.140 [Escort_Contracts_Mother]: Player masslocked?: true
17:17:12.140 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:17:12.140 [Escort_Contracts_Mother]: Mass locked or mother going to fast.
17:17:24.171 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:17:24.171 [Escort_Contracts_Mother]: Targets: [Ship "Cobra Mark I" position: (-7063.83, -40147.5, 78243) scanClass: CLASS_NEUTRAL status: STATUS_IN_FLIGHT]
17:17:24.171 [Escort_Contracts_Mother]: Mother position: (-9103.53, -61906.3, 84005.3) Player position: (-9214.25, -61878.7, 81533.2)
17:17:24.171 [Escort_Contracts_Mother]: Distance between player and mother: 2474.734301666904
17:17:24.171 [Escort_Contracts_Mother]: Heading match (dot product): 0.9990690402061526
17:17:24.171 [Escort_Contracts_Mother]: Player masslocked?: true
17:17:24.171 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:17:24.171 [Escort_Contracts_Mother]: Mass locked or mother going to fast.
17:18:47.515 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:18:47.515 [Escort_Contracts_Mother]: Targets:
17:18:47.515 [Escort_Contracts_Mother]: Mother position: (-6504.58, -50923.1, 81131.4) Player position: (-6996.93, -51921.3, 80987.1)
17:18:47.515 [Escort_Contracts_Mother]: Distance between player and mother: 1122.3423709752042
17:18:47.515 [Escort_Contracts_Mother]: Heading match (dot product): 0.09391289073892795
17:18:47.515 [Escort_Contracts_Mother]: Player masslocked?: false
17:18:47.515 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 80.59993743896484
17:18:47.515 [Escort_Contracts_Mother]: Headings do not match.
17:18:51.546 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:18:51.546 [Escort_Contracts_Mother]: Targets:
17:18:51.546 [Escort_Contracts_Mother]: Mother position: (-6481.75, -50943.1, 81781. Player position: (-6933.79, -51795, 81035.
17:18:51.546 [Escort_Contracts_Mother]: Distance between player and mother: 1219.2947851672864
17:18:51.546 [Escort_Contracts_Mother]: Heading match (dot product): 0.5848448608234279
17:18:51.546 [Escort_Contracts_Mother]: Player masslocked?: false
17:18:51.546 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 241.84022521972656
17:18:51.546 [Escort_Contracts_Mother]: Headings do not match.
17:18:55.578 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:18:55.578 [Escort_Contracts_Mother]: Targets:
17:18:55.578 [Escort_Contracts_Mother]: Mother position: (-6446.46, -50973.5, 82787) Player position: (-6887.42, -51714, 81153.1)
17:18:55.578 [Escort_Contracts_Mother]: Distance between player and mother: 1847.266285370652
17:18:55.578 [Escort_Contracts_Mother]: Heading match (dot product): 0.8924967613981077
17:18:55.578 [Escort_Contracts_Mother]: Player masslocked?: false
17:18:55.578 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:18:55.578 [Escort_Contracts_Mother]: Headings do not match.
17:18:59.609 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:18:59.609 [Escort_Contracts_Mother]: Targets:
17:18:59.609 [Escort_Contracts_Mother]: Mother position: (-6411.16, -51004, 83792. Player position: (-6856.49, -51665.9, 81292.
17:18:59.609 [Escort_Contracts_Mother]: Distance between player and mother: 2624.1146106724186
17:18:59.609 [Escort_Contracts_Mother]: Heading match (dot product): 0.9526537769089805
17:18:59.609 [Escort_Contracts_Mother]: Player masslocked?: false
17:18:59.609 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:18:59.609 [Escort_Contracts_Mother]: Player more than 2500m away.
17:19:03.640 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:19:03.640 [Escort_Contracts_Mother]: Targets:
17:19:03.640 [Escort_Contracts_Mother]: Mother position: (-6375.86, -51034.5, 84798.5) Player position: (-6794.44, -51579.1, 81694.7)
17:19:03.640 [Escort_Contracts_Mother]: Distance between player and mother: 3178.853927686201
17:19:03.640 [Escort_Contracts_Mother]: Heading match (dot product): 0.9743322142596454
17:19:03.640 [Escort_Contracts_Mother]: Player masslocked?: false
17:19:03.640 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:19:03.640 [Escort_Contracts_Mother]: Player more than 2500m away.
17:19:07.671 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:19:07.671 [Escort_Contracts_Mother]: Targets:
17:19:07.671 [Escort_Contracts_Mother]: Mother position: (-6340.56, -51065, 85804.2) Player position: (-6727.1, -51496.5, 82238.9)
17:19:07.671 [Escort_Contracts_Mother]: Distance between player and mother: 3612.04308193543
17:19:07.671 [Escort_Contracts_Mother]: Heading match (dot product): 0.9860537543542511
17:19:07.671 [Escort_Contracts_Mother]: Player masslocked?: false
17:19:07.671 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:19:07.671 [Escort_Contracts_Mother]: Player more than 2500m away.
17:19:11.703 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:19:11.703 [Escort_Contracts_Mother]: Targets:
17:19:11.703 [Escort_Contracts_Mother]: Mother position: (-6305.24, -51095.5, 86810.2) Player position: (-6664, -51429.1, 82863.1)
17:19:11.703 [Escort_Contracts_Mother]: Distance between player and mother: 3977.394540757534
17:19:11.703 [Escort_Contracts_Mother]: Heading match (dot product): 0.9904688476854181
17:19:11.703 [Escort_Contracts_Mother]: Player masslocked?: false
17:19:11.703 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:19:11.703 [Escort_Contracts_Mother]: Player more than 2500m away.
17:19:15.734 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:19:15.734 [Escort_Contracts_Mother]: Targets:
17:19:15.734 [Escort_Contracts_Mother]: Mother position: (-6269.94, -51126, 87815.9) Player position: (-6585.39, -51357.2, 83784.2)
17:19:15.734 [Escort_Contracts_Mother]: Distance between player and mother: 4050.647859048993
17:19:15.734 [Escort_Contracts_Mother]: Heading match (dot product): 0.9941073654664012
17:19:15.734 [Escort_Contracts_Mother]: Player masslocked?: false
17:19:15.734 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:19:15.734 [Escort_Contracts_Mother]: Player more than 2500m away.
17:19:19.765 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:19:19.765 [Escort_Contracts_Mother]: Targets:
17:19:19.765 [Escort_Contracts_Mother]: Mother position: (-6234.64, -51156.5, 88821.7) Player position: (-6500.75, -51298.3, 84926.4)
17:19:19.765 [Escort_Contracts_Mother]: Distance between player and mother: 3906.9291755055574
17:19:19.765 [Escort_Contracts_Mother]: Heading match (dot product): 0.9959157049049094
17:19:19.765 [Escort_Contracts_Mother]: Player masslocked?: false
17:19:19.765 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:19:19.765 [Escort_Contracts_Mother]: Player more than 2500m away.
17:19:23.796 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:19:23.796 [Escort_Contracts_Mother]: Targets:
17:19:23.796 [Escort_Contracts_Mother]: Mother position: (-6199.34, -51186.9, 89827.4) Player position: (-6414.45, -51259.1, 86271.
17:19:23.796 [Escort_Contracts_Mother]: Distance between player and mother: 3562.872684053215
17:19:23.796 [Escort_Contracts_Mother]: Heading match (dot product): 0.9983651423306261
17:19:23.796 [Escort_Contracts_Mother]: Player masslocked?: false
17:19:23.796 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:19:23.796 [Escort_Contracts_Mother]: Player more than 2500m away.
17:19:27.828 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:19:27.828 [Escort_Contracts_Mother]: Targets:
17:19:27.828 [Escort_Contracts_Mother]: Mother position: (-6164.02, -51217.4, 90833.4) Player position: (-6332.38, -51236.9, 87680.6)
17:19:27.828 [Escort_Contracts_Mother]: Distance between player and mother: 3157.356363894761
17:19:27.828 [Escort_Contracts_Mother]: Heading match (dot product): 0.998996131752734
17:19:27.828 [Escort_Contracts_Mother]: Player masslocked?: false
17:19:27.828 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:19:27.828 [Escort_Contracts_Mother]: Player more than 2500m away.
17:19:31.859 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:19:31.859 [Escort_Contracts_Mother]: Targets:
17:19:31.859 [Escort_Contracts_Mother]: Mother position: (-6128.72, -51247.9, 91839.1) Player position: (-6258.34, -51233, 89089.7)
17:19:31.859 [Escort_Contracts_Mother]: Distance between player and mother: 2752.539592176833
17:19:31.859 [Escort_Contracts_Mother]: Heading match (dot product): 0.9995172475094815
17:19:31.859 [Escort_Contracts_Mother]: Player masslocked?: false
17:19:31.859 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:19:31.859 [Escort_Contracts_Mother]: Player more than 2500m away.
17:19:35.890 [Escort_Contracts_Mother]: ec_checkplayermasslock called
17:19:35.890 [Escort_Contracts_Mother]: Targets:
17:19:35.890 [Escort_Contracts_Mother]: Mother position: (-6093.42, -51278.4, 92844. Player position: (-6188.48, -51238.5, 90498.
17:19:35.890 [Escort_Contracts_Mother]: Distance between player and mother: 2348.3506277077217
17:19:35.890 [Escort_Contracts_Mother]: Heading match (dot product): 0.9997351596763953
17:19:35.890 [Escort_Contracts_Mother]: Player masslocked?: false
17:19:35.890 [Escort_Contracts_Mother]: Mother max speed: 312 Mother current speed: 249.60000610351562
17:19:35.890 [Escort_Contracts_Mother]: Successful Hop.

Let me know if there's anything else I can do...

Cheers

[commanderxairon]

not a way for the contracts to being more long lasting? or until you want to cancel them i mean they can fee you for every system they scort you and for their repairs and fuel o.o

[FeelGone]

Something that is not a bug, but doesn't make much intuitive sense to me, is this:

On accepting a contract, you have 3 hours to launch. This means you don't have time to buy equipment upgrades (I made this first mistake the first time; I was taking a relatively underpowered ship into a Multi-Government system and so decided to use all my credits on upgrades - then launched, penniless, to find out my contract had expired, argh!). But, if after cycling through the available contracts you navigate away to a different screen, you can buy upgrades, trade cargo, view the Short Range Chart, etc. - then return to the Contracts Screen and have the same contracts offered to you. More than 3 hours has elapsed in game time, so wouldn't those ships have launched? If not, why do they impose the artificial restriction of a 3 hour launch window only after you accept the contract?

That said, I enjoy this OXP, and the synchronising jump drives is a very neat trick.