Can't reset JavaScript

[Eric Walch]

After death, my mac went into a loop with the following repeating message.

Code: Select all

[test handlers] OOJSGlobal.m:247: Player is sustaining 774.0452270507812 units of energy damage from: unknown
[test handlers] OOJSGlobal.m:247: Player died because of: energy damage

[system] *** Assertion failure in -[OOJavaScriptEngine reset], /Users/ericwalch/Oolite/trunk/src/Core/Scripting/OOJavaScriptEngine.m:409
[exception] PlayerEntity.m:1609: ***** Exception during [performDeadUpdates:] in -[PlayerEntity update:] : NSInternalInconsistencyException : Can't reset JavaScript engine while running JavaScript. *****
[exception] Universe.m:5269: ***** Exception during [update:entity [<PlayerEntity 0x10207d600>{"Boa Class Cruiser" position: (-3421.04, 3977.06, 43562.2) scanClass: CLASS_PLAYER status: STATUS_DEAD}]] in [Universe update:] : NSInternalInconsistencyException : Can't reset JavaScript engine while running JavaScript. *****

[system] *** Assertion failure in -[OOJavaScriptEngine reset], /Users/ericwalch/Oolite/trunk/src/Core/Scripting/OOJavaScriptEngine.m:409
[exception] PlayerEntity.m:1609: ***** Exception during [performDeadUpdates:] in -[PlayerEntity update:] : NSInternalInconsistencyException : Can't reset JavaScript engine while running JavaScript. *****
[exception] Universe.m:5269: ***** Exception during [update:entity [<PlayerEntity 0x10207d600>{"Boa Class Cruiser" position: (-3422.14, 3979.21, 43567.6) scanClass: CLASS_PLAYER status: STATUS_DEAD}]] in [Universe update:] : NSInternalInconsistencyException : Can't reset JavaScript engine while running JavaScript. *****

The only keys that were working were switching full-screen and the quit key.

I was killed by a missile of which I already had killed the owner. Therefore the "energy damage by unknown" in the log.

[Richard-H]

I got this same error after I swiched to 1.75

see https://bb.oolite.space/viewtopic.php?f=3&t=9289

Richard

[another_commander]

How repeatable is this? Any way we can cause it to happen or is it pretty much random?

[Eric Walch]

How repeatable is this? Any way we can cause it to happen or is it pretty much random?

For me it was the second time it happened. The first time was at 28th febr (see link above). I don't die that much but it still is very rare and at that time I could not repeat it. I will try to make some test cases with ships killing me with missiles to try reproducing it.

[Richard-H]

How repeatable is this? Any way we can cause it to happen or is it pretty much random?

to answer you question another_commander

this is an nasty one because it is time dependence
I will try to explain
if you start a new game you get out of the main station and fly strait in to the beacon you don't have a problem
the normal way after you get killed "press space" wil get you a new start

but if you play for a while (if you want i will look for how log it will take) it happens to me all the time


because i compile oolite my self and nobody exept cmr Walch my first suspect was my self because there were no other reports

I think that there are 1 or 2 java scripts running and one can not be killed by the java script engine but that is a guess
that i got from the message in the latest.log

so witch setting i have to chance to find out witch script is running so there will be more info to solve this




Richard

[another_commander]

...because i compile oolite my self and nobody exept cmr Walch my first suspect was my self because there were no other reports

[snip]
so witch setting i have to chance to find out witch script is running so there will be more info to solve this

If you are compiling the game yourself, can you please run it through gdb? If you do and this situation happens, it should hit the assert at line 409 of OOJavaScriptEngine.m and stop, at which point you can give us a backtrace by executing the command bt in gdb and posting here the output.

This error is expected to occur only on Mac and Linux builds, because the Windows version of the SpiderMonkey library is built without having JS_THREADSAFE defined.

[Richard-H]

...because i compile oolite my self and nobody exept cmr Walch my first suspect was my self because there were no other reports

[snip]
so witch setting i have to chance to find out witch script is running so there will be more info to solve this

If you are compiling the game yourself, can you please run it through gdb? If you do and this situation happens, it should hit the assert at line 409 of OOJavaScriptEngine.m and stop, at which point you can give us a backtrace by executing the command bt in gdb and posting here the output.

This error is expected to occur only on Mac and Linux builds, because the Windows version of the SpiderMonkey library is built without having JS_THREADSAFE defined.

Well here is my try
the trunk version is 4603
I'm not so good at using gdb if something i did below is not correct let me know


[richard ~]$ gdb /home/richard/src/source/oolite/trunk/oolite.app/oolite.dbg
GNU gdb (GDB) 7.1
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-slackware-linux".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from
/home/richard/src/source/oolite/trunk/oolite.app/oolite.dbg...done.
(gdb) list OOJavaScriptEngine.m:409
404
405 - (void) reset
406 {
407 NSAssert(gOOJSMainThreadContext != NULL, @"Can't reset
JavaScript engine at this point.");
408 #if JS_THREADSAFE
409 NSAssert(!JS_IsInRequest(gOOJSMainThreadContext), @"Can't
reset JavaScript engine while running JavaScript.");
410 #endif
411
412 JSContext *context = OOJSAcquireContext();
413 [[NSNotificationCenter defaultCenter]
postNotificationName:kOOJavaScriptEngineWillResetNotification object:self];
(gdb) break NSInternalInconsistencyException
Breakpoint 1 at 0x7ffff6ef1048
(gdb) run
Starting program:
/home/richard/src/source/oolite/trunk/oolite.app/oolite.dbg
[Thread debugging using libthread_db enabled]
[New Thread 0x7fffef7c5710 (LWP 22337)]
[New Thread 0x7fffee9b2710 (LWP 22338)]
[New Thread 0x7fffed034710 (LWP 22339)]
[New Thread 0x7fffec833710 (LWP 22340)]
[New Thread 0x7fffe7aa0710 (LWP 22341)]
[New Thread 0x7fffe729f710 (LWP 22342)]
[New Thread 0x7fffe5e9b710 (LWP 22343)]
[New Thread 0x7fffe569a710 (LWP 22344)]
[New Thread 0x7fffe4e99710 (LWP 22345)]
[New Thread 0x7fffe4698710 (LWP 22346)]
[New Thread 0x7fffe3e97710 (LWP 22347)]
[New Thread 0x7fffe3696710 (LWP 22348)]
[New Thread 0x7fffe2e95710 (LWP 22349)]
[New Thread 0x7fffe2694710 (LWP 22350)]

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff5567fb5 in objc_msg_lookup () from /usr/X11R6/lib64/libobjc.so.2
(gdb) bt
#0 0x00007ffff5567fb5 in objc_msg_lookup () from
/usr/X11R6/lib64/libobjc.so.2
#1 0x00007ffff6b5c09c in ?? () from /usr/lib/libgnustep-base.so.1.20
#2 0x00007ffff6b5ba9c in ?? () from /usr/lib/libgnustep-base.so.1.20
#3 0x00007ffff6b5bcea in ?? () from /usr/lib/libgnustep-base.so.1.20
#4 0x00007ffff6afb065 in ?? () from /usr/lib/libgnustep-base.so.1.20
#5 0x00000000005812d4 in -[OOJavaScriptEngine reset] (self=0x7fffeb13a270,
_cmd=0xd725f0) at src/Core/Scripting/OOJavaScriptEngine.m:409
#6 0x000000000044bec8 in -[PlayerEntity setUp] (self=0x7fffeb241ee0,
_cmd=0xd87990) at src/Core/Entities/PlayerEntity.m:1097
#7 0x00000000004a3348 in -[PlayerEntity(LoadSave) loadPlayerFromFile:] (
self=0x7fffeb241ee0, _cmd=0xe34f80, fileToOpen=0x1371700)
at src/Core/Entities/PlayerEntityLoadSave.m:465
#8 0x0000000000611370 in -[GameController loadPlayerIfRequired] (
self=0x7fffe80ce8d0, _cmd=0xe51b40) at src/Core/GameController.m:277
#9 0x000000000063bd74 in -[Universe handleGameOver] (self=0x7fffe81c6660,
_cmd=0xd72fd0) at src/Core/Universe.m:2194
#10 0x0000000000453bf7 in -[PlayerEntity performDeadUpdates:] (
self=0x7fffeb241ee0, _cmd=0xd72a20, delta_t=0.013387978076934814)
at src/Core/Entities/PlayerEntity.m:2497
#11 0x000000000044f139 in -[PlayerEntity update:] (self=0x7fffeb241ee0,
_cmd=0xe526a0, delta_t=0.013387978076934814)
at src/Core/Entities/PlayerEntity.m:1603
#12 0x0000000000649b35 in -[Universe update:] (self=0x7fffe81c6660,
---Type <return> to continue, or q <return> to quit---
_cmd=0xe34fc0, inDeltaT=0.013387978076934814) at
src/Core/Universe.m:5182
#13 0x00000000006116a1 in -[GameController doPerformGameTick] (
self=0x7fffe80ce8d0, _cmd=0xe34fb0) at src/Core/GameController.m:342
#14 0x0000000000611582 in -[GameController performGameTick:] (
self=0x7fffe80ce8d0, _cmd=0xe34ff0, sender=0x7fffc413b500)
at src/Core/GameController.m:321
#15 0x00007ffff6c02dac in ?? () from /usr/lib/libgnustep-base.so.1.20
#16 0x00007ffff6bd90e0 in ?? () from /usr/lib/libgnustep-base.so.1.20
#17 0x00007ffff6bd50a2 in ?? () from /usr/lib/libgnustep-base.so.1.20
#18 0x00007ffff6bd5cc5 in ?? () from /usr/lib/libgnustep-base.so.1.20
#19 0x00000000006112dc in -[GameController applicationDidFinishLaunching:] (
self=0x7fffe80ce8d0, _cmd=0xe37010, notification=0x0)
at src/Core/GameController.m:267
#20 0x0000000000615727 in main (argc=1, argv=0x7fffffffd788)
at src/SDL/main.m:119
(gdb)


richard

[Mauiby de Fug]

Code: Select all

21:09:12.168 [exception]: ***** Exception during [performDeadUpdates:] in -[PlayerEntity update:] : NSInternalInconsistencyException : src/Core/Scripting/OOJavaScriptEngine.m:409  Assertion failed in OOJavaScriptEngine(instance), method reset.  Can't reset JavaScript engine while running JavaScript. *****
21:09:12.168 [exception]: ***** Exception during [update:entity [<PlayerEntity 0x94f1b48>{"Caduceus Omega" position: (123073, 461292, 79807.4) scanClass: CLASS_PLAYER status: STATUS_DEAD}]] in [Universe update:] : NSInternalInconsistencyException : src/Core/Scripting/OOJavaScriptEngine.m:409  Assertion failed in OOJavaScriptEngine(instance), method reset.  Can't reset JavaScript engine while running JavaScript. *****
21:09:12.203 [gnustep]: 2011-07-27 21:09:12.203 oolite[2020] src/Core/Scripting/OOJavaScriptEngine.m:409  Assertion failed in OOJavaScriptEngine(instance), method reset.  Can't reset JavaScript engine while running JavaScript.

Had this a while back whilst testing a mission WIP of Otki's. Happened when I died by getting too close to the sun. I was using a piece of equipment which in the scripting asks for the player's position and the player's target in frame callbacks. Happened in a standard 1.75.3 on Ubuntu.

[Okti]

Had this a while back whilst testing a mission WIP of Otki's. Happened when I died by getting too close to the sun. I was using a piece of equipment which in the scripting asks for the player's position and the player's target in frame callbacks. Happened in a standard 1.75.3 on Ubuntu.

I am not sure about how to check for the player entity has been killed in a frameCallBack, If you all suggest anything about it, that will be appreciated.

That is also true for timers as well.

[CommonSenseOTB]

How about "if(player.ship.isValid)".

Works in a frame callback in the numeric hud when checking targetSystem to prevent changing it when the player ejects(becomes undefined).

[Eric Walch]

How about "if(player.ship.isValid)". .

That definitely is the case when the player dies.

I just was in a fight with two hydras. Of one I shot away all lasers, but the other got me:

Code: Select all

[eric's test handlers] OOJSGlobal.m:247: Damaged: EQ_HEAT_SHIELD With name: External Heat Shielding
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 14.219969749450684 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 14.219990730285645 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player died because of: energy damage
[system] *** Assertion failure in -[OOJavaScriptEngine reset], /Users/ericwalch/Oolite/trunk/src/Core/Scripting/OOJavaScriptEngine.m:409
[exception] PlayerEntity.m:1609: ***** Exception during [performDeadUpdates:] in -[PlayerEntity update:] : NSInternalInconsistencyException : Can't reset JavaScript engine while running JavaScript. *****
[exception] Universe.m:5269: ***** Exception during [update:entity [<PlayerEntity 0x11652fc00>{"Boa Class Cruiser" position: (-25580.1, 65558.5, 474737) scanClass: CLASS_PLAYER status: STATUS_DEAD}]] in [Universe update:] : NSInternalInconsistencyException : Can't reset JavaScript engine while running JavaScript. *****

But my effort to deliberately induce this bug, failed. The past days I killed myself a lot with missiles. Partly because of testing missile code, but there the bug stayed away.

[Richard-H]

How about "if(player.ship.isValid)". .

That definitely is the case when the player dies.

I just was in a fight with two hydras. Of one I shot away all lasers, but the other got me:

Code: Select all

[eric's test handlers] OOJSGlobal.m:247: Damaged: EQ_HEAT_SHIELD With name: External Heat Shielding
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 14.219969749450684 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 14.219990730285645 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player is sustaining 15 units of energy damage from: Hydra
[eric's test handlers] OOJSGlobal.m:247: Player died because of: energy damage
[system] *** Assertion failure in -[OOJavaScriptEngine reset], /Users/ericwalch/Oolite/trunk/src/Core/Scripting/OOJavaScriptEngine.m:409
[exception] PlayerEntity.m:1609: ***** Exception during [performDeadUpdates:] in -[PlayerEntity update:] : NSInternalInconsistencyException : Can't reset JavaScript engine while running JavaScript. *****
[exception] Universe.m:5269: ***** Exception during [update:entity [<PlayerEntity 0x11652fc00>{"Boa Class Cruiser" position: (-25580.1, 65558.5, 474737) scanClass: CLASS_PLAYER status: STATUS_DEAD}]] in [Universe update:] : NSInternalInconsistencyException : Can't reset JavaScript engine while running JavaScript. *****

But my effort to deliberately induce this bug, failed. The past days I killed myself a lot with missiles. Partly because of testing missile code, but there the bug stayed away.

Cmr Walch,


try this to replicate the loop

leave main station
jump to a system with a pirate cove
start killing some pirate ships
after say 5 a 6 minutes fly in to the pirate cove

Richard

[Kaks]

Rev4648 should hopefully contain a fix for this bug. Since I wasn't able to reproduce it, I adopted a better-safe-than sorry approach, which generally does the trick.

Can anybody who gets this bug in a reliable matter check if it's actually, really gone, using the exact same oxps?

Thanks in advance!

[Richard-H]

Rev4648 should hopefully contain a fix for this bug. Since I wasn't able to reproduce it, I adopted a better-safe-than sorry approach, which generally does the trick.

Can anybody who gets this bug in a reliable matter check if it's actually, really gone, using the exact same oxps?

Thanks in advance!

Kaks,

I run revision 4661 did not chance any oxp exep for versions upgrade but still get the same loop

part of my shipslog

20:03:55.941 [Ships Log]: Cobra Courier Mk2 Launched from station Coriolis Station - Diriceen
20:04:07.962 [Ships Log]: Starting jump countdown
20:04:22.950 [Ships Log]: Warning - Cobra Courier Mk2 Will enters witchspace at Diriceen
20:04:22.951 [Ships Log]: Cobra Courier Mk2 Leaves aegis of the planet Diriceen
20:04:26.547 [Ships Log]: Warning - Cobra Courier Mk2 Exited witchspace
20:04:26.548 [Ships Log]: Galaxy 4 at Gexebeor
20:04:26.548 [Ships Log]: Government Anarchy
20:04:26.548 [Ships Log]: Tech level 6
20:04:27.339 [Ships Log]: Alert - Condition chanced to RED !!!!
20:04:41.529 [Ships Log]: Cobra Courier Mk2 received message Nee! Nee! Nee! ... Shh! from ship Thargoid Spy Satellite: Bounty:100cr
20:04:41.530 [Ships Log]: Cobra Courier Mk2 Destroyed the ship Thargoid Spy Satellite Bounty - 100cr
20:05:37.711 [Ships Log]: Alert - Condition chanced to RED !!!!
20:05:49.969 [Ships Log]: Cobra Courier Mk2 launched a MM Hardened Missile at Asp Mark II Special: Bounty:28cr
20:05:56.172 [Ships Log]: Cobra Courier Mk2 launched a MM Hardened Missile at Asp Mark II Special: Bounty:28cr
20:06:06.355 [Ships Log]: Cobra Courier Mk2 launched a MM Hardened Missile at Imperial Courier
20:06:24.415 [Ships Log]: Cobra Courier Mk2 Destroyed the ship Asp Mark II Special Bounty - 33cr
20:06:50.101 [Ships Log]: Cobra Courier Mk2 Destroyed the ship Imperial Courier Engine Bounty - 29cr
20:07:14.829 [Ships Log]: Alert - Cobra Courier Mk2 is Attacked by missile Missile
20:07:15.551 [Ships Log]: Cobra Courier Mk2 launched a MM Hardened Missile at Imperial Courier: Bounty:29cr
20:07:16.025 [Ships Log]: Cobra Courier Mk2 launched a MM Hardened Missile at Imperial Courier: Bounty:29cr
20:07:16.053 [Ships Log]: Alert - Cobra Courier Mk2 Is sustaining damage 3681.012451171875 units of energy damage From Cobra Courier Mk2
20:07:16.055 [Ships Log]: Cobra Courier Mk2 Me is dead because of poor driving the real reason energy damage
20:07:16.056 [Ships Log]: Cobra Courier Mk2 Destroyed the ship Cobra Courier Mk2


20:07:57.690 [gnustep]: 2011-11-23 20:07:57.690 oolite[9734] *** NSTimer ignoring exception 'NSInternalInconsistencyException' (reason 'src/Core/Scripting/OOJavaScriptEngine.m:410 Assertion failed in OOJavaScriptEngine(instance), method reset. JavaScript processes still pending. Can't reset JavaScript engine.') raised during posting of timer with target 0x7f5c380eb8a0 and selector 'performGameTick:'


Richard

edit extra info

[Kaks]

Excellent, at least now we know why it couldn't reset the js engine.


Thanks for that Richard-H, I might just be able to do the right kind of tweaks now. Isn't good error logging just marvelous?