Subentities and trade_in_factor

[Thargoid]

Captain Murphy and I have been doing some testing on the Vortex regarding sub-entities, and we think we've either found a bug or an annoying feature. When the player ship has sub-entities and these are removed, the ships trade_in_factor drops (by 3 for example when you remove a turret from a vortex). However when you restore the sub-entities the trade_in_factor does not get restored.

This rather gets in the way of using scripting to remove and restore sub-entities (for example to turn on and off the Vortex turrets) plus this is probably what is triggering the well known problem with rogue maintenance overhauls being offered on such ships.

For me this is a bug, as it's rather crippling doing anything script-wise with sub-entities.

[Kaks]

Sounds like a bug indeed... will post back when fixed!

[DaddyHoggy]

Sounds like a bug indeed... will post back when fixed!

I admire the man's confidence.

[another_commander]

This bug should be fixed on r4594. Please check tonight's nightly build.

[Capt. Murphy]

That seems to have done the trick my end another_commander. I see that removal still reduces ship_trade_in_factor by 3 for each subent, but that restoration now adds it back in, which is now observed behaviour in game for the Vortex. I've repeated earlier tests with debug console and done a few test flights and no spurious maintenance offers.

Do I get a prize for the quickest download of a new nightly build.....

Oolite Nightly Build Status (Windows)

Generated on Sun Aug 14 02:51:18 UTC 2011

Map

Last successful build

Oolite-Windows x86 (getafix@dwarf) SVN Revision: 4594
Build date: Sun Aug 14 02:51:17 UTC 2011