Can older deprecation alerts be switched back on for the log

[Lestradae]

I guess this is a question for the devs ...

Can older deprecation alerts be switched back on for the error log? I mean, anything that has been deprecated in 1.75.1 since 1.70 upwards?

It would be very useful if that was possible - thanks in advance for any useful answer.

[JensAyton]

All previously deprecated JavaScript functionality has been completely removed. Many of the compatibility shims were implemented in JavaScript, and you could find them by digging through the revision history of oolite-global-prefix.js. The old implementations might not work in 1.75.1, though.

[Kaks]

Ugh, the cull has been impressive, the best thing to do is to feed us a list of the various errors you have on the log - maybe in small doses, to avoid overwhelming us - and we should be able to give you the MNSR equivalents without too much trouble.

[Commander McLane]

Ugh, the cull has been impressive, the best thing to do is to feed us a list of the various errors you have on the log - maybe in small doses, to avoid overwhelming us - and we should be able to give you the MNSR equivalents without too much trouble.

Or look them up in the documentation. In most cases it's fairly evident what the new name of a method or property is.

[Lestradae]

Ugh, the cull has been impressive, the best thing to do is to feed us a list of the various errors you have on the log - maybe in small doses, to avoid overwhelming us - and we should be able to give you the MNSR equivalents without too much trouble.

Thanks all for the answers ... yes, that would be very nice, will see to it that I feed in small doses

My problem lies less with changing to the newer and actualised equivalents, I was more wondering if I could get the older deprecations written to the log at all - the way I understand it, things that were deprecated after 1.73 gave a warning in the 1.74 log but will no longer show up as deprecation warning in a 1.75 log - or am I mistaken there?

And I would like to be alerted about any and all deprecations as far back as 1.70, if at all possible.

As to how to change deprecations then ...

look them up in the documentation. In most cases it's fairly evident what the new name of a method or property is.

... this.

[JensAyton]

My problem lies less with changing to the newer and actualised equivalents, I was more wondering if I could get the older deprecations written to the log at all - the way I understand it, things that were deprecated after 1.73 gave a warning in the 1.74 log but will no longer show up as deprecation warning in a 1.75 log - or am I mistaken there?

It depends. If you try to call a non-existent method, like player.ship.wibble(), you’ll get an error. If you try to define an obsolete event handler, you won’t, because you can create properties with just about any name you want.

[Commander McLane]

For event handler you could sort of test them by inserting a log line into each of them.

Say you have something like

Code: Select all

this.shipDestroyedTarget = function(target)
{
    // do stuff
}

and are not certain if it's still working (in this case it isn't).

Then just insert a log message

Code: Select all

this.shipDestroyedTarget = function(target)
{
    log("test", "shipDestroyedTarget is working");
    // do stuff
}

and make a ship with this script destroy a target. If you get

Code: Select all

shipDestroyedTarget is working

in your log, the handler has fired correctly. If you don't, it hasn't.

(The example shipDestroyedTarget was actually replaced. Looking it up in the Wiki you see that there is now a handler named shipTargetDestroyed, which is the same thing with a new name.)

Or you go through all release notes since whenever you stopped developing your OXPs. All release notes list which old event handlers got replaced with which new handlers. Then you can open your script and perform a find&replace for one after the other. Perhaps this would be the most efficient method.

[Lestradae]

Both (McLane) suggestions are good and after I read what Ahruman had to say probably this ...

Or you go through all release notes since whenever you stopped developing your OXPs. All release notes list which old event handlers got replaced with which new handlers. Then you can open your script and perform a find&replace for one after the other. Perhaps this would be the most efficient method.

... is going to be my strategy.

I hoped the old deprecation alerts could perhaps somehow be switched back on, that would have been easier & faster on me - but meh, I'll do as suggested.

Cheers & thanks for the help

L

[JensAyton]

This script will notify you of deprecated event handlers. You’ll need to fill in the list yourself, though.

Code: Select all

"use strict";

this.name = "deprecation-warnings";


(function() {
    const deprecated =
    {
        deprecatedEvent: "newEvent",
        deprecatedEvent2: "newEvent2"
    };
    
    for (var deprecatedName in deprecated)
    {
        if (deprecated.hasOwnProperty(deprecatedName))
        {
            var newName = deprecated[deprecatedName];
            createDeprecationHandler(deprecatedName, newName);
        }
    }
    
    function createDeprecationHandler(deprecatedName, newName)
    {
        Object.defineProperty(Script.prototype, deprecatedName,
        {
            get: function () { return this[newName]; },
            set: function (value)
            {
                log("js.deprecated", "Event handler " + deprecatedName + " is deprecated. Use " + newName + " instead.");
                this[newName] = value;
            }
        });
    }
})();

[Gimi]

How about installing old versions of Oolite on memory sticks or something similar. Not the ideal solution, but should be feasible if there are specific errors messages you are looking for.