Broken OXPs in Oolite 1.75.x

Discussion and information relevant to creating special missions, new ships, skins etc.

Moderators: winston, another_commander

Post Reply
User avatar
Cmdr Wyvern
---- E L I T E ----
---- E L I T E ----
Posts: 1649
Joined: Tue Apr 11, 2006 1:47 am
Location: Somewhere in the great starry void

Broken OXPs in Oolite 1.75.x

Post by Cmdr Wyvern »

So far, I have OXPs which no longer work in 1.75.

- Bounty Scanner
- Fuel Collector
- Missile Analyzer

Edit: After a test - fresh Jameson Cobby with the latest version of the Analyzer installed - I can confirm it does what it says on the tin. It correctly identified the fragmentation missile that shot me down.

Edit2: Bounty Scanner v2.0 works as promised on 1.75.1 Trying to fix Fuel Collector - No joy so far...


Any others, folks?
Last edited by Cmdr Wyvern on Thu Apr 28, 2011 9:57 pm, edited 2 times in total.
Running Oolite buttery smooth & rock stable w/ tons of eyecandy oxps on:
ASUS Prime X370-A
Ryzen 5 1500X
16GB DDR4 3200MHZ
128GB NVMe M.2 SSD (Boot drive)
1TB Hybrid HDD (For software and games)
EVGA GTX-1070 SC
1080P Samsung large screen monitor
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: Broken OXPs in Oolite 1.75.x

Post by Commander McLane »

You can add Cataclysm and Personalities to your list. Cataclysm needs a complete overhaul, and Personalities is only working partially (the personalities still appear, but their behaviours are broken, especially in combat).
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Re: Broken OXPs in Oolite 1.75.x

Post by Eric Walch »

Cmdr Wyvern wrote:
So far, I have three OXPs which no longer work in 1.75.
...
- Missile Analyzer

Any others, folks?
According to the wiki is the current version 1.2 compatible with Oolite 1.75. And I can't remember having a problem with it.
User avatar
Gimi
---- E L I T E ----
---- E L I T E ----
Posts: 2073
Joined: Tue Aug 29, 2006 5:02 pm
Location: Norway

Re: Broken OXPs in Oolite 1.75.x

Post by Gimi »

Bounty Scanner broken in 1.75?
Odd, I get bounty values on targeted ships in trunk. I can't remember that ever being broken. Something I missed?
"A brilliant game of blasting and trading... Truly a mega-game... The game of a lifetime."
(Gold Medal Award, Zzap!64 May 1985).
User avatar
Capt. Murphy
Commodore
Commodore
Posts: 1127
Joined: Fri Feb 25, 2011 8:46 am
Location: UK South Coast.

Re: Broken OXPs in Oolite 1.75.x

Post by Capt. Murphy »

No problem with Bounty Scanner (version 2) my end either.

Fuel Collector is broken, and Missile Analyser has been confirmed as OK (I don't have it installed though).

A list of 1.75 working, non-working and TBC OXP's is here......
http://wiki.alioth.net/index.php/OXP_List
[EliteWiki] Capt. Murphy's OXPs
External JavaScript resources - W3Schools & Mozilla Developer Network
Win 7 64bit, Intel Core i5 with HD3000 (driver rev. 8.15.10.2696 - March 2012), Oolite 1.76.1
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: Broken OXPs in Oolite 1.75.x

Post by Commander McLane »

Yeah, both right. Missile analyser 1.2 and Bounty scanner 2.0 do work with Oolite beta 1.75.1.

Only Fuel collector 0.06 doesn't. But you can relatively easily fix it by replacing the deprecated methods with their current counterparts:

Code: Select all

this.theplayer.hasEquipment("XYZ")  ==>  this.theplayer.equipmentStatus("XYZ") === "EQUIPMENT_OK"
!this.theplayer.hasEquipment("XYZ")  ==>  this.theplayer.equipmentStatus("XYZ") !== "EQUIPMENT_OK"
I think that's even the only one.

Other than that there are only the typos in the consoleMessages to fix, but those don't prevent it from working anyway.
User avatar
Cmdr Wyvern
---- E L I T E ----
---- E L I T E ----
Posts: 1649
Joined: Tue Apr 11, 2006 1:47 am
Location: Somewhere in the great starry void

Re: Broken OXPs in Oolite 1.75.x

Post by Cmdr Wyvern »

Capt. Murphy wrote:
No problem with Bounty Scanner (version 2) my end either.

Fuel Collector is broken, and Missile Analyser has been confirmed as OK (I don't have it installed though).

A list of 1.75 working, non-working and TBC OXP's is here......
http://wiki.alioth.net/index.php/OXP_List
Thanks, that helped with my updating quite a lot. :D 8)
Commander McLane wrote:
Yeah, both right. Missile analyser 1.2 and Bounty scanner 2.0 do work with Oolite beta 1.75.1.

Only Fuel collector 0.06 doesn't. But you can relatively easily fix it by replacing the deprecated methods with their current counterparts:

Code: Select all

this.theplayer.hasEquipment("XYZ")  ==>  this.theplayer.equipmentStatus("XYZ") === "EQUIPMENT_OK"
!this.theplayer.hasEquipment("XYZ")  ==>  this.theplayer.equipmentStatus("XYZ") !== "EQUIPMENT_OK"
I think that's even the only one.
I tried that, but no joy. :( I'm of the mind that there's a lot more broken in the code than just equipment checks. What makes trying to fix it a bugbear is that the problem(s) aren't being reported in the log. I'm not too happy about that... Oh well, till a far better script wiz than stupid ol' me comes along and takes a spanner to this thing, I'll compensate with my fuel scoop, a drop tank or two, and stops at the refuel station.
Running Oolite buttery smooth & rock stable w/ tons of eyecandy oxps on:
ASUS Prime X370-A
Ryzen 5 1500X
16GB DDR4 3200MHZ
128GB NVMe M.2 SSD (Boot drive)
1TB Hybrid HDD (For software and games)
EVGA GTX-1070 SC
1080P Samsung large screen monitor
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: Broken OXPs in Oolite 1.75.x

Post by Commander McLane »

Cmdr Wyvern wrote:
Commander McLane wrote:

Code: Select all

this.theplayer.hasEquipment("XYZ")  ==>  this.theplayer.equipmentStatus("XYZ") === "EQUIPMENT_OK"
!this.theplayer.hasEquipment("XYZ")  ==>  this.theplayer.equipmentStatus("XYZ") !== "EQUIPMENT_OK"
I think that's even the only one.
I tried that, but no joy. :( I'm of the mind that there's a lot more broken in the code than just equipment checks. What makes trying to fix it a bugbear is that the problem(s) aren't being reported in the log.
Strange. I don't think I did anything else than these exchanges (and I did it back in 1.74), and I'm happily using the fuel collector all the time. Also, all non-existing JS-methods should give error messages in the log. The deprecated methods even give error messages which tell you exactly what to do to fix them.

Could it be that your FuelCollector.oxp uses a max_version in requires.plist? Mine doesn't, though. Is the script listed among the loaded scripts at the beginning of the log?
CmdrJmsn

Re: Broken OXPs in Oolite 1.75.x

Post by CmdrJmsn »

Hi,

Sorry for using an "BugMeNot" login; I'll register if I have more to say/contribute.

I'm running oolite 1.75.x as recommanded. I've found two broken OXPs:
  • Personalities 0.9 generates an exception in the log. One must replace "system" with "System" when calling the function "systemNameForID" in personalities.js. I actually don't know if it was preventing it from working, neither if the fix actually solves the issue (but at least the exception disappears)
  • Famous Planets 2.5 causes a CTD when going to the Onirira system. This is caused by a typo in planetinfo.plist ("onira.png" instead of "onirira.png")
I'm a bit surprised to find such obvious mistakes in famous OXPs. Do I do something wrong?

However, many thanks to the various authors for their great jobs.
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Re: Broken OXPs in Oolite 1.75.x

Post by Cody »

Commander McLane wrote:
Personalities is only working partially (the personalities still appear, but their behaviours are broken, especially in combat).
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
User avatar
Lestradae
---- E L I T E ----
---- E L I T E ----
Posts: 3095
Joined: Tue Apr 17, 2007 10:30 pm
Location: Vienna, Austria

Re: Broken OXPs in Oolite 1.75.x

Post by Lestradae »

CmdrJmsn wrote:
I'm a bit surprised to find such obvious mistakes in famous OXPs. Do I do something wrong?
Well, I'd guess the expectation that a big oxp can be created without unintentionally inserting one or the other bug into it might be the mistake in your reasoning :wink:
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: Broken OXPs in Oolite 1.75.x

Post by Commander McLane »

CmdrJmsn wrote:
Hi,

Sorry for using an "BugMeNot" login; I'll register if I have more to say/contribute.

I'm running oolite 1.75.x as recommanded. I've found two broken OXPs:
  • Personalities 0.9 generates an exception in the log. One must replace "system" with "System" when calling the function "systemNameForID" in personalities.js. I actually don't know if it was preventing it from working, neither if the fix actually solves the issue (but at least the exception disappears)
    ...

    I'm a bit surprised to find such obvious mistakes in famous OXPs. Do I do something wrong?
First of all, thanks for calling Personalities.oxp famous. :D

It's not a mistake. Personalities 0.9 was released for Oolite 1.73. Since then there were changes to the JS-syntax.

That's why Personalities.oxp is not marked as working with Oolite 1.75 in the [wiki]OXP List[/wiki]. A version working with Oolite 1.75 will be released in due time.
User avatar
Kaks
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 3009
Joined: Mon Jan 21, 2008 11:41 pm
Location: The Big Smoke

Re: Broken OXPs in Oolite 1.75.x

Post by Kaks »

And Gnudoll found exactly the same problem as you with famous planets, you should be able to find that post easily enough, and it does say there what needs to be done to correct the OXP. You'll be pleased to know that the Trunk downloads (and future Oolite releases) don't crash anymore with that one. :)
Hey, free OXPs: farsun v1.05 & tty v0.5! :0)
Post Reply