legacy script actions not working in trunk (4496)

[Commander McLane]

... and possibly also not in 1.75 otherwise.

I just checked for the ETT Homing Beacon. It has these script actions:

Code: Select all

		<key>script_actions</key>
		<array>
			<string>testForEquipment: EQ_BEACONLAUNCHER_MINE</string>
			<dict>
				<key>conditions</key>
				<array>
					<string>foundEquipment_bool equal NO</string>
				</array>
				<key>do</key>
				<array>
					<string>awardEquipment: EQ_BEACONLAUNCHER_MINE</string>
				</array>
				<key>else</key>
				<array>
					<string>awardCargo: 25 Gold</string>
				</array>
			</dict>
		</array>

which are also transferred to its ship script:

Code: Select all

> PS.target.script.legacy_scriptActions
["testForEquipment: EQ_BEACONLAUNCHER_MINE", {
    "else": ["awardCargo: 25 Gold"],
    conditions: ["foundEquipment_bool equal NO"],
    "do": ["awardEquipment: EQ_BEACONLAUNCHER_MINE"]
}]

(I am wondering about the sorting, though).

But it doesn't do anything when scooped. I am neither awarded the mine nor gold. Just nothing. Don't know what's wrong here, but it could probably affect other legacy script actions, too.

It used to work in 1.65.

[JensAyton]

(I am wondering about the sorting, though).

What sorting? Dictionaries are unordered, you know that.

Anyway, fixed in r4501.