{UPDATED RELEASE}-Illegal Goods Tweak v1.7.3(30/5/12)

Discussion and information relevant to creating special missions, new ships, skins etc.

Moderators: winston, another_commander

User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: {RELEASE} - Illegal Goods Tweak.oxp

Post by Commander McLane »

Fatleaf wrote:
But now and then when you scoop a pod the message reads "you have scooped/captured a slave" and when they register as 1 ton of slaves in your hold.
That's the pods without a character in them I referred to.

I've forgotten the specifics about when and why those pods are created. I think they're the result of buggy OXPs. Eric knows certainly more on the subject.
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Re: {RELEASE} - Illegal Goods Tweak.oxp

Post by Eric Walch »

Commander McLane wrote:
The rule is simple:

pod from non-clean ship: bounty
pod from clean ship: insurance money

(Since 1.75 Oolite handles two mixed cases as well, where part of the insurance money is used to bribe the local authorities in order to get a non-clean pilot free, or a seemingly clean pilot is taken into custody anyway.)

In any case they don't end up as slaves. Only pods without a character in them do.
Fatleaf wrote:
But now and then when you scoop a pod the message reads "you have scooped/captured a slave" and when they register as 1 ton of slaves in your hold.
That's the pods without a character in them I referred to.

I've forgotten the specifics about when and why those pods are created. I think they're the result of buggy OXPs. Eric knows certainly more on the subject.
Oolite adds pilots to ships with bounty, insurance, both or none at all. The exact values depend a bit on the ship role. Pirate pilots always have a bounty, while traders often are ensured. Bounty hunters are rarely insured. On scooping all pilots are added as slaves to the inventory.

On docking, you get your rewards/bounties for the pilots and the pilots are removed from your inventory. Only pilots without bounty/insurance stay as slaved in your hold. But on ejecting, a pilot also inherits part of the ships bounty. That means that such pilots always have a bounty and never end up as slaves after docking.

Some pilots can have both bounty and insurance. Before 1.75, one of the two was just ignored. (albeit wrong as scooping and docking used different values when both were present) Ignoring one value felt somehow wrong, so since 1.75 both values are mentioned on docking, but handled a bit different in high/low governments.

(NB Pilot bounty and ship bounty are two different things.)

The oxp uses the shipDockedWithStation() handler. When this one fires, the Pilots with bounty/insurance are already removed from the inventory. That means the player can still scoop escape pods, as long as he dumps them again when the "scooped slave" message appears.
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: {RELEASE} - Illegal Goods Tweak.oxp

Post by Commander McLane »

Eric Walch wrote:
The oxp uses the shipDockedWithStation() handler. When this one fires, the Pilots with bounty/insurance are already removed from the inventory.
Ah! So I was wrong. I was under the impression that shipDockedWithStation would fire before the report screen is shown, and therefore before the inventory is cleared. That's why I suggested reportScreenEnded as an alternative.
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Re: {RELEASE} - Illegal Goods Tweak.oxp

Post by Eric Walch »

Commander McLane wrote:
Ah! So I was wrong. I was under the impression that shipDockedWithStation would fire before the report screen is shown, and therefore before the inventory is cleared. That's why I suggested reportScreenEnded as an alternative.
You were not wrong, the report screen is shown after the shipDockedWithStation fires, but the contents of the reportscreen is already created as text between the shipWillDockWithStation and shipDockedWithStation handlers.
User avatar
Capt. Murphy
Commodore
Commodore
Posts: 1127
Joined: Fri Feb 25, 2011 8:46 am
Location: UK South Coast.

Re: {RELEASE} - Illegal Goods Tweak v1.1

Post by Capt. Murphy »

Version 1.1 is uploaded and ready to run. First post has been edited to include the new readme and download link.

Eric - thanks for clarifying the escape pod treatment - I've been testing this morning and it all works OK. If you have purchased slaves and scooped escape pod slaves in your hold when you dock the scooped escape pod slaves are removed from the manifest before my script runs, and the insurance/bounty report screen pops up after my two mission screens are finished.

The only slight issue is that the insurance/bounty report screen may report that cargo that's been handed over is still in the hold when it's not. It's only a cosmetic issue but any suggestions as to how I can script to get my mission screens to run after any insurance/bounty report screen has run? Using reportScreenEnded as a condition doesn't work as this breaks the rest of the OXP if no scooped pods are in the hold.
[EliteWiki] Capt. Murphy's OXPs
External JavaScript resources - W3Schools & Mozilla Developer Network
Win 7 64bit, Intel Core i5 with HD3000 (driver rev. 8.15.10.2696 - March 2012), Oolite 1.76.1
User avatar
Capt. Murphy
Commodore
Commodore
Posts: 1127
Joined: Fri Feb 25, 2011 8:46 am
Location: UK South Coast.

Re: {RELEASE} - Illegal Goods Tweak v1.1

Post by Capt. Murphy »

A couple of screenies from version 1.1

Image

Image

Image
[EliteWiki] Capt. Murphy's OXPs
External JavaScript resources - W3Schools & Mozilla Developer Network
Win 7 64bit, Intel Core i5 with HD3000 (driver rev. 8.15.10.2696 - March 2012), Oolite 1.76.1
User avatar
Smivs
Retired Assassin
Retired Assassin
Posts: 8408
Joined: Tue Feb 09, 2010 11:31 am
Location: Lost in space
Contact:

Re: {RELEASE} - Illegal Goods Tweak v1.1

Post by Smivs »

:) :D :lol:
Commander Smivs, the friendliest Gourd this side of Riedquat.
User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Re: {RELEASE} - Illegal Goods Tweak v1.1

Post by JensAyton »

“target practice”.
User avatar
Fatleaf
Intergalactic Spam Assassin
Intergalactic Spam Assassin
Posts: 1988
Joined: Tue Jun 08, 2010 5:11 am
Location: In analysis mode on Phaelon
Contact:

Re: {RELEASE} - Illegal Goods Tweak v1.1

Post by Fatleaf »

But how can you be a fugitive with only 40cr bounty? I thought it was 51cr and above that you were fugitive. Shouldn't it read "Offender status".

One more question. Does it work with Items in the Hyper cargo hold?
Find out about the early influences of Fatleaf here. Also his OXP's!
Holds the Ooniversal record for "Thread Necromancy"
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: {RELEASE} - Illegal Goods Tweak v1.1

Post by Commander McLane »

Fatleaf wrote:
But how can you be a fugitive with only 40cr bounty? I thought it was 51cr and above that you were fugitive. Shouldn't it read "Offender status".
Depends. If he had a bounty of 11 or more before, he would be fugitive now. 8)

I take it the code checks for the current bounty and puts the correct status in the message?
User avatar
Capt. Murphy
Commodore
Commodore
Posts: 1127
Joined: Fri Feb 25, 2011 8:46 am
Location: UK South Coast.

Re: {RELEASE} - Illegal Goods Tweak v1.1

Post by Capt. Murphy »

Indeed it does, Test had just launched from Riedquat with 20 tons of Narcotics in the hold and then redocked so had a 40 bounty from the launch and another 40 from the redock to give him 80 bounty.....the message reads the [commander_legal_status] flag.

Don't know about hypercargo - will do some testing tomorrow.
[EliteWiki] Capt. Murphy's OXPs
External JavaScript resources - W3Schools & Mozilla Developer Network
Win 7 64bit, Intel Core i5 with HD3000 (driver rev. 8.15.10.2696 - March 2012), Oolite 1.76.1
User avatar
Thargoid
Thargoid
Thargoid
Posts: 5528
Joined: Thu Jun 12, 2008 6:55 pm

Re: {RELEASE} - Illegal Goods Tweak v1.1

Post by Thargoid »

Unless your OXP does anything to specifically test for items stored in the Hypercargo mission variables then no, your OXP won't see anything stored there. It's not too difficult to do though - if you want to do it and need any help then let me know.
User avatar
CheeseRedux
---- E L I T E ----
---- E L I T E ----
Posts: 827
Joined: Fri Oct 02, 2009 6:50 pm

Re: {RELEASE} - Illegal Goods Tweak v1.1

Post by CheeseRedux »

Ah, there's Thargoid with a more precise version of the answer I was about to give...

Anyway. Question: What are the odds of this thing kicking in when landing? Is there a 100% detection rate? That, in my mind, is just as bad as the old 0% rate. Come to think of it, a detection rate based on government type would make sense. Though the Station is GalCop territory and thus officially not influenced by the planetary government (or lack thereof), anyone who's ever taken an occasional glance at the Real World knows that's not how things work.

This gives rise to another thought: Assuming the detection rate is less than 100%, a way of voluntarily releasing non-detected slaves would be nice. This may be beyond the scope of the OXP, but if there was a way to free slaves whenever you wanted to, you could actually roleplay a commander whose whole career was dedicated to freeing slaves, flying from station to station, purchasing all available slaves (if credits allow it) and instantly releasing them. That would make earning a profit a daunting prospect, but hey, if DH can play a pacifist, why shouldn't you be able to play an abolitionist?
"Actually this is a common misconception... I do *not* in fact have a lot of time on my hands at all! I just have a very very very very bad sense of priorities."
--Dean C Engelhardt
User avatar
Mauiby de Fug
---- E L I T E ----
---- E L I T E ----
Posts: 847
Joined: Tue Sep 07, 2010 2:23 pm

Re: {RELEASE} - Illegal Goods Tweak v1.1

Post by Mauiby de Fug »

A rate depending on the government type would make sense to me. I haven't installed this oxp yet, as I do like to sell contraband (mainly stuff scooped up, but I'm not averse to picking up cheap narcotics for a couple of credits at a constore and selling them on for a hundred). If the detection rate were based on government type, you'd be better off selling illegal items in Anarchy/Feudal State systems, adding more realism.

I've always assumed that the majority of the GalCop staff in a system came from the planet(s) in that system, so would be bound to be influenced in some way or other (though not officially) by what happens on the planet below.
User avatar
Okti
---- E L I T E ----
---- E L I T E ----
Posts: 700
Joined: Sun Sep 26, 2010 1:51 pm
Location: A GH shop, near witchpoint to Oresrati in Galaxy 8

Re: {RELEASE} - Illegal Goods Tweak v1.1

Post by Okti »

Capt. Murphy wrote:
Don't know about hypercargo - will do some testing tomorrow.
Don't forget Vortex as well, because it has 5 switchable cargo bays. :(
My OXP's
And Latest Mission Coyote's Run
Post Reply