targeting distant entities

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

targeting distant entities

Post by Commander McLane »

There is an inconsistency in the JS-targeting mechanism which I find distinctly odd.

Usually both NPCs and the player can only target other entities within scanner range. If the target leaves scanner range, it is lost. This behaviour feels sensible.

However, the JS target property overrides this sensible behaviour. If you are at the witchpoint, both system.mainStation.target=player.ship and player.ship.target=system.mainStation work and actually set the respective entity's primary target. The main station becomes visible on screen with a reticle instantly, no matter how far away it is. (There are a couple of screen shots around which show ridiculously distant targets with a reticle.) Targets acquired this way aren't lost anymore, except by targeting something else. To me this feels wrong. Can something be done about it? I think the attempt to target something outside scanner range of the targeting entity in JS should return false.
Zireael
---- E L I T E ----
---- E L I T E ----
Posts: 1396
Joined: Tue Nov 09, 2010 1:44 pm

Re: targeting distant entities

Post by Zireael »

Commander McLane wrote:
Usually both NPCs and the player can only target other entities within scanner range. If the target leaves scanner range, it is lost. This behaviour feels sensible.
It's not always true. I've had something targeted, then it flew off my scanner on injectors, and sometimes I had it targeted still. At ~30 kms away! (Happens rarely and with no rule to it)
I think the attempt to target something outside scanner range of the targeting entity in JS should return false.
Maybe it'd fix the above?
User avatar
Cmd. Cheyd
---- E L I T E ----
---- E L I T E ----
Posts: 934
Joined: Tue Dec 16, 2008 2:52 pm
Location: Deep Horizon Industries Manufacturing & Research Site somewhere in G8...

Re: targeting distant entities

Post by Cmd. Cheyd »

McLane - I would LOVE to know how you got this to happen. I attempt to assign player.ship.target=system.mainStation via the console, and I instantly get 'Target Lost'. I have even opened this as a Feature Request. You have it happening and want it to return false, and I can't get it to happen and want it as an optional behavior. :lol:
User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Re: targeting distant entities

Post by JensAyton »

Bug #18011

A property assignment can’t “return” anything. Its value is always the right hand side of the assignment.
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: targeting distant entities

Post by Commander McLane »

I just tried it again, and it worked.

However, I noticed that there is one condition: It only works with de-activated targeting system ('U'). If I press 'R' to activate the targeting system I also get the instant 'Target lost'. Also if I first have targeted the station and then press 'R', the target is lost immediately.

In other words: the player ship can target distant entities if (and only if) the targeting system is not active. This is a contradiction in terms, therefore it clearly seems a bug to me.
User avatar
Smivs
Retired Assassin
Retired Assassin
Posts: 8408
Joined: Tue Feb 09, 2010 11:31 am
Location: Lost in space
Contact:

Re: targeting distant entities

Post by Smivs »

Quantum Targeting Systems, how clever :D
Commander Smivs, the friendliest Gourd this side of Riedquat.
User avatar
Frame
---- E L I T E ----
---- E L I T E ----
Posts: 1477
Joined: Fri Mar 30, 2007 8:32 am
Location: Witchspace

Re: targeting distant entities

Post by Frame »

Commander McLane wrote:
I just tried it again, and it worked.

However, I noticed that there is one condition: It only works with de-activated targeting system ('U'). If I press 'R' to activate the targeting system I also get the instant 'Target lost'. Also if I first have targeted the station and then press 'R', the target is lost immediately.

In other words: the player ship can target distant entities if (and only if) the targeting system is not active. This is a contradiction in terms, therefore it clearly seems a bug to me.
I just tried the above... Lost Target, target system NOT active.
Last edited by Frame on Mon Mar 21, 2011 8:57 pm, edited 1 time in total.
Bounty Scanner
Number 935
User avatar
Mauiby de Fug
---- E L I T E ----
---- E L I T E ----
Posts: 847
Joined: Tue Sep 07, 2010 2:23 pm

Re: targeting distant entities

Post by Mauiby de Fug »

That'll possibly explain things like this then:
Image

I use the Target Autolock oxp, but usually have the targeting system active anyway. Presumably it happens when I'm fired upon, whilst the target system is inactive, and then run away...?
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6683
Joined: Wed Feb 28, 2007 7:54 am

Re: targeting distant entities

Post by another_commander »

Frame wrote:
I just tried the above... Lost Target, target system NOT active.
Same here. McLane, what OXPs do you have installed?
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: targeting distant entities

Post by Commander McLane »

another_commander wrote:
Frame wrote:
I just tried the above... Lost Target, target system NOT active.
Same here. McLane, what OXPs do you have installed?

Code: Select all

    /Applications/Spiele/Oolite beta 1.75.1/Oolite.app/Contents/Resources
    /Applications/Spiele/Oolite beta 1.75.1/AddOns
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/aegidian-special.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Amen Bricks Megaships.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Anarchies2.5.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Aquatics 1.04.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/AsteroidStorm 4.01.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/att1.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/auto_eject.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/behemoth 2.6.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/BGS-I1.3.2.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/bigtrader.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/bioSphere.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/BlOomberg Markets v2.1.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/BountyScannerv2.0.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/buoyRepair1.02.7.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Cabal_Common_Library1.2.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Cargo_wrecks_teaser 1.6.5.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Cataclysm.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/cobra_courier.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Commies.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Debug.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/deutschesOolite.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Dictators v1.3.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/dwcobra3.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Energy Equipment 1.11.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/ettBeaconLauncher.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Executive Spaceways v2.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Famous_Planets_v1.1.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/fireworks.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/flying_Dutchman.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Fuel Station 1.32.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Fuel Tank v2.0.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/FuelCollectorV0.06.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Generation Ships 1.2.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/ghostsfromthepast.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/globestation2.0.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Hud.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/impcourier2.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/interstellar_help.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/jabberwocky.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Killit.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/military Fiasco 2.5.2.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/milmissile.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Missile Analyser 1.2.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Missiles and Bombs v2.3.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Missionaries.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/mycobra35.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/neocaduceus.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/nukes0.97.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/oldships.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Ore_processor 1.58.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/outrider.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/PAGroove_Stations_v1.2.1.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Personalities.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Personalities_set_A.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Pods 1.22.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/PTI.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/RandomHits1.4.7.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/renegades.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Rock_Hermit_Locator1.3.2.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Scoop Positions.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/SecondWave 1.32.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/sell_equipment.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Snoopers2.1.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Snoopers2.x_gal2.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Status_Quo_Q-bomb.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Stellar Serpents 1.11.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/sunskimmers.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/supercobra 1.4.2.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Superhubv1.0.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/System_Redux.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/TAF_reset.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/thargoid_carrier3.0.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Thargorn_Threat 1.5.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/The Feudal States v1.4.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Tianve1.3.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/tiger.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/total_patrol.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/transports 2.46.oxp
    /Applications/Spiele/Oolite beta 1.75.1/AddOns/Vector1.5.oxp
However, it works also with only Debug.oxp and impcourier2.oxp installed. Can it be OS-dependent?
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: targeting distant entities

Post by Commander McLane »

Strange. I also removed impcourier2.oxp, only leaving Debug.oxp, and started with a new Jameson.

Jumping out of Lave, I get this:

Code: Select all

> PS.target=S.mainStation
[Station "Coriolis Station" "Coriolis Station" position: (-58966.1, 8143.57, 353965) scanClass: CLASS_STATION status: STATUS_ACTIVE]
followed by an instant "Target lost".

So the reason for the behaviour must be in my ship OXP (and presumably in other ship OXPs as well).

Or possibly in some combination of equipment I have on my Imperial Courier. Must be vanilla equipment, though, as I had all equipment-related OXPs deactivated.
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6683
Joined: Wed Feb 28, 2007 7:54 am

Re: targeting distant entities

Post by another_commander »

Replicated it with the Imperial Courier here too. OK, we seem to have a lead. Let's try to see now what it is inside the Courier that causes the bug to occur.

Edit: Actually, it is your save game, not the Imperial Courier. I changed the ship in the savefile to a standard Cobra and got the bug again.
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6683
Joined: Wed Feb 28, 2007 7:54 am

Re: targeting distant entities

Post by another_commander »

... and, we seem to have it tracked.

Test this please: Load up any savegame. Then, buy missiles and one quirium mine. Buy at any order you like.

Then, hyperspace and execute player.ship.target=system.mainStation with the first pylon selected. Repeat with second, third, etc.

If things are as I expect them to be, you should be able to trigger the bug as soon as you execute the above command with the mine selected.
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: targeting distant entities

Post by Commander McLane »

Could be. I happen to have a Q-bomb on my first pylon. So it always happened for me.
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: targeting distant entities

Post by Commander McLane »

It works with a Fuel Tank selected, too. So I'd say the culprit is having selected any _MINE, not just EQ_QC_MINE.

Now, what about NPCs being able to target the player across the system?
Post Reply