bug in trunk

[harry747]

i have a weird bug related to money: if i save my game and then reload, i suddenly have 10 times as much money as before. right now i'm up to something like 80 Billion (yes, Billion) credits.

i tried without the OXPs, same thing. which means the bug is in oolite. i think i have revision 4422, but the bug was also there in the last few revisions.

[Eric Walch]

i have a weird bug related to money: if i save my game and then reload, i suddenly have 10 times as much money as before.

I didn't notice, but my save game also has 100 times as much credits as the second newest. I think we soon hit the limit of what can be displayed.
but that means it cant be around for long as it means I only saved twice since the introduction of the bug.

[TGHC]

i have a weird bug related to money: if i save my game and then reload, i suddenly have 10 times as much money as before. right now i'm up to something like 80 Billion (yes, Billion) credits.

Wow that means you had earned 8 billion credits, how the heck did you do that?
Is your real name Warren buffet?

[Eric Walch]

i think i have revision 4422, but the bug was also there in the last few revisions.

I checked with the latest nighty (r4412) there the save file was still okay.
Most likely would be:

Code: Select all

r4417 
Several fixes related to credits handling:
* When loading saved games, floating-point credits values go through the same
  clamping logic as JavaScript assignments. This fixes the equivalent problem
  of maximum credits values being treated as 0 on load.

Although on loading things look okay, it goes wrong on saving.

[Eric Walch]

I just remembered that I had yesterday in the latest log:

Code: Select all

[cheat.tentative] PlayerEntity.m:7652: POSSIBLE CHEAT DETECTED

I already wondered, as I never had edited the save game. But the one below it in my saved game folder was edited. At that time I just thought I opened the wrong file.

I now double checked. This message is now generated on opening such a corrupt file. At least when opening with the latest trunk. When opening the same file with vanilla 1.75 the credits are still okay.

EDIT:
The problem are the credits written as <real> in the plist. Older, pre 1.75 Oolite used <integer>. Those files open correct, but the files with the same number written as <real> are multiplied with 10 on opening.

[Zireael]

They're multiplied by 10 on 'reading' (see what shows when you choose your saved Commander).

And the bug was not there for r4402. I switched to the newest trunk, flew a nice contract (8000 for flying to a planet 0.2 ly away) and then my jaw fell down, because it showed I had over 2 mln credits.
I decided to check when does it fire up, and went to open the save I just did, and it showed 24 mln credits before I even opened it.

[another_commander]

This bug has been fixed in r4427.

[TGHC]

Damn I missed it, I was going to start a dozen new commanders