enterPlayerWormhole not working if wormhole in save-file

[TGHC]

Great collaboration fellas.

[another_commander]

Commander McLane's test allows me to replicate the problem on my system too. Deleting the wormhole part in the savefile makes everything work again.

[Micha]

Found the bug.
Saved wormholes don't have a Universal ID, neither does the Player's Wormhole, and the code uses the UIDs to ensure a wormhole isn't added multiple times.

My bad.

<edit>Fixed in r4402</edit>

[JensAyton]

Have I mentioned my dislike of universal IDs recently? :-)

[Commander McLane]

Removing the wormhole-key from my save-file allowed me to do some more tests, and I've run into another problem.

Sometimes the NPC simply won't follow. Especially the helpless traders from interstellar_help.oxp, for whom I'm doing the whole thing, won't.

Here's the relevant AI-state:

Code: Select all

    "FOLLOW_PLAYER" =     {
        "COURSE_OK" =         (
            "setSpeedFactorTo: 0.7",
            performFlyToRangeFromDestination
        );
        ENTER =         (
            setDestinationToTarget,
            "setDesiredRangeTo: 150",
            checkCourseToDestination
        );
        "PLAYER WITCHSPACE" =         (
            enterPlayerWormhole
        );
        UPDATE =         (
            setDestinationToTarget,
            checkCourseToDestination,
            "pauseAI: 2"
        );
    };

And here are the last couple of seconds worth of log-entries before my jump:

Code: Select all

23:36:14.618 [ai.takeAction]: Moray Medical Boat 1494 to take action setDestinationToTarget
23:36:14.618 [ai.takeAction]: Moray Medical Boat 1494 to take action checkCourseToDestination
23:36:14.618 [ai.takeAction]: Moray Medical Boat 1494 to take action pauseAI: 2
23:36:14.618 [ai.message.receive]: AI interstellarHelpAI.plist for Moray Medical Boat 1494 in state 'FOLLOW_PLAYER' receives message 'COURSE_OK'. Context: handling deferred message, stack depth: 0
23:36:14.618 [ai.takeAction]: Moray Medical Boat 1494 to take action setSpeedFactorTo: 0.7
23:36:14.618 [ai.takeAction]: Moray Medical Boat 1494 to take action performFlyToRangeFromDestination
23:36:16.619 [ai.takeAction]: Moray Medical Boat 1494 to take action setDestinationToTarget
23:36:16.619 [ai.takeAction]: Moray Medical Boat 1494 to take action checkCourseToDestination
23:36:16.619 [ai.takeAction]: Moray Medical Boat 1494 to take action pauseAI: 2
23:36:16.619 [ai.message.receive]: AI interstellarHelpAI.plist for Moray Medical Boat 1494 in state 'FOLLOW_PLAYER' receives message 'COURSE_OK'. Context: handling deferred message, stack depth: 0
23:36:16.619 [ai.takeAction]: Moray Medical Boat 1494 to take action setSpeedFactorTo: 0.7
23:36:16.619 [ai.takeAction]: Moray Medical Boat 1494 to take action performFlyToRangeFromDestination
23:36:17.187 [ai.message.receive]: AI interstellarHelpAI.plist for Moray Medical Boat 1494 in state 'FOLLOW_PLAYER' receives message 'PLAYER WITCHSPACE'. Context: global message, stack depth: 0
23:36:17.187 [ai.takeAction]: Moray Medical Boat 1494 to take action enterPlayerWormhole

After that, silence. Even if I wait for minutes.

The target inspector informs me that:

Code: Select all

Ship entity:
Status: STATUS_ENTERING_WITCHSPACE

AI:
Pending: ENTERED_WITCHSPACE
Think in: -(ever-growing number)
Behaviour: BEHAVIOUR_FLY_TO_DESTINATION
Frustration: 0

The pending AI message is never received or acted upon.

The obvious difference of this code to my test AI code is that this AI is following the player ship and therefore generally in behaviour BEHAVIOUR_FLY_TO_DESTINATION, while my test AI had a performIdle.

Does the performFlyToRangeFromDestination somehow prevent the pending AI message to become active, while the performIdle doesn't?

If so, is there a better way to make the ship 'escort' the player until he jumps out? Would for instance performIntercept be better than performFlyToRangeFromDestination?

[JensAyton]

The pending AI message is never received or acted upon.

Pending messages (and UPDATE) will never trigger for a ship that isn’t “in the universe” (which mostly means in-system, although there are special cases). The line “Moray Medical Boat 1494 to take action enterPlayerWormhole”, and the fact that it’s still in the inspector, means it’s in the wormhole, but I don’t know offhand how you can find out when it will emerge.

[Commander McLane]

The ordinary traders which I hijacked with my test AI emerged within a few seconds.

This ship has been in the wormhole for minutes. I don't think it's going to emerge. Could it be that its ship script is somehow stalled?