"We hope you enjoyed Lave station Commander Jameson"

Discussion and information relevant to creating special missions, new ships, skins etc.

Moderators: winston, another_commander

Post Reply
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

"We hope you enjoyed Lave station Commander Jameson"

Post by Commander McLane »

Which OXP is this consoleMessage from? I noticed that it isn't only displayed when I leave the main station, but any station in Lave, which doesn't make much sense.
User avatar
Svengali
Commander
Commander
Posts: 2370
Joined: Sat Oct 20, 2007 2:52 pm

Re: "We hope you enjoyed Lave station Commander Jameson"

Post by Svengali »

Commander McLane wrote:
Which OXP is this consoleMessage from? I noticed that it isn't only displayed when I leave the main station, but any station in Lave, which doesn't make much sense.
Could be Famous Planets, but if I remember right there was a check for the distance to system main station.
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: "We hope you enjoyed Lave station Commander Jameson"

Post by Commander McLane »

Yeah, I found it:

Code: Select all

this.shipLaunchedFromStation = function() 
	{
	if(this.fpCheck(system.ID) && system.mainStation) // if player launched from the main station in a FP system.
		{ 
		if(this.extraA) {player.consoleMessage("We hope you enjoyed " + system.name + " station Commander " + player.name) }; // display launch message
		...
No distance check. system.mainStation only checks if the system has a main station (every system has one, so it will always be true), not if the player launched from it.

Suggestion:

Code: Select all

this.shipLaunchedFromStation = function(station) 
	{
	if(this.fpCheck(system.ID) && station.isMainStation) // if player launched from the main station in a FP system.
		{ 
		if(this.extraA) {player.consoleMessage("We hope you enjoyed " + system.name + " station, Commander " + player.name + ".") }; // display launch message
		...
Note also the added punctuation in the consoleMessage.
User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Re: "We hope you enjoyed Lave station Commander Jameson"

Post by JensAyton »

Commander McLane wrote:
(every system has one, so it will always be true)
It’s now possible to launch from a carrier/station in interstellar space, so it won’t always be true.
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: "We hope you enjoyed Lave station Commander Jameson"

Post by Commander McLane »

Ahruman wrote:
Commander McLane wrote:
(every system has one, so it will always be true)
It’s now possible to launch from a carrier/station in interstellar space, so it won’t always be true.
Which means that with the current script the player won't be welcomed in an FP system, if he isn't in any system at all. This—at least—works as expected. :wink:
Post Reply