Savefile cleanup (and ship_name missing?)

[Zireael]

My commander dates all the way back to the 1.65 version of Oolite, though I'm now playing 1.75 trunk. (Copying it along with OXPs and changing OXPs if I have to)... When I tried to find ship_name, I did not find it. Additionally, I found some lines that refer to things I no longer have, like localhero (I don't think I even had it...). Can I somehow clean it up?

[Commander McLane]

It's an important point that save-files are fully upwards-compatible.

You can safely delete most of the mission variables of missions you finished. A well-scripted mission will do that all by itself.

In many cases you will find one mission variable with a value of MISSION_COMPLETE or something like this. This one you should never delete, because it helps other missions to determine if you have already played the mission in question. It also helps that you're not offered the mission again, should you re-install it.

[Zireael]

And the ship_name? Should it be there? If yes, why is it not there?

[Commander McLane]

I guess you're confusing something. There is no ship_name, and never was.

There is ship_desc, which contains the internal identifier for your ship, and player_name, which contains your commander's name.

The name of the ship is available through the display_name property of the ship specified with ship_desc.

[Zireael]

So what was the trick for naming your ship? Somebody mentioned ship_name just recently...

[Commander McLane]

The name of the ship is available through the display_name property of the ship specified with ship_desc.

[JensAyton]

I guess you're confusing something. There is no ship_name, and never was.

McLane, your absolute certainty in all things is a never-ending source of amusement. :-)

ship_name was added in 1.74, I believe. It’s used only to display the name of the ship type on the loading screen when the relevant OXP is not installed (and in Mac builds, it’s indexed by the Spotlight indexer). It isn’t used when actually loading a game.

[Zireael]

Well, I have no ship_name in my save...

[Commander McLane]

ship_name was added in 1.74, I believe. It’s used only to display the name of the ship type on the loading screen when the relevant OXP is not installed (and in Mac builds, it’s indexed by the Spotlight indexer). It isn’t used when actually loading a game.

I stand corrected.

Code: Select all

	...
	<key>ship_desc</key>
	<string>impcourier-player</string>
	<key>ship_kills</key>
	<integer>14477</integer>
	<key>ship_name</key>
	<string>Imperial Courier</string>
	<key>ship_trade_in_factor</key>
	<integer>87</integer>
	...

Seems I should've looked into my 1.74.2 save file, not only in one from 1.65.

Still, if you want to give your ship a unique name, you have to use the name or display_name key in its shipdata.

[Zireael]

So why not put (after MSNR) something in the savefile that allows you to name your ship without editing its shipdata? I know it's not in the original Elite, but then, buying ships was not either

[Alex]

I stand corrected.

Code:
...
<key>ship_desc</key>
<string>impcourier-player</string>
<key>ship_kills</key>
<integer>14477</integer>
<key>ship_name</key>
<string>Imperial Courier</string>
<key>ship_trade_in_factor</key>
<integer>87</integer>
...

Seems I should've looked into my 1.74.2 save file, not only in one from 1.65.

Still, if you want to give your ship a unique name, you have to use the name or display_name key in its shipdata.

I'm using 1.74.2 on XP.

I've been trying to do the same for my ship. It just doesn't seem work in the saved file under "ship_name".
There is a 'No Found' message using notepad++ for "display_name" in the saved game file?

Is the ship data in the add on file for the type of ship?
My ship is an oxp (caddy omeg, what a ship!).

[Cody]

Alex... can you post the section from your save file that corresponds to the section above?
From ship clock.

[Alex]

This is from 'saved file';

<key>ship_desc</key>
<string>caduceus-omega-player</string>
<key>ship_kills</key>
<integer>12786</integer>
<key>ship_name</key>
<string>Gertrude Oblitz</string>
<key>ship_trade_in_factor</key>
<integer>97</integer>

But on load of saved file it doesn't show as named? It doesn't show as a saved file either, not that I expected that.
Ship name still shows as caduceus omega.
The <string>Gertrude Oblitz</string>
Is the edited and saved version, alas, it doesn'r show on re-starting the game.

[Cody]

Alex... change the name in the shipdata.plist of your player ship as well... that should do it.
Line 21 in my one.

Code: Select all

max_missiles = 4;	
	name = "Rolling Thunder";	
	missile_launch_position = "0.0 -13.7 21.06";

In fact, you don't need to change the save file at all... it picks it up when you save, after changing the shipdata.plist of your player ship.
Don't forget to restart holding shift down etc.

(Damn... I should've known that straight-off... my brain's slow this morning).

[Alex]

Ta heaps El V. Worked a treat