bug: extra weapons when buying ship

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
Zieman
---- E L I T E ----
---- E L I T E ----
Posts: 680
Joined: Tue Sep 01, 2009 11:55 pm
Location: in maZe

bug: extra weapons when buying ship

Post by Zieman »

WinXP Pro 32bit SP3
test 1.74.2

I get quite often an Aft laser when buying a ship that should be able to have just Front laser. Happens both with native and OXP ships.

On one occasion the ship for sale had no weapon upgrades listed, and in shipyard.plist forward_weapon_type is set to EQ_WEAPON_BEAM_LASER - the ship had both Forward Pulse Laser and Aft Beam Laser fitted (yes, the weapon_facings is set to 1 in shipyard.plist). :o
...and keep it under lightspeed!

Friendliest Meteor Police that side of Riedquat

[EliteWiki] Far Arm ships
[EliteWiki] Z-ships
[EliteWiki] Baakili Far Trader
[EliteWiki] Tin of SPAM
User avatar
Kaks
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 3009
Joined: Mon Jan 21, 2008 11:41 pm
Location: The Big Smoke

Post by Kaks »

Oooh, that's a good one! :)

In trunk the weapon facings flag is now used to figure out if the player can install new lasers in those specific facings (in other words, you could get a ship with 4 fixed weapon types & weapon_facings = 0). That would mean you cannot change any of the pre-installed weapons with others of your choice.

I'm not quite sure whether this bug actually classifies as a bug, or is just a quirk! :)
Hey, free OXPs: farsun v1.05 & tty v0.5! :0)
User avatar
Zieman
---- E L I T E ----
---- E L I T E ----
Posts: 680
Joined: Tue Sep 01, 2009 11:55 pm
Location: in maZe

Post by Zieman »

It definitely is a bug.

When a ship should be able to have only one laser, Forward laser, it is still assigned an Aft laser.

Further testing revealed this:
if in shipyard.plist forward_weapon_type is set to EQ_WEAPON_BEAM_LASER - the ship has both Forward Pulse Laser and Aft Beam Laser fitted
BUT
if I set aft_weapon_type instead in shipyard.plist to EQ_WEAPON_BEAM_LASER - the ship has only Forward Beam Laser fitted, no Aft laser

Looks like forward_weapon_type in shipyard.plist sets the actual Aft weapon and vice versa!
...and keep it under lightspeed!

Friendliest Meteor Police that side of Riedquat

[EliteWiki] Far Arm ships
[EliteWiki] Z-ships
[EliteWiki] Baakili Far Trader
[EliteWiki] Tin of SPAM
User avatar
Kaks
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 3009
Joined: Mon Jan 21, 2008 11:41 pm
Location: The Big Smoke

Post by Kaks »

Thanks for the thorough investigation! :)
Hey, free OXPs: farsun v1.05 & tty v0.5! :0)
User avatar
Zieman
---- E L I T E ----
---- E L I T E ----
Posts: 680
Joined: Tue Sep 01, 2009 11:55 pm
Location: in maZe

Post by Zieman »

You're welcome. :)

Alas, after further study it doesn't seem so straightforward...

Looks like there's something weird happening when a ship is bought and it is given extra equipment. The game seems to throw in random Aft weapons to all ships. Here "random" includes "none", and "all ships" means that any ship bought can get an Aft weapon regardless of equipment listed in ship purchase screen (no mention of Aft weapon upgraded to xxx) and regardless of weapon_facings.
...and keep it under lightspeed!

Friendliest Meteor Police that side of Riedquat

[EliteWiki] Far Arm ships
[EliteWiki] Z-ships
[EliteWiki] Baakili Far Trader
[EliteWiki] Tin of SPAM
User avatar
Cmdr James
Commodore
Commodore
Posts: 1357
Joined: Tue Jun 05, 2007 10:43 pm
Location: Berlin

Post by Cmdr James »

I think Ive got a nice simple fix, but Im testing it before i commit. Expect it to be fixed in trunk within a day or so once Im happy with it.
Post Reply