guiScreenChanged not working?

[Nemoricus]

I'm writing a script that uses this.guiScreenChanged = function (to) and Oolite is not recognizing it as a function.

Is this something that I'm doing wrong, or is there a problem with Oolite 1.72.2 with that event handler?

Error log:

Code: Select all

[script.javaScript.exception.22]: ***** JavaScript exception: TypeError: this.guiScreenChanged is not a function
[script.javaScript.exception.22]:       AddOns/Galactic_Navy.oxp/Scripts/galnavymain.js, line 201.
[script.javaScript.load.failed]: ***** Error loading JavaScript script AddOns/Galactic_Navy.oxp/Scripts/galnavymain.js -- could not run script
[script.load.notFound]: ***** Could not find a valid script file named galnavymain.js.

My code:

Code: Select all

//Brings up appropriate screens after the mission screen ends.
this.guiScreenChanged = function(to)
{
	if(missionVariables.navy_officer == "SCOOPED")
		this.OfficerRescueReward();

	if(player.ship.dockedStation.name == "Navy SecCom Station")
		this.SecComBusiness();
}

[Frame]

you got some basic errors there... none of them reveal though, why it is not accepting that as a function.. I'm not even sure you need (to) We need to see the entire script file..

but to point out...

your code

Code: Select all

if(player.ship.dockedStation.name == "Navy SecCom Station") 

Will generate an error when the player is not docked... because dockedStation will be Null, and then you effectively call a property of null which is illegal and will generate an Exception.

you need to do it like this

Code: Select all

if(player.ship.docked) //we check first for if the player is docked...
{
   if(player.ship.dockedStation.name == "Navy SecCom Station")
   this.SecComBusiness(); 
}

Ahh i just figured out what you did wrong... you have this.guiScreenChanged() put inside another function.. it means the function is never declared thus unknown to the system, or as it writes, not a function. Still we need the entire script...I'm not even sure you are pasting the correct lines from where to error originates... as you should have just declared that funtion, inside another according to what you pasted.. however.. you still need to show us the entire script file.

[Nemoricus]

Okay, I have to admit that I'm not quite sure what you're trying to say.

I need to have it so that it checks if the player is docked for both function calls. I didn't notice that until after you mentioned the docking bit.

However, this.guiScreenChanged = function(to){} is as the wiki has it. I also know that it's this line that's generating the error as that's the only time I'm using that event handler.

Here's the whole script.

[Eric Walch]

I'm writing a script that uses this.guiScreenChanged = function (to) and Oolite is not recognizing it as a function.

Your code as listed is correct. I use in my script for some time:

Code: Select all

this.guiScreenChanged = function(newScreen, oldScreen)
{
	if(oldScreen == "GUI_SCREEN_REPORT") this.ups_missionOffers();
}

without any problems. It is even used in one of oolites own internal missions (Constrictor Hunt.js)

[Nemoricus]

Interesting. I didn't change anything and it seems to be working just fine now. Of course, I found another error in my script, but it's unrelated.

Thanks, both of you.

[CaptKev]

I'm using the code below to produce the system data screen like the one above whenever a different system is selected in the long or short range charts.

The only problem is the planet texture doesn't refresh until I reselect the system data screen again.

Does anyone know of a way around this problem?

Code: Select all

this.guiScreenChanged = function(toGUI, fromGUI) {

	if (toGUI == 'GUI_SCREEN_SYSTEM_DATA') {

		if (!system.infoForSystem(galaxyNumber, player.ship.targetSystem).texture) {

			system.infoForSystem(galaxyNumber, player.ship.targetSystem).texture = 'home_planet' + (((this.system_info[galaxyNumber * 256 + player.ship.targetSystem] & 0x3F000) >> 12) + 1) + '.png';
		}
		var sInhabitants = system.infoForSystem(galaxyNumber, player.ship.targetSystem).inhabitants;
		var aInhabitants = sInhabitants.split(" ");
		setScreenOverlay(aInhabitants[(aInhabitants.length - 1)] + ".png");
	}
}

[DaddyHoggy]

Can't help with a fix, but your frog doesn't look very blue (or does the description refer to their state-of-mind and general outlook on life?)

[Cmdr Wyvern]

Can't help with a fix, but your frog doesn't look very blue (or does the description refer to their state-of-mind and general outlook on life?)

Said frog doesn't look very cheerful. Maybe that's where the "blue" comes from.
And he's donning a rather primitive dress. I would think they'd trade in the leather loincloths for suits on a TL 14, rich industrial corporate state.

[CaptKev]

I only have eight different images at the moment (Birds, Colonials, Felines, Frogs, Insects, Lizards, Lobsters and Rodents).

[Thargoid]

To go back to the original question - I'm not sure that there is a way at the moment. There is this.guiScreenWillChange(to, from), but that only fires for selected gui screens (not including the system data one).

Perhaps it may be worth requesting that function triggers for all screens, or at least for this one?

[Cmd. Cheyd]

LOL. I'd been working on a similar function for my OXP, Capt. Kev. Ran into the same issue, then shelved it for the time being.

[CaptKev]

@Thargoid, thanks for the info. I did try guiScreenWillChange(), now I know why it didn't work.

@Cmd. Cheyd, maybe if we both ask the Dev's really nicely

[CaptKev]

Can't help with a fix, but your frog doesn't look very blue (or does the description refer to their state-of-mind and general outlook on life?)

Said frog doesn't look very cheerful. Maybe that's where the "blue" comes from.
And he's donning a rather primitive dress. I would think they'd trade in the leather loincloths for suits on a TL 14, rich industrial corporate state.

Not just a suit a space suit

[caracal]

Can't help with a fix, but your frog doesn't look very blue (or does the description refer to their state-of-mind and general outlook on life?)

Said frog doesn't look very cheerful. Maybe that's where the "blue" comes from.
And he's donning a rather primitive dress. I would think they'd trade in the leather loincloths for suits on a TL 14, rich industrial corporate state.

Not just a suit a space suit

Okay, this is freakin' gorgeous, CaptKev! Will have me straying to the F7 screen a lot more often once you release, and planet textures be hanged. I only care about those when I'm actually orbiting the planet anyway.

[another_commander]

As of revision 3734, guiScreenWillChange is fired also just before switching to planet info screen.

Now bring the nice pics on!