Killer Wolf's Dynamic HUD scoop

Post by **Getafix** » Sun Jul 25, 2010 11:00 am

Using Killer Wolf's Dynamic HUD
the scoop activity keeps saying 'scoop' and the fuel bar does not increase.
After some-time it stops but most probably due to internal OXP status change
and not due to scooping end.

This can be easily replicated during sun skimming.

Oolite 1.74.1
Linux 64bit

List of OXP's
../AddOns/BGS-A1.0.oxp
../AddOns/Famous_Planets_v2.0.oxp
../AddOns/genericHUD.oxp
../AddOns/Griff_Debris_sets135_no_normal_map.oxp
../AddOns/griff_shipset_dizzy's_all_in_1.oxp
../AddOns/halsis.oxp
../AddOns/YOUR_AD_HERE.oxp
../AddOns/YOUR_AD_HERE_set_A.oxp
../AddOns/YOUR_AD_HERE_set_B.oxp
../AddOns/YOUR_AD_HERE_set_C.oxp
../AddOns/YOUR_AD_HERE_set_D.oxp
../AddOns/YOUR_AD_HERE_set_E.oxp
../AddOns/YOUR_AD_HERE_set_F.oxp

EDIT: Detected while frying some trumbles for Wookie's dinner.

Post by **another_commander** » Sun Jul 25, 2010 1:23 pm

The fuel scoop function is based on an accumulator which depends on flight speed. If you come to a halt in the middle of scooping, the accumulator becomes zero (because flight speed is zero) and no more fuel is added. Fuel continues to accumulate once you resume flight. This has been like this since 1.65 and is by design.

If this is not what you have witnessed, then some further replication clarifications will be needed.

Post by **Getafix** » Sun Jul 25, 2010 5:13 pm

I've tested a bit more and
I think it's the same behavior as discussed here.

Post by **Kaks** » Sun Jul 25, 2010 6:31 pm

We could aways stop the sound loop if we're actually scooping fuel, and we're at a stand still. Is that what you had in mind?

Post by **Getafix** » Sun Jul 25, 2010 6:44 pm

Yes, that is what I think should happen.

Post by **Kaks** » Sun Jul 25, 2010 7:10 pm

I think I know where to do that with the least amount of fuss... I'll be in touch!

Killer Wolf · Post by **Killer Wolf** » Sun Jul 25, 2010 7:46 pm

worked fine for me in testing, i had to go to the sun to test out the size of the temp bar etc, and always managed to scoop. i have noticed that on occasion the "S" indicator flickers like a mad bastard tho ~ i'm usually shooting things (ie cops) to test snafu HUDs etc, so i dunno if that contributes.

Post by **Kaks** » Mon Jul 26, 2010 10:25 am

KW, it's only that, if you stop to a standstill inside the corona you won't be able to scoop any fuel, no matter how close to the star you actually are. This is working as designed, since you're supposed to scoop fuel only if you actively skim the corona. However, the scoop sound & icon give the wrong impression that something should happen, but nothing does!

Anyway, got it & will commit to trunk soon: if you stand still in the middle of a corona, the scoop sound & icon will stop, if you stand still to scoop some cargo more easily, everything works as before!

Post by **Getafix** » Mon Jul 26, 2010 10:57 am

Wouldn't it be better if there were three states,
when skimming the sun for fuel?

1. Cannot scoop (not close enough)
2. Can scoop (close enough but standing still)
3. Scooping (close enough with some velocity; scoop scoop scoop...)

Is this becoming complex or altering much the OXP interface?

Post by **Kaks** » Mon Jul 26, 2010 12:39 pm

Well, changing it from a yes/no value would definitely add complexity for no apparent reason.

With my change in trunk you now have

1 isn't scooping
2 isn't scooping
3 it's scooping

Which is clear enough. Before, you had the rather silly

1 isn't scooping
2 isn't scooping, but it looks like it is
3 it's scooping.

Cmd. Cheyd · Post by **Cmd. Cheyd** » Mon Jul 26, 2010 1:56 pm

On a side note to that Kaks, I know Cmd. James has / had a patch that exposed the "Scoop System" (Icon + sound) to js. Any chance of that making it in sometime soon?

Post by **Getafix** » Mon Jul 26, 2010 2:06 pm

Kaks wrote:
...isn't scooping, but it looks like it is...

Quantoom physics applied!