Bug in Feudal States

[myst.RAVEN]

OK, so I'm not sure whether this is the right place to post bug reports about OXPs, as opposed to the core game, but here goes.

OXP in question: Feudal States (ummm, as listed in the subject line )
Other OXPs installed: too many to list! (I can dump my addon folder to text, if necessary - let me know)

I am currently in G2, somewhere. I've docked with a Hunting Lodge, and read through all the duels, then went back into F8 (to browse the duels again), and found that now the second one I get looks like this:

feudal_firstname__he feudal_lastname_, feudal_middle__he_rank von Orverace is (etc.)
A bit further down: Lord feudal_lastname_ has (blah blah etc.)


EDIT: I just started another round of challenge readups, and on the first one I get the same issue with a female challenger, this time.
It's interesting that this doesn't happen to all - I just asked for next challenger, and that one shows up right. Might it be because there should be an underscore instead of a space between "__he" and "feudal_lastname_"? (I'm really grasping at straws here, as I really don't know how the code works...)

OK, some more funny business... I don't know whether this is intentional: upon accepting a challenge, the player is informed that no missiles or energy weapons are allowed. An equipped energy bomb becomes unavailable until the challenge is resolved. Missiles, however, are stripped away, and not returned - is this intended behaviour? (For example, if the player is refunded for the missiles, then I expect this is how it is meant to run.)

On another note: accepted a challenge and was amused to see my opponent plough straight into the nav buoy and vaporize herself - earning me 100,000 credits without a shot fired!

[another_commander]

Moved from Testing and Bug Reports, as it is an OXP issue.

[myst.RAVEN]

And too bad it can't be moved right into the existing Feudal States thread, where it belongs, technically... *sigh* I'll learn...!

[Ganelon]

I've been seeing the same glitch in Feudal States. But I figure it'll get worked out. It's a great OXP concept and most of it works well already, one of my personal favourites.

[Ramirez]

It's a minor typo in one of the scripts. If you open feudal-ranks.js script, in the second big IF statement there's a bit that says:

Code: Select all

player.rankGenerator_house == "Overace" 

Unfortunately I've misspelt the house name, it should be 'Orverace'. The result is that the script doesn't pick up the house correctly and consequentially it doesn't set the language, names and ranks properly. I'll do a fix soon.

[myst.RAVEN]

Thanks, Ramirez, I'll take a peek inside and try to fix it Oh, and I love the theme/flavour OXPs - gives those particular systems more definition.

[Ffoeg]

Having corrected 'Orverace' there is still an error in the

'feudal-fragment-shader-12.fragment'

as in the log extract below

[shader.compile.failure]: ***** ERROR: GLSL fragment shader compilation failed for feudal-fragment-shader-12.fragment:
>>>>> GLSL log:
0(89) : error C0000: syntax error, unexpected '{' at token "{"
0(89) : error C0501: type name expected at token "{"
0(90) : error C0000: syntax error, unexpected $undefined at token "<undefined>"
0(90) : error C0501: type name expected at token "<undefined>"
0(91) : error C1038: declaration of "vec3" conflicts with previous declaration at 0(90)
0(91) : error C0000: syntax error, unexpected $undefined at token "<undefined>"
0(91) : error C0501: type name expected at token "<undefined>"
0(92) : error C1038: declaration of "diffuse" conflicts with previous declaration at 0(92)
0(92) : warning C7531: pointers require "#extension GL_NV_shader_buffer_load : enable" before use
0(92) : error C1307: non constant expression for array size
0(92) : error C0000: syntax error, unexpected '.', expecting ',' or ';' at token "."
0(92) : error C0501: type name expected at token "."
0(92) : error C1038: declaration of "diffuse" conflicts with previous declaration at 0(92)
0(92) : warning C7531: pointers require "#extension GL_NV_shader_buffer_load : enable" before use
0(92) : error C0000: syntax error, unexpected '(' at token "("
0(92) : error C0501: type name expected at token "("
0(92) : warning C7022: unrecognized profile specifier "dot"
0(92) : error C0000: syntax error, unexpected ')' at token ")"
0(92) : error C0501: type name expected at token ")"
0(92) : warning C7022: unrecognized profile specifier "lightVector"
0(93) : error C1307: non constant expression for array size
0(93) : error C0000: syntax error, unexpected '.', expecting ',' or ')' at token "."
0(93) : error C0501: type name expected at token "."
0(93) : warning C7531: pointers require "#extension GL_NV_shader_buffer_load : enable" before use
0(93) : error C1121: pow: function type parameters not allowed
0(93) : error C0000: syntax error, unexpected '(' at token "("
0(93) : error C0501: type name expected at token "("
0(93) : warning C7022: unrecognized profile specifier "max"
0(93) : error C1121: dot: function type parameters not allowed
0(93) : error C0000: syntax error, unexpected ',' at token ","
0(93) : error C0501: type name expected at token ","
0(93) : warning C7022: unrecognized profile specifier "reflection"
0(93) : warning C7022: unrecognized profile specifier "eyeVector"
0(93) : error C1109: function type not allowed for parameter "dot"
0(93) : error C1109: function type not allowed for parameter "pow"
0(96) : error C1109: function type not allowed for parameter "main"
0(97) : error C0000: syntax error, unexpected '{', expecting ',' or ')' at token "{"
0(97) : error C0501: type name expected at token "{"
0(98) : error C0000: syntax error, unexpected '=' at token "="
0(98) : error C0501: type name expected at token "="
0(98) : warning C7022: unrecognized profile specifier "specular"
0(98) : error C1109: function type not allowed for parameter "vec4"
0(99) : error C0000: syntax error, unexpected ';', expecting ',' or ')' at token ";"
0(99) : error C0501: type name expected at token ";"
0(102) : error C0000: syntax error, unexpected ';', expecting ',' or ')' at token ";"
0(102) : error C0501: type name expected at token ";"
0(103) : error C0000: syntax error, unexpected ';', expecting ',' or ')' at token ";"
0(103) : error C0501: type name expected at token ";"
0(106) : error C0000: syntax error, unexpected ';', expecting ',' or ')' at token ";"
0(106) : error C0501: type name expected at token ";"
0(116) : warning C7531: pointers require "#extension GL_NV_shader_buffer_load : enable" before use
0(120) : error C0000: syntax error, unexpected ';', expecting ',' or ')' at token ";"
0(120) : error C0501: type name expected at token ";"
0(125) : warning C7531: pointers require "#extension GL_NV_shader_buffer_load : enable" before use
0(125) : error C0000: syntax error, unexpected ',' at token ","
0(125) : error C0501: type name expected at token ","
0(125) : warning C7022: unrecognized profile specifier "Decal1_Scale_and_Position"
0(125) : warning C7022: unrecognized profile specifier "Decal1_Rotation"
0(125) : error C1109: function type not allowed for parameter "the_decaliser"
0(126) : warning C7531: pointers require "#extension GL_NV_shader_buffer_load : enable" before use
0(126) : error C0000: syntax error, unexpected ',' at token ","
0(126) : error C0501: type name expected at token ","
0(126) : warning C7022: unrecognized profile specifier "Decal2_Scale_and_Position"
0(126) : warning C7022: unrecognized profile specifier "Decal2_Rotation"
0(126) : error C1109: function type not allowed for parameter "the_decaliser"
0(127) : warning C7531: pointers require "#extension GL_NV_shader_buffer_load : enable" before use
0(127) : error C0000: syntax error, unexpected ',' at token ","
0(127) : error C0501: type name expected at token ","
0(127) : warning C7022: unrecognized profile specifier "Decal3_Scale_and_Position"
0(127) : warning C7022: unrecognized profile specifier "Decal3_Rotation"
0(127) : error C1109: function type not allowed for parameter "the_decaliser"
0(128) : warning C7531: pointers require "#extension GL_NV_shader_buffer_load : enable" before use
0(137) : error C0000: syntax error, unexpected ';', expecting ',' or ')' at token ";"
0(137) : error C0501: type name expected at token ";"


[shader.load.fullModeFailed]: ----- WARNING: Could not build shader feudal-vertex-shader.vertex/feudal-fragment-shader-12.fragment in full complexity mode, trying simple mode.


I hope this helps to improve what is be a very entertaining oxp.

... barring the loss of any fuel tanks and missiles you have removed at the start and not returned before you leave!

Ffoeg

[Griff]

a long list of errors like that in these shaders tend to mean that there are some stray spaces left after the \ at the end of each line in the light macro in teh shader, there mustn't be any spaces or anything at all after the \ if there is it counts as a syntax error.
I had a go at trying to remove the macro from these older 'no normal map' shaders and instead use functions (as seen in the oolite default shader) to calculate the lighting, but whatever bit of code i came up with was a hideous abomination and wouldn't run