Page 1 of 1

"We hope you enjoyed Lave station Commander Jameson"

Posted: Sun Feb 20, 2011 9:01 pm
by Commander McLane
Which OXP is this consoleMessage from? I noticed that it isn't only displayed when I leave the main station, but any station in Lave, which doesn't make much sense.

Re: "We hope you enjoyed Lave station Commander Jameson"

Posted: Sun Feb 20, 2011 10:30 pm
by Svengali
Commander McLane wrote:
Which OXP is this consoleMessage from? I noticed that it isn't only displayed when I leave the main station, but any station in Lave, which doesn't make much sense.
Could be Famous Planets, but if I remember right there was a check for the distance to system main station.

Re: "We hope you enjoyed Lave station Commander Jameson"

Posted: Sun Feb 20, 2011 11:33 pm
by Commander McLane
Yeah, I found it:

Code: Select all

this.shipLaunchedFromStation = function() 
	{
	if(this.fpCheck(system.ID) && system.mainStation) // if player launched from the main station in a FP system.
		{ 
		if(this.extraA) {player.consoleMessage("We hope you enjoyed " + system.name + " station Commander " + player.name) }; // display launch message
		...
No distance check. system.mainStation only checks if the system has a main station (every system has one, so it will always be true), not if the player launched from it.

Suggestion:

Code: Select all

this.shipLaunchedFromStation = function(station) 
	{
	if(this.fpCheck(system.ID) && station.isMainStation) // if player launched from the main station in a FP system.
		{ 
		if(this.extraA) {player.consoleMessage("We hope you enjoyed " + system.name + " station, Commander " + player.name + ".") }; // display launch message
		...
Note also the added punctuation in the consoleMessage.

Re: "We hope you enjoyed Lave station Commander Jameson"

Posted: Sun Feb 20, 2011 11:52 pm
by JensAyton
Commander McLane wrote:
(every system has one, so it will always be true)
It’s now possible to launch from a carrier/station in interstellar space, so it won’t always be true.

Re: "We hope you enjoyed Lave station Commander Jameson"

Posted: Sun Feb 20, 2011 11:56 pm
by Commander McLane
Ahruman wrote:
Commander McLane wrote:
(every system has one, so it will always be true)
It’s now possible to launch from a carrier/station in interstellar space, so it won’t always be true.
Which means that with the current script the player won't be welcomed in an FP system, if he isn't in any system at all. This—at least—works as expected. :wink: