v1.74.2 and v1.75 trunk ship mutated?

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Switeck
---- E L I T E ----
---- E L I T E ----
Posts: 2411
Joined: Mon May 31, 2010 11:11 pm

v1.74.2 and v1.75 trunk ship mutated?

Post by Switeck »

Ships are getting "mutated", and I neither know what "mutated" means nor how to fix them:

[exception]: ***** Exception during [update:entity [<ShipEntity 0x115ea628>{"Cobra Mark III" position: (-3242.52, 656593, 686957) scanClass: CLASS_NEUTRAL status: STATUS_IN_FLIGHT}]] in [Universe update:] : NSGenericException : Collection <OOShipGroup: 0xa9a98e8> was mutated while being enumerated. *****

My setup:
Win XP Pro SP 3, 1 GB DDR1 SDRAM, Geforce 2 GTS AGP 4x video card with paltry amounts of ram on it (32 or 64?)

Here's my log:

Code: Select all

[log.header]: Opening log for Oolite development version 1.75.0.4254 (x86-32 test release) under Windows at 2011-02-07 18:28:59 -0600.
2 processors detected.
Build options: spoken messages, mass/fuel pricing, JavaScript console support, OXP verifier, localization tools, debug GraphViz support, JavaScript native callback profiling.

Note that the contents of the log file can be adjusted by editing logcontrol.plist.

[display.mode.list.native]: Windows native resolution detected: 1024 x 768
[joystick.init]: Number of joysticks detected: 0
[dataCache.notFound]: No data cache found, starting from scratch.
[searchPaths.dumpAll]: Unrestricted mode - resource paths:
    Resources
    ../AddOns
    ../AddOns/auto_eject.oxp
    ../AddOns/DeepSpacePirates 1.2.5.oxp
    ../AddOns/Dredgers 2.4.3 Swi-MOD.oxp
    ../AddOns/Flight Log 1.02.oxp
    ../AddOns/FuelCollectorV0.06.oxp
    ../AddOns/globestation2.0.oxp
    ../AddOns/hOopyCasino1.2.1.oxp
    ../AddOns/LongRangeScanner v0.0.oxp
    ../AddOns/Missile Countermeasures 0.31.oxp
    ../AddOns/OMEGA.oxp
    ../AddOns/Ore_processor 1.58.oxp
    ../AddOns/RepairBots 2.00.oxp
    ../AddOns/Sothis.oxp
    ../AddOns/Superhubv1.2.1.oxp
    ../AddOns/Switeck_mod_v0.4.oxp
    ../AddOns/Various.oxp
[rendering.opengl.version]: OpenGL renderer version: 1.5.3 ("1.5.3"). Vendor: "NVIDIA Corporation". Renderer: "GeForce2 GTS/AGP/SSE2".
[rendering.opengl.extensions]: OpenGL extensions (74):
GL_EXT_abgr, GL_S3_s3tc, GL_IBM_texture_mirrored_repeat, GL_EXT_texture_edge_clamp, GL_EXT_separate_specular_color, GL_EXT_blend_minmax, GL_EXT_texture_object, GL_ARB_texture_env_add, GL_NV_texture_env_combine4, GL_EXT_texture_cube_map, GL_EXT_texture_env_dot3, GL_IBM_rasterpos_clip, GL_ARB_texture_env_dot3, GL_NV_light_max_exponent, GL_EXT_blend_subtract, GL_ARB_multitexture, GL_NV_register_combiners, GL_EXT_stencil_wrap, GL_NV_vertex_program, GL_ARB_texture_env_combine, GL_NV_fog_distance, GL_SUN_slice_accum, GL_EXT_packed_pixels, GL_EXT_texture_env_add, GL_SGIS_texture_lod, GL_ARB_transpose_matrix, GL_NV_texgen_reflection, GL_NV_packed_depth_stencil, GL_ARB_shading_language_100, GL_EXT_rescale_normal, GL_EXT_secondary_color, GL_EXT_paletted_texture, GL_ARB_texture_mirrored_repeat, GL_NV_fence, GL_EXT_draw_range_elements, GL_EXT_texture_lod_bias, GL_EXT_texture_filter_anisotropic, WGL_EXT_swap_control, GL_SGIS_generate_mipmap, GL_NV_texture_rectangle, GL_ARB_texture_rectangle, GL_ARB_point_sprite, GL_EXT_texture_lod, GL_EXT_texture_compression_s3tc, GL_ARB_vertex_shader, GL_ARB_vertex_buffer_object, GL_WIN_swap_hint, GL_ARB_shader_objects, GL_ARB_imaging, GL_EXT_Cg_shader, GL_NV_vertex_array_range, GL_NV_point_sprite, GL_NV_pixel_data_range, GL_SGIS_multitexture, GL_NV_vertex_array_range2, GL_KTX_buffer_region, GL_EXT_fog_coord, GL_ARB_window_pos, GL_EXT_point_parameters, GL_EXT_texture_env_combine, GL_ARB_vertex_program, GL_EXT_shared_texture_palette, GL_EXT_compiled_vertex_array, GL_EXT_bgra, GL_ARB_texture_cube_map, GL_ARB_point_parameters, GL_EXT_vertex_array, GL_EXT_multi_draw_arrays, GL_ARB_texture_compression, GL_EXT_clip_volume_hint, GL_EXT_blend_color, GL_NV_vertex_program1_1, GL_NV_blend_square, GL_EXT_pixel_buffer_object
[rendering.opengl.shader.support]: Shaders will not be used (OpenGL extension GL_ARB_fragment_shader is not available).
[shipData.load.begin]: Loading ship data.
[script.load.world.listAll]: Loaded 22 world scripts:
    auto-eject 1.0
    deep_space_dredger 2.4.3
    deep_space_pirates 1.2.98
    display-reputation-contract 1.1
    display-reputation-passenger 1.1
    FlightLog 1.02
    Fuel Collector 0.06
    hoopy_casino 1.2
    LongRangeScanner 0.1
    mcm_system 1.0
    oolite-cloaking-device 1.75
    oolite-constrictor-hunt 1.75
    oolite-nova 1.75
    oolite-thargoid-plans 1.75
    oolite-trumbles 1.75
    oreProcessor 1.57
    Pirate Cove Rock 1.2.2
    Repair system 2.0
    rockHermit_Locator 1.3.3
    targetAutolock 1.10
    TrafficControl 1.1
    Welcome Information Script 1.1
[Flightlog]: Kills Store set to player score
[loading.complete]: ========== Loading complete. ==========
[script.load.world.listAll]: Loaded 22 world scripts:
    auto-eject 1.0
    deep_space_dredger 2.4.3
    deep_space_pirates 1.2.98
    display-reputation-contract 1.1
    display-reputation-passenger 1.1
    FlightLog 1.02
    Fuel Collector 0.06
    hoopy_casino 1.2
    LongRangeScanner 0.1
    mcm_system 1.0
    oolite-cloaking-device 1.75
    oolite-constrictor-hunt 1.75
    oolite-nova 1.75
    oolite-thargoid-plans 1.75
    oolite-trumbles 1.75
    oreProcessor 1.57
    Pirate Cove Rock 1.2.2
    Repair system 2.0
    rockHermit_Locator 1.3.3
    targetAutolock 1.10
    TrafficControl 1.1
    Welcome Information Script 1.1
[Fuel Collector]: Number of globes is 1
[Fuel Collector]: Number of globes is 1
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x4c1fad8> was mutated while being enumerated.
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x4c1fad8> was mutated while being enumerated.
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x4c1fad8> was mutated while being enumerated.
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (516.35, -4206.91, 294308) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (4319.32, -975.249, 316215) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x4c1fad8> was mutated while being enumerated.
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (4788.17, -17479, 274905) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x4c1fad8> was mutated while being enumerated.
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x4c1fad8> was mutated while being enumerated.
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x4c1fad8> was mutated while being enumerated.
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (4083.32, -18859.9, 273311) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (6496.63, -17829.3, 271642) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[Fuel Collector]: distance below 301
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (19827.3, 108760, 560966) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (19817.4, 108154, 561274) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (-6025.51, -14352.6, 382859) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (34608.6, -44241.8, 306181) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[Fuel Collector]: Number of globes is 1
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (2082.64, -7664.75, 166544) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (7078.57, -22187.1, 312983) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[Fuel Collector]: distance below 301
[Fuel Collector]: Number of globes is 1
[Fuel Collector]: Number of globes is 1
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x559d388> was mutated while being enumerated.
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x559d388> was mutated while being enumerated.
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (-4364.68, -6183.77, 210992) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x559d388> was mutated while being enumerated.
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x559d388> was mutated while being enumerated.
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (-2995.52, -6126.7, 211587) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x559d388> was mutated while being enumerated.
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x559d388> was mutated while being enumerated.
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (2798.89, 2366.41, 88729.8) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (6250.33, 12253.3, 39534.1) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (-3359.56, -5956.61, 214369) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (-4656.21, 4597.18, 24846.4) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[Fuel Collector]: Number of globes is 1
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (-13562.3, -4359.56, 235611) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[Fuel Collector]: Number of globes is 1
[Fuel Collector]: Number of globes is 1
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x6fda0b8> was mutated while being enumerated.
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x6fda0b8> was mutated while being enumerated.
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x6fda0b8> was mutated while being enumerated.
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x6fda0b8> was mutated while being enumerated.
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x6fda0b8> was mutated while being enumerated.
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (-1476.36, -17126.5, 105390) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[script.load.world.listAll]: Loaded 22 world scripts:
    auto-eject 1.0
    deep_space_dredger 2.4.3
    deep_space_pirates 1.2.98
    display-reputation-contract 1.1
    display-reputation-passenger 1.1
    FlightLog 1.02
    Fuel Collector 0.06
    hoopy_casino 1.2
    LongRangeScanner 0.1
    mcm_system 1.0
    oolite-cloaking-device 1.75
    oolite-constrictor-hunt 1.75
    oolite-nova 1.75
    oolite-thargoid-plans 1.75
    oolite-trumbles 1.75
    oreProcessor 1.57
    Pirate Cove Rock 1.2.2
    Repair system 2.0
    rockHermit_Locator 1.3.3
    targetAutolock 1.10
    TrafficControl 1.1
    Welcome Information Script 1.1
[Fuel Collector]: Number of globes is 1
[Fuel Collector]: Number of globes is 1
[Fuel Collector]: Number of globes is 1
[script.load.world.listAll]: Loaded 22 world scripts:
    auto-eject 1.0
    deep_space_dredger 2.4.3
    deep_space_pirates 1.2.98
    display-reputation-contract 1.1
    display-reputation-passenger 1.1
    FlightLog 1.02
    Fuel Collector 0.06
    hoopy_casino 1.2
    LongRangeScanner 0.1
    mcm_system 1.0
    oolite-cloaking-device 1.75
    oolite-constrictor-hunt 1.75
    oolite-nova 1.75
    oolite-thargoid-plans 1.75
    oolite-trumbles 1.75
    oreProcessor 1.57
    Pirate Cove Rock 1.2.2
    Repair system 2.0
    rockHermit_Locator 1.3.3
    targetAutolock 1.10
    TrafficControl 1.1
    Welcome Information Script 1.1
[Fuel Collector]: Number of globes is 1
[Fuel Collector]: Number of globes is 1
[Fuel Collector]: Number of globes is 1
[Fuel Collector]: Number of globes is 1
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (-11211.3, -6168.4, 147695) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[Fuel Collector]: Number of globes is 1
[Fuel Collector]: Number of globes is 1
[Fuel Collector]: Number of globes is 1
[Fuel Collector]: Number of globes is 1
[Fuel Collector]: Number of globes is 1
[exception]: ***** Exception during [update:entity [<ShipEntity 0x115ea628>{"Cobra Mark III" position: (-3242.52, 656593, 686957) scanClass: CLASS_NEUTRAL status: STATUS_IN_FLIGHT}]] in [Universe update:] : NSGenericException : Collection <OOShipGroup: 0xa9a98e8> was mutated while being enumerated. *****
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6683
Joined: Wed Feb 28, 2007 7:54 am

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by another_commander »

Can you reproduce it with the latest nightly? It looks like you don't have that many OXPs (although I am not sure what that Various.oxp really is), so it would be helpful to find out which of them is causing the exception to kick in.
Switeck
---- E L I T E ----
---- E L I T E ----
Posts: 2411
Joined: Mon May 31, 2010 11:11 pm

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by Switeck »

I'll try testing again with the latest trunk...downloaded less than 2 hours ago for Wed. Feb 9th, 2011.

"Various.oxp" is a hand-packed-together (by me) grouping of multiple OXPs:
display-reputation-contract 1.1
display-reputation-passenger 1.1
rockHermit_Locator 1.3.3
targetAutolock 1.10
TrafficControl 1.1
Welcome Information Script 1.1

It also contains Military Missile, my replacement Commodities file for LOTS of stations, and my keyconfig.plist
I created it to work on my scripting and OXP skills, and it's a work-in-progress. It's quite possible there's typos in it, but usually I spot and remove those. :lol:
Note also any of the other OXPs may be edited...so I'll eliminate what I can in testing.

...If I knew just a little more of the nature of the error, I could probably eliminate a lot of OXPs.
User avatar
Kaks
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 3009
Joined: Mon Jan 21, 2008 11:41 pm
Location: The Big Smoke

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by Kaks »

Switeck wrote:
Ships are getting "mutated", and I neither know what "mutated" means nor how to fix them:

[exception]: ***** Exception during [update:entity [<ShipEntity 0x115ea628>{"Cobra Mark III" position: (-3242.52, 656593, 686957) scanClass: CLASS_NEUTRAL status: STATUS_IN_FLIGHT}]] in [Universe update:] : NSGenericException : Collection <OOShipGroup: 0xa9a98e8> was mutated while being enumerated. *****
No mutated ships, honest! :)

A mutated collection means: there were 3 (or 2, or 5) objects (in this case ships) inside this collection (in this case a OOShipGroup) when the code started enumerating them (going through all the ships in the ship group one at a time) - there's now a different number of objects inside the collection and the code isn't through enumerating them.

The most likely explanation is that one ship in the same group died as the universe display was being redrawn.
This problem, or something very similar, has been found & corrected in trunk a while ago.
If you try the nightly build it should hopefully confirm that the problem you've encountered is indeed the one solved already.
Hey, free OXPs: farsun v1.05 & tty v0.5! :0)
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by Commander McLane »

Kaks wrote:
No mutated ships, honest! :)
... although spontaneous mutations of pilots in the radiation-rich environment of witchspace have been rumoured about... :shock: :roll:
User avatar
Smivs
Retired Assassin
Retired Assassin
Posts: 8408
Joined: Tue Feb 09, 2010 11:31 am
Location: Lost in space
Contact:

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by Smivs »

Commander McLane wrote:
Kaks wrote:
No mutated ships, honest! :)
... although spontaneous mutations of pilots in the radiation-rich environment of witchspace have been rumoured about... :shock: :roll:
Nonsense!
This was me before my spacefaring days

Image

and this is me now.

Image

No difference at all. :?
Commander Smivs, the friendliest Gourd this side of Riedquat.
Zireael
---- E L I T E ----
---- E L I T E ----
Posts: 1396
Joined: Tue Nov 09, 2010 1:44 pm

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by Zireael »

*has a fit of giggles at the thought of mutating ships in Ooniverse*
User avatar
DaddyHoggy
Intergalactic Spam Assassin
Intergalactic Spam Assassin
Posts: 8515
Joined: Tue Dec 05, 2006 9:43 pm
Location: Newbury, UK
Contact:

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by DaddyHoggy »

Zireael wrote:
*has a fit of giggles at the thought of mutating ships in Ooniverse*
Read Lazarus in the Fiction section - that's all about ship mutations... (clearly a rather portentous story!)
Selezen wrote:
Apparently I was having a DaddyHoggy moment.
Oolite Life is now revealed here
Switeck
---- E L I T E ----
---- E L I T E ----
Posts: 2411
Joined: Mon May 31, 2010 11:11 pm

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by Switeck »

I've narrowed it down a lot...so much so that the zip of my Addons folder is actually pretty tiny:
http://www.mediafire.com/?ab35zei27t940mt

What I don't get is in 1 of the logs I see this repeated MULTIPLE times with other presumably unrelated "events" separating it:
[exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x70cbaa0> was mutated while being enumerated.
It's always <OOShipGroup: 0x70cbaa0> ...quite odd!

I included it in the zip found here:
http://www.mediafire.com/?ab35zei27t940mt

My guess is, based on what Kaks said, my Switeck mod...which is in a state of flux while testing. I had escortAI.plist and dumbAI.plist start out their global section with this:
ENTER = (becomeExplosion);
...Which removes all the unwanted objects so I could more easily test with 200+ active NPC ships. (minus their escorts)

...That may not explain why sometimes a mutated ship is named and other times it's <OOShipGroup: 0x70cbaa0> !
User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by JensAyton »

The exploding escorts don’t immediately trigger the error in trunk or 1.74. I’ll leave them both running while I’m at work.
User avatar
Kaks
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 3009
Joined: Mon Jan 21, 2008 11:41 pm
Location: The Big Smoke

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by Kaks »

No mutations here either. Could you give us a copy of your save game & a brief description of what to do with it eg:

after loading the savegame, I jump to system x, fly around for y minutes, then exit oolite. At that point I the log always contains the mutation entry...

- or something along those lines...
Hey, free OXPs: farsun v1.05 & tty v0.5! :0)
Switeck
---- E L I T E ----
---- E L I T E ----
Posts: 2411
Joined: Mon May 31, 2010 11:11 pm

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by Switeck »

I don't know what triggers it and sometimes it happens within 5 minutes, and other times I can go for hours and it doesn't happen.
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6683
Joined: Wed Feb 28, 2007 7:54 am

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by another_commander »

Code: Select all

exception]: ***** Exception in pollFlightControls [shoot]: NSGenericException : Collection <OOShipGroup: 0x559d388> was mutated while being enumerated
This code refers to something that happens when you fire lasers. The reason I asked if the problem is repeatable in the latest trunk is that Ahruman recently fixed some problems that occured after a revision of the laser shot implementation. The trigger for the exception is in PlayerEntityControls.m, around line 755 of the latest trunk:

Code: Select all

exceptionContext = @"shoot";
//  shoot 'a'
if ((([gameView isDown:key_fire_lasers])||((mouse_control_on)&&([gameView isDown:gvMouseLeftButton]))||joyButtonState[BUTTON_FIRE])&&(shot_time > weapon_reload_time))
{
	if ([self fireMainWeapon])
	{
		[self playLaserHit:[self shipHitByLaser] != nil];
	}
}
Whatever it is that goes wrong, it goes wrong inside here or in the code that gets called from here. Anyway, please confirm what happens with latest trunk and then we can see how we can make it repeatable, if possible.
Last edited by another_commander on Thu Feb 10, 2011 1:35 pm, edited 1 time in total.
Reason: PlayerEntityControls.m, not PlayerEntity.m
Switeck
---- E L I T E ----
---- E L I T E ----
Posts: 2411
Joined: Mon May 31, 2010 11:11 pm

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by Switeck »

I had a crash to desktop with this error being the last thing in the log file:
[exception]: ***** Exception during [update:entity [<ShipEntity 0x7cab010>{"Anaconda" position: (-4433.96, -7397.54, 13814) scanClass: CLASS_NEUTRAL status: STATUS_IN_FLIGHT}]] in [Universe update:] : NSGenericException : Collection <OOShipGroup: 0x7609108> was mutated while being enumerated. *****

...But this was using yesterday's build.
I'll test today's build after I sleep again.

I'm using the Omega ship in my testing...it may be to blame.

Here's one of the savegames I'm using with it:
http://pastebin.com/wPUSRZwJ

New update to report:
I started from scratch with a brand new game, hacked it to have 10 million credits, made my first jump to Zaonce, bought injectors, large cargo bay, and Advanced Space Compass, set TAF to 16x, jumped to Qutiri ...and within moments I got a crash-to-desktop with this as the last messages in the log:
[Added a PIRATE!]: 36
[Added a trader.]: 27
[Added a PIRATE!]: 37
[Added a trader.]: 28
[exception]: ***** Exception during [update:entity [<ShipEntity 0x18266ff8>{"Boa" position: (8223.19, 1092.17, 389976) scanClass: CLASS_NEUTRAL status: STATUS_IN_FLIGHT}]] in [Universe update:] : NSGenericException : Collection <OOShipGroup: 0x182d6af8> was mutated while being enumerated. *****

Yet more...now using the Feb 11th, 2011 trunk release, and now I'm seeing this in the log:

Code: Select all

[gnustep]: 2011-02-11 02:08:50.468 oolite[400] could not convert to UTF8 string! bytes=0x162d598 len=282

[gnustep]: 2011-02-11 02:09:02.875 oolite[400] Defaults path 'D:\Oolite-Trunk/oolite.app/GNUstep/Defaults' did not exist - created it

[gnustep]: 2011-02-11 02:09:02.875 oolite[400] Creating empty user defaults database

[Added a PIRATE!]: 2
...
[Added a PIRATE!]: 10
[Added a trader.]: 6
[gnustep]: 2011-02-11 02:11:10.406 oolite[400] could not convert to UTF8 string! bytes=0xc5ae730 len=282

[Added a PIRATE!]: 19
...
[Added a PIRATE!]: 60
[Added a trader.]: 56
[gnustep]: 2011-02-11 02:18:26.218 oolite[400] could not convert to UTF8 string! bytes=0xf43c730 len=282

[Added a PIRATE!]: 69
...
[Added a PIRATE!]: 99
[gnustep]: 2011-02-11 02:21:52.578 oolite[400] could not convert to UTF8 string! bytes=0xca8ca60 len=282

[Added a PIRATE!]: 8
...
[Added a PIRATE!]: 18
[Added a trader.]: 18
[gnustep]: 2011-02-11 02:23:45.765 oolite[400] could not convert to UTF8 string! bytes=0xf650730 len=282

[gnustep]: 2011-02-11 02:24:58.031 oolite[400] could not convert to UTF8 string! bytes=0xc79d730 len=282

[Added a PIRATE!]: 26
...
[Added a trader.]: 5
[gnustep]: 2011-02-11 02:26:42.906 oolite[400] could not convert to UTF8 string! bytes=0xc8cd730 len=282

[Added a PIRATE!]: 21
[Added a trader.]: 7
...
[Added a PIRATE!]: 17
[Added a trader.]: 12
[gnustep]: 2011-02-11 02:28:16.906 oolite[400] could not convert to UTF8 string! bytes=0xc79d730 len=282

[Added a PIRATE!]: 25
...
[Added a PIRATE!]: 96
[shipSpawned]: Setting scanner colors for [Ship "Escape capsule" position: (-14258.7, -27462.3, 225704) scanClass: CLASS_CARGO status: STATUS_IN_FLIGHT]
[gnustep]: 2011-02-11 02:40:43.968 oolite[400] could not convert to UTF8 string! bytes=0xfb7c730 len=282

[Added a PIRATE!]: 98
...
[gnustep]: 2011-02-11 03:20:36.562 oolite[400] could not convert to UTF8 string! bytes=0xfe64730 len=282
User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Re: v1.74.2 and v1.75 trunk ship mutated?

Post by JensAyton »

Having run with your AddOns folder and saved game for many days of game time (yay TAF and multiple copies of Oolite), I still haven’t been able to recreate this. I have to conclude that it isn’t a critical blocker.

If anyone else wants to try to catch this in GDB, and at least get a call stack, the exception is thrown att OOShipGroup.m:465.
Post Reply