Page 1 of 1
[UPDATED]Constrictor More Hints
Posted: Wed Aug 04, 2010 10:18 pm
by Arexack_Heretic
version
2.0 is now in javascript.
Legacy plist script is still in there, fixed in fact.
(I noticed a serious typo in the original)
..
Posted: Mon Aug 09, 2010 8:10 am
by Lestradae
Hi Arexack_H,
in the js script for this updated oxp there appears to be a typo in line 68 which I believe must say mission.addMessageTextKey("constrictor_hunt_1_253");, not mission.addMessageTextKey("constrictor_hunt_1_235");.
Cheers
L
Re: ..
Posted: Mon Aug 09, 2010 2:54 pm
by Arexack_Heretic
Lestradae wrote:Hi Arexack_H,
in the js script for this updated oxp there appears to be a typo in line 68 which I believe must say mission.addMessageTextKey("constrictor_hunt_1_253");, not mission.addMessageTextKey("constrictor_hunt_1_235");.
Cheers
L
Thanks for the report.
Did you actually recieve an error from oolite or is it by eye?
.... i cannot discern the difference between those two lines.
I'll look into it later tonight though. most of the script was pilfered from the native code, it might contain the same error.
Re: ..
Posted: Mon Aug 09, 2010 4:37 pm
by Smivs
Arexack_Heretic wrote:Lestradae wrote:Hi Arexack_H,
in the js script for this updated oxp there appears to be a typo in line 68 which I believe must say mission.addMessageTextKey("constrictor_hunt_1_253");, not mission.addMessageTextKey("constrictor_hunt_1_235");.
Cheers
L
Thanks for the report.
Did you actually recieve an error from oolite or is it by eye?
.... i cannot discern the difference between those two lines.
I'll look into it later tonight though. most of the script was pilfered from the native code, it might contain the same error.
It's the numbers...the first one reads 253, the second is 235.
Posted: Tue Aug 10, 2010 12:02 am
by Arexack_Heretic
aah!
Re: ..
Posted: Tue Aug 10, 2010 6:05 am
by Lestradae
Arexack_Heretic wrote:Did you actually recieve an error from oolite or is it by eye?
Found it by eye. The original .js line refers to a missiontext entry that doesn't exist, neither in the core game code nor in your oxp. The "253" missiontext entry is in the core games' missiontext entries, and with that number your script will work by simply adding that message to more systems. With "235" I assume there might be an error message in the log (didn't test that) but there will be no additional hint for sure.
Posted: Tue Aug 10, 2010 10:05 pm
by Arexack_Heretic
it's supposed to refer to the native missiontexts, that is correct.
I'll fix it for a next version, not much change from the pre js version, that one also only added a single hint.