Oolite Bulletins

Posted: **Sun Jun 20, 2010 10:41 am**

I have several times had the log entry

***** ERROR: one or more shipdata.plist entries have like_ship references that cannot be resolved:

There are several oxp's using

Code: Select all

         <key>like_ship</key>
         <string>EQ_HARDENED_MISSILE</string>

which seems to be the cause of the problem.
Should the like_ship not reference ecm-proof-missile ? Or have I got totally confused again?

Posted: **Sun Jun 20, 2010 10:44 am**

Yes it should. Which OXPs are incorrect?

Posted: **Sun Jun 20, 2010 11:04 am**

I'll check which ones do it and get back later, RL getting in the way today.

Posted: **Sun Jun 20, 2010 11:45 am**

Err... actually, if you want to like_ship a hardened missile, the correct way to do it is:

Code: Select all

<key>like_ship</key>
         <string>ecm-proof-missile</string>

in XML, or

Code: Select all

like_ship = 'ecm-proof-missile';

in openStep format...

Posted: **Sun Jun 20, 2010 12:06 pm**

That’s what they said. :-)

Posted: **Sun Jun 20, 2010 12:11 pm**

Must upgrade reading subsystem! And/or should stop trying to think when not yet awake... apologies for the misunderstanding -ment -ation -tude...

Posted: **Sun Jun 20, 2010 1:00 pm**

Just keep updating your oxp's.

From the release notes of commies.oxp version 2.10:

2.10 April 2010

Corrected the role for the ecm-proof-missiles. Has always been wrong resulting in launching plain missiles for some of the ships.

~~I assume its this oxp giving the warning. It has been wrong there since before the release of Oolite 1.65. If you don't log errors, nobody will start complaining.~~

EDIT, no, not this oxp. This had the bug the other way round. It defined the missiles itself by their ship-key.

Posted: **Sun Jun 20, 2010 1:26 pm**

Did a quick text string search through my addons folder and found references to EQ_HARDENED_MISSILE in all of these -

Cargo Wrecks teaser
Pods
Random Hits
UPS-courier
Assassins
Commies
Feudal States
Hotrods
Trident Down
adcks_behemoths
Galactic Navy

Posted: **Sun Jun 20, 2010 1:31 pm**

I think you need to narrow the search down a little. The Pods one for example (and quite probably the C&W one as well, and indeed some of the others too) is the awarding of a missile (for which EQ_MISSILE and EQ_HARDENED_MISSILE are correct as the award is by role not identifier key) rather than a like_ship reference.

Posted: **Sun Jun 20, 2010 9:38 pm**

At least -

Random Hits
Fuedal States
UPS Courier

contain "missile_role" = "EQ_HARDENED_MISSILE";

maybe some others have it as well but as I said RL is a problem today, I'll look further into the other oxp's tommorrow.

Posted: **Mon Jun 21, 2010 4:49 am**

That's also valid, as EQ_HARDENED_MISSILE is one of the role set for the ecm-proof-missile (have a look in the trunk shipdata.plist). In that case the line is saying that the default missile used by the ship is a hard-head.

Anything which uses the role of EQ_HARDENED_MISSILE is ok and valid, it's where the missile's idenfitier key is required but the "EQ_HARDENED_MISSILE" is used instead of "ecm-proof-missile" like you originally posted that would be wrong, for example like_ship.

Posted: **Mon Jun 21, 2010 4:57 am**

Ya, Gal navy and ADCK's Behemoths also have ships with missile_role EQ_HARDENED_MISSILE and am not getting any errors.

Posted: **Mon Jun 21, 2010 9:22 am**

OK I have more time and brain capacity to concentrate on this today.

First problem I caused was checking my oxp storage folder not addons and there are some older oxp's in there. I have now checked my current addons folder and there are only two oxp's with like_ship references to EQ_HARDENED_MISSILE.

Assassins shipdata.plist line 11is the only active oxp, the other one is in Realistic Shipyards Photon Torpedo.

It also seems I had placed a very old oxp in addons instead of updating to the new version which was the cause of most of the initial errors. I shall do penance by spending the day housekeeping my OOlite folders and polishing the rust on my Fer de Lance.